[PATCH] drm/i915: mdelay(10) considered harmful

[PATCH] drm/i915: mdelay(10) considered harmful

[Daniel Vetter]

I missed this myself when reviewing

commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <sonika.jindal@intel.com>
Date:   Tue Sep 15 09:44:20 2015 +0530

    drm/i915: Check live status before reading edid

Long sleeps like this really shouldn't waste cpy cycles spinning.

Cc: Sonika Jindal <sonika.jindal@intel.com>
Cc: "Wang, Gary C" <gary.c.wang@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index c3978bad5ca0..b0a5a883227c 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1397,7 +1397,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
 	while (!live_status && --retry) {
 		live_status = intel_digital_port_connected(dev_priv,
 				hdmi_to_dig_port(intel_hdmi));
-		mdelay(10);
+		msleep(10);
 	}
 
 	if (!live_status)
-- 
2.5.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: mdelay(10) considered harmful

[Chris Wilson]

On Fri, Dec 11, 2015 at 07:44:15PM +0100, Daniel Vetter wrote:
> I missed this myself when reviewing
> 
> commit 237ed86c693d8a8e4db476976aeb30df4deac74b
> Author: Sonika Jindal <sonika.jindal@intel.com>
> Date:   Tue Sep 15 09:44:20 2015 +0530
> 
>     drm/i915: Check live status before reading edid
> 
> Long sleeps like this really shouldn't waste cpy cycles spinning.

Also start contemplating async workers for detection?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: mdelay(10) considered harmful

[Jindal, Sonika]

%s/cpy/cpu

Reviewed-by: Sonika Jindal <sonika.jindal@intel.com>

On 12/12/2015 12:14 AM, Daniel Vetter wrote:
> I missed this myself when reviewing
>
> commit 237ed86c693d8a8e4db476976aeb30df4deac74b
> Author: Sonika Jindal <sonika.jindal@intel.com>
> Date:   Tue Sep 15 09:44:20 2015 +0530
>
>      drm/i915: Check live status before reading edid
>
> Long sleeps like this really shouldn't waste cpy cycles spinning.
>
> Cc: Sonika Jindal <sonika.jindal@intel.com>
> Cc: "Wang, Gary C" <gary.c.wang@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>   drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index c3978bad5ca0..b0a5a883227c 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1397,7 +1397,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
>   	while (!live_status && --retry) {
>   		live_status = intel_digital_port_connected(dev_priv,
>   				hdmi_to_dig_port(intel_hdmi));
> -		mdelay(10);
> +		msleep(10);
>   	}
>   
>   	if (!live_status)

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: mdelay(10) considered harmful

[Daniel Vetter]

On Mon, Dec 14, 2015 at 02:07:23PM +0530, Jindal, Sonika wrote:
> %s/cpy/cpu
> 
> Reviewed-by: Sonika Jindal <sonika.jindal@intel.com>

Queued for -next, thanks for the review.
-Daniel

> 
> On 12/12/2015 12:14 AM, Daniel Vetter wrote:
> >I missed this myself when reviewing
> >
> >commit 237ed86c693d8a8e4db476976aeb30df4deac74b
> >Author: Sonika Jindal <sonika.jindal@intel.com>
> >Date:   Tue Sep 15 09:44:20 2015 +0530
> >
> >     drm/i915: Check live status before reading edid
> >
> >Long sleeps like this really shouldn't waste cpy cycles spinning.
> >
> >Cc: Sonika Jindal <sonika.jindal@intel.com>
> >Cc: "Wang, Gary C" <gary.c.wang@intel.com>
> >Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >---
> >  drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> >index c3978bad5ca0..b0a5a883227c 100644
> >--- a/drivers/gpu/drm/i915/intel_hdmi.c
> >+++ b/drivers/gpu/drm/i915/intel_hdmi.c
> >@@ -1397,7 +1397,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
> >  	while (!live_status && --retry) {
> >  		live_status = intel_digital_port_connected(dev_priv,
> >  				hdmi_to_dig_port(intel_hdmi));
> >-		mdelay(10);
> >+		msleep(10);
> >  	}
> >  	if (!live_status)
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx