[PATCH 1/1] drm/i915: Enable HAS_RUNTIME_PM for BXT

[PATCH 1/1] drm/i915: Enable HAS_RUNTIME_PM for BXT

[Sagar Arun Kamble]

From: Sagar Kamble <sagar.a.kamble@intel.com>

With BXT, now all platforms from GEN6 to GEN9 support Runtime PM except IVB.

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Change-Id: I700bf5092d6462b64499d876efeaea9dfa540380
Signed-off-by: A.Sunil Kamath <sunil.kamath@intel.com>
Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 9124085..2a9ce02 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2593,10 +2593,9 @@ struct drm_i915_cmd_table {
 #define HAS_PSR(dev)		(IS_HASWELL(dev) || IS_BROADWELL(dev) || \
 				 IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \
 				 IS_SKYLAKE(dev) || IS_KABYLAKE(dev))
-#define HAS_RUNTIME_PM(dev)	(IS_GEN6(dev) || IS_HASWELL(dev) || \
-				 IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \
-				 IS_CHERRYVIEW(dev) || IS_SKYLAKE(dev) || \
-				 IS_KABYLAKE(dev))
+#define HAS_RUNTIME_PM(dev)	((INTEL_INFO(dev)->gen >= 6) && \
+				 (INTEL_INFO(dev)->gen <= 9) && \
+				 !IS_IVYBRIDGE(dev))
 #define HAS_RC6(dev)		(INTEL_INFO(dev)->gen >= 6)
 #define HAS_RC6p(dev)		(INTEL_INFO(dev)->gen == 6 || IS_IVYBRIDGE(dev))
 
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/1] drm/i915: Enable HAS_RUNTIME_PM for BXT

[Daniel Vetter]

On Sun, Dec 13, 2015 at 08:37:04PM +0530, Sagar Arun Kamble wrote:
> From: Sagar Kamble <sagar.a.kamble@intel.com>
> 
> With BXT, now all platforms from GEN6 to GEN9 support Runtime PM except IVB.
> 
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Change-Id: I700bf5092d6462b64499d876efeaea9dfa540380
> Signed-off-by: A.Sunil Kamath <sunil.kamath@intel.com>
> Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com>

It's apparently pure fireworks and we currently don't even have a BXT in
CI. Too early imo. Also, really, really, really, really should come in
tandem with the patch to enable runtime PM by default on at least some
machines, enabling features just on one platform with the excuse that the
big issues might get fixed in a few years really isn't sustainable.

Thanks, Daniel

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 9124085..2a9ce02 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2593,10 +2593,9 @@ struct drm_i915_cmd_table {
>  #define HAS_PSR(dev)		(IS_HASWELL(dev) || IS_BROADWELL(dev) || \
>  				 IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \
>  				 IS_SKYLAKE(dev) || IS_KABYLAKE(dev))
> -#define HAS_RUNTIME_PM(dev)	(IS_GEN6(dev) || IS_HASWELL(dev) || \
> -				 IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \
> -				 IS_CHERRYVIEW(dev) || IS_SKYLAKE(dev) || \
> -				 IS_KABYLAKE(dev))
> +#define HAS_RUNTIME_PM(dev)	((INTEL_INFO(dev)->gen >= 6) && \
> +				 (INTEL_INFO(dev)->gen <= 9) && \
> +				 !IS_IVYBRIDGE(dev))
>  #define HAS_RC6(dev)		(INTEL_INFO(dev)->gen >= 6)
>  #define HAS_RC6p(dev)		(INTEL_INFO(dev)->gen == 6 || IS_IVYBRIDGE(dev))
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx