* [PATCH] drm: fix blob pointer check
@ 2016-03-10 11:15 Lionel Landwerlin
0 siblings, 0 replies; 5+ messages in thread
From: Lionel Landwerlin @ 2016-03-10 11:15 UTC (permalink / raw)
To: intel-gfx; +Cc: daniel.vetter
As reported by Dan Carpenter.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 87d0b20..1caddb1 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -2917,8 +2917,8 @@ void drm_atomic_helper_legacy_gamma_set(struct drm_crtc *crtc,
blob = drm_property_create_blob(dev,
sizeof(struct drm_color_lut) * size,
NULL);
- if (!blob) {
- ret = -ENOMEM;
+ if (IS_ERR(blob)) {
+ ret = PTR_ERR(blob);
goto fail;
}
--
2.7.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drm: fix blob pointer check
@ 2016-03-10 12:04 Lionel Landwerlin
2016-03-10 12:10 ` [Intel-gfx] " Daniel Stone
2016-03-10 14:49 ` ✗ Fi.CI.BAT: failure for drm: fix blob pointer check (rev2) Patchwork
0 siblings, 2 replies; 5+ messages in thread
From: Lionel Landwerlin @ 2016-03-10 12:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, dri-devel, Daniel Stone
Check properly that the allocated blob's pointer is valid.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Daniel Stone <daniels@collabora.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 87d0b20..1caddb1 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -2917,8 +2917,8 @@ void drm_atomic_helper_legacy_gamma_set(struct drm_crtc *crtc,
blob = drm_property_create_blob(dev,
sizeof(struct drm_color_lut) * size,
NULL);
- if (!blob) {
- ret = -ENOMEM;
+ if (IS_ERR(blob)) {
+ ret = PTR_ERR(blob);
goto fail;
}
--
2.7.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm: fix blob pointer check
2016-03-10 12:04 [PATCH] drm: fix blob pointer check Lionel Landwerlin
@ 2016-03-10 12:10 ` Daniel Stone
2016-03-10 12:48 ` Daniel Vetter
2016-03-10 14:49 ` ✗ Fi.CI.BAT: failure for drm: fix blob pointer check (rev2) Patchwork
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Stone @ 2016-03-10 12:10 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: Daniel Vetter, intel-gfx, Daniel Stone, dri-devel
On 10 March 2016 at 12:04, Lionel Landwerlin
<lionel.g.landwerlin@intel.com> wrote:
> Check properly that the allocated blob's pointer is valid.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Daniel Stone <daniels@collabora.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: fix blob pointer check
2016-03-10 12:10 ` [Intel-gfx] " Daniel Stone
@ 2016-03-10 12:48 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2016-03-10 12:48 UTC (permalink / raw)
To: Daniel Stone; +Cc: Daniel Vetter, intel-gfx, dri-devel, Daniel Stone
On Thu, Mar 10, 2016 at 12:10:30PM +0000, Daniel Stone wrote:
> On 10 March 2016 at 12:04, Lionel Landwerlin
> <lionel.g.landwerlin@intel.com> wrote:
> > Check properly that the allocated blob's pointer is valid.
> >
> > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: Daniel Stone <daniels@collabora.com>
>
> Reviewed-by: Daniel Stone <daniels@collabora.com>
Applied to drm-misc, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm: fix blob pointer check (rev2)
2016-03-10 12:04 [PATCH] drm: fix blob pointer check Lionel Landwerlin
2016-03-10 12:10 ` [Intel-gfx] " Daniel Stone
@ 2016-03-10 14:49 ` Patchwork
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-03-10 14:49 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: intel-gfx
== Series Details ==
Series: drm: fix blob pointer check (rev2)
URL : https://patchwork.freedesktop.org/series/4296/
State : failure
== Summary ==
Series 4296v2 drm: fix blob pointer check
http://patchwork.freedesktop.org/api/1.0/series/4296/revisions/2/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (ilk-hp8440p)
Test kms_flip:
Subgroup basic-flip-vs-modeset:
dmesg-warn -> PASS (bdw-ultra)
Subgroup basic-flip-vs-wf_vblank:
pass -> DMESG-WARN (snb-x220t)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-b:
dmesg-warn -> PASS (snb-x220t)
Subgroup nonblocking-crc-pipe-b-frame-sequence:
dmesg-warn -> PASS (hsw-brixbox)
Subgroup read-crc-pipe-b:
pass -> DMESG-WARN (hsw-brixbox)
Test pm_rpm:
Subgroup basic-pci-d3-state:
pass -> DMESG-WARN (snb-dellxps)
Subgroup basic-rte:
dmesg-warn -> PASS (snb-x220t)
bdw-ultra total:193 pass:172 dwarn:0 dfail:0 fail:0 skip:21
byt-nuc total:193 pass:158 dwarn:0 dfail:0 fail:0 skip:35
hsw-brixbox total:193 pass:170 dwarn:1 dfail:0 fail:0 skip:22
hsw-gt2 total:193 pass:175 dwarn:1 dfail:0 fail:0 skip:17
ilk-hp8440p total:193 pass:130 dwarn:0 dfail:0 fail:0 skip:63
ivb-t430s total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25
skl-i5k-2 total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23
skl-i7k-2 total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23
snb-dellxps total:193 pass:157 dwarn:2 dfail:0 fail:0 skip:34
snb-x220t total:193 pass:158 dwarn:1 dfail:0 fail:1 skip:33
Results at /archive/results/CI_IGT_test/Patchwork_1560/
ab403b26610034afe0e0c97d960782bad98b97d0 drm-intel-nightly: 2016y-03m-09d-09h-25m-31s UTC integration manifest
293bb2977379e963063d31e72d1ccb852932f4fa drm: fix blob pointer check
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-10 14:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-10 12:04 [PATCH] drm: fix blob pointer check Lionel Landwerlin
2016-03-10 12:10 ` [Intel-gfx] " Daniel Stone
2016-03-10 12:48 ` Daniel Vetter
2016-03-10 14:49 ` ✗ Fi.CI.BAT: failure for drm: fix blob pointer check (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2016-03-10 11:15 [PATCH] drm: fix blob pointer check Lionel Landwerlin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).