From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Deepak M <m.deepak@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 5/6] drm/i915/dsi: use the BIT macro for clarity
Date: Fri, 18 Mar 2016 17:38:58 +0200 [thread overview]
Message-ID: <20160318153858.GL4329@intel.com> (raw)
In-Reply-To: <9115c0a80ad57075700e006db965dd31cc4358fc.1458313400.git.jani.nikula@intel.com>
On Fri, Mar 18, 2016 at 05:05:43PM +0200, Jani Nikula wrote:
> No functional changes.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 1981212ffc8d..dd6f7bc4f444 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -412,7 +412,7 @@ static void intel_dsi_port_enable(struct intel_encoder *encoder)
> temp &= ~LANE_CONFIGURATION_MASK;
> temp &= ~DUAL_LINK_MODE_MASK;
>
> - if (intel_dsi->ports == ((1 << PORT_A) | (1 << PORT_C))) {
> + if (intel_dsi->ports == (BIT(PORT_A) | BIT(PORT_C))) {
> temp |= (intel_dsi->dual_link - 1)
> << DUAL_LINK_MODE_SHIFT;
> temp |= intel_crtc->pipe ?
> @@ -1200,14 +1200,14 @@ void intel_dsi_init(struct drm_device *dev)
>
> /* Pipe A maps to MIPI DSI port A, pipe B maps to MIPI DSI port C */
> if (port == PORT_A)
> - intel_encoder->crtc_mask = 1 << PIPE_A;
> + intel_encoder->crtc_mask = BIT(PIPE_A);
> else
> - intel_encoder->crtc_mask = 1 << PIPE_B;
> + intel_encoder->crtc_mask = BIT(PIPE_B);
>
> if (dev_priv->vbt.dsi.config->dual_link)
> - intel_dsi->ports = (1 << PORT_A) | (1 << PORT_C);
> + intel_dsi->ports = BIT(PORT_A) | BIT(PORT_C);
> else
> - intel_dsi->ports = 1 << port;
> + intel_dsi->ports = BIT(port);
>
> /* Create a DSI host (and a device) for each port. */
> for_each_dsi_port(port, intel_dsi->ports) {
> --
> 2.1.4
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-18 15:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 15:05 [PATCH v2 0/6] drm/i915/bxt: add dsi transcoders Jani Nikula
2016-03-18 15:05 ` [PATCH v2 1/6] drm/i915: split get/set pipe timings to timings and src size Jani Nikula
2016-03-18 15:25 ` Ville Syrjälä
2016-03-18 15:05 ` [PATCH v2 2/6] drm/i915: split set pipeconf to pipeconf, pipemisc, pipe_gamma Jani Nikula
2016-03-18 15:29 ` Ville Syrjälä
2016-03-18 15:05 ` [PATCH v2 3/6] drm/i915: abstract get config for cpu transcoder Jani Nikula
2016-03-18 15:31 ` Ville Syrjälä
2016-03-18 15:05 ` [PATCH v2 4/6] drm/i915/bxt: add dsi transcoders Jani Nikula
2016-03-18 15:38 ` Ville Syrjälä
2016-03-18 15:05 ` [PATCH v2 5/6] drm/i915/dsi: use the BIT macro for clarity Jani Nikula
2016-03-18 15:38 ` Ville Syrjälä [this message]
2016-03-18 15:05 ` [PATCH v2 6/6] drm/i915/bxt: allow dsi on any pipe Jani Nikula
2016-03-18 15:39 ` Ville Syrjälä
2016-03-21 9:59 ` ✗ Fi.CI.BAT: failure for drm/i915/bxt: add dsi transcoders (rev2) Patchwork
2016-03-21 13:04 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318153858.GL4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=m.deepak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox