From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Stop setting SNB min-freq-table 0 on powersave setup
Date: Sat, 22 Oct 2016 00:58:09 +0300 [thread overview]
Message-ID: <20161021215809.GA4617@intel.com> (raw)
In-Reply-To: <20161021205531.8651-1-chris@chris-wilson.co.uk>
On Fri, Oct 21, 2016 at 09:55:31PM +0100, Chris Wilson wrote:
> The min-freq-table is an array of values that match each CPU frequency to
> an equivalent GPU frequency. Setting a single value of 0 on init is both
> illegal (generates an error from the PCU) and nonsensical. Let's see if
> we survive without that error.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Yeah never made any sense. If we really wanted to reset the table, we'd
have to set every valid entry to 0.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index b65208e23a08..ba3d1e97986a 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5589,10 +5589,6 @@ static void gen6_enable_rps(struct drm_i915_private *dev_priv)
> I915_WRITE(GEN6_RP_DOWN_TIMEOUT, 50000);
> I915_WRITE(GEN6_RP_IDLE_HYSTERSIS, 10);
>
> - ret = sandybridge_pcode_write(dev_priv, GEN6_PCODE_WRITE_MIN_FREQ_TABLE, 0);
> - if (ret)
> - DRM_DEBUG_DRIVER("Failed to set the min frequency\n");
> -
> reset_rps(dev_priv, gen6_set_rps);
>
> rc6vids = 0;
> --
> 2.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-21 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 20:55 [PATCH] drm/i915: Stop setting SNB min-freq-table 0 on powersave setup Chris Wilson
2016-10-21 21:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-10-21 21:58 ` Ville Syrjälä [this message]
2016-10-22 8:39 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021215809.GA4617@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox