* [PATCH] drm/i915: remove 512GB allocation warning
@ 2017-02-02 14:55 Matthew Auld
2017-02-02 15:14 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Matthew Auld @ 2017-02-02 14:55 UTC (permalink / raw)
To: intel-gfx
Now that we have selftests in place exercising truly huge allocations
we will start to hit the 512GB warning, so now seems like a good time to
remove it.
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 048040efc3f0..c567b34800cf 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -1423,10 +1423,6 @@ static int gen8_alloc_va_range_4lvl(struct i915_address_space *vm,
if (ret)
return ret;
- WARN(bitmap_weight(new_pdps, GEN8_PML4ES_PER_PML4) > 2,
- "The allocation has spanned more than 512GB. "
- "It is highly likely this is incorrect.");
-
gen8_for_each_pml4e(pdp, pml4, start, length, pml4e) {
WARN_ON(!pdp);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: remove 512GB allocation warning
2017-02-02 14:55 [PATCH] drm/i915: remove 512GB allocation warning Matthew Auld
@ 2017-02-02 15:14 ` Chris Wilson
2017-02-02 17:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-03 9:03 ` [PATCH] " Joonas Lahtinen
2 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-02-02 15:14 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
On Thu, Feb 02, 2017 at 02:55:00PM +0000, Matthew Auld wrote:
> Now that we have selftests in place exercising truly huge allocations
> we will start to hit the 512GB warning, so now seems like a good time to
> remove it.
Hey! I wrote userspace tests to hit this WARN() a couple of years ago ;)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: remove 512GB allocation warning
2017-02-02 14:55 [PATCH] drm/i915: remove 512GB allocation warning Matthew Auld
2017-02-02 15:14 ` Chris Wilson
@ 2017-02-02 17:24 ` Patchwork
2017-02-03 9:03 ` [PATCH] " Joonas Lahtinen
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-02-02 17:24 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: remove 512GB allocation warning
URL : https://patchwork.freedesktop.org/series/18995/
State : success
== Summary ==
Series 18995v1 drm/i915: remove 512GB allocation warning
https://patchwork.freedesktop.org/api/1.0/series/18995/revisions/1/mbox/
fi-bdw-5557u total:247 pass:233 dwarn:0 dfail:0 fail:0 skip:14
fi-bsw-n3050 total:247 pass:208 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:247 pass:225 dwarn:0 dfail:0 fail:0 skip:22
fi-bxt-t5700 total:78 pass:65 dwarn:0 dfail:0 fail:0 skip:12
fi-byt-j1900 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19
fi-hsw-4770r total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19
fi-ivb-3520m total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
fi-ivb-3770 total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
fi-kbl-7500u total:247 pass:224 dwarn:0 dfail:0 fail:2 skip:21
fi-skl-6260u total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700hq total:247 pass:227 dwarn:0 dfail:0 fail:0 skip:20
fi-skl-6700k total:247 pass:222 dwarn:4 dfail:0 fail:0 skip:21
fi-skl-6770hq total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
fi-snb-2520m total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
fi-snb-2600 total:247 pass:215 dwarn:0 dfail:0 fail:0 skip:32
11190c4421e0076a9f37205b0d53b2b3f2733711 drm-tip: 2017y-02m-02d-15h-01m-15s UTC integration manifest
e894021 drm/i915: remove 512GB allocation warning
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3679/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove 512GB allocation warning
2017-02-02 14:55 [PATCH] drm/i915: remove 512GB allocation warning Matthew Auld
2017-02-02 15:14 ` Chris Wilson
2017-02-02 17:24 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-02-03 9:03 ` Joonas Lahtinen
2017-02-03 10:31 ` Chris Wilson
2 siblings, 1 reply; 5+ messages in thread
From: Joonas Lahtinen @ 2017-02-03 9:03 UTC (permalink / raw)
To: Matthew Auld, intel-gfx
On to, 2017-02-02 at 14:55 +0000, Matthew Auld wrote:
> Now that we have selftests in place exercising truly huge allocations
> we will start to hit the 512GB warning, so now seems like a good time to
> remove it.
>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Chris, could you merge this?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove 512GB allocation warning
2017-02-03 9:03 ` [PATCH] " Joonas Lahtinen
@ 2017-02-03 10:31 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-02-03 10:31 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx, Matthew Auld
On Fri, Feb 03, 2017 at 11:03:15AM +0200, Joonas Lahtinen wrote:
> On to, 2017-02-02 at 14:55 +0000, Matthew Auld wrote:
> > Now that we have selftests in place exercising truly huge allocations
> > we will start to hit the 512GB warning, so now seems like a good time to
> > remove it.
> >
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Chris, could you merge this?
Done.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-03 10:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-02 14:55 [PATCH] drm/i915: remove 512GB allocation warning Matthew Auld
2017-02-02 15:14 ` Chris Wilson
2017-02-02 17:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-03 9:03 ` [PATCH] " Joonas Lahtinen
2017-02-03 10:31 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox