From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/1] drm/i915: Do RPM Wake during GuC/HuC status read
Date: Tue, 7 Feb 2017 14:20:14 +0100 [thread overview]
Message-ID: <20170207132014.GA8914@ahiler-desk.igk.intel.com> (raw)
In-Reply-To: <c6dab917-a328-e8d0-70cc-2e5cdafc3beb@intel.com>
On Mon, Feb 06, 2017 at 10:34:31AM +0530, Kamble, Sagar A wrote:
>
>
> On 2/4/2017 7:40 PM, Arkadiusz Hiler wrote:
> > On Fri, Feb 03, 2017 at 01:58:33PM +0530, Sagar Arun Kamble wrote:
> > > HUC_STATUS, GUC_STATUS, SOFT_SCRATCH registers are read in debugfs
> > > and getparam ioctl. This patch covers those accesses by RPM get/put.
> > >
> > > v2: Covering access in i915_getparam(I915_PARAM_HUC_STATUS) (ChrisW)
> > >
> > > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > Cc: Fiedorowicz, Lukasz <lukasz.fiedorowicz@intel.com>
> > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/i915_debugfs.c | 6 ++++++
> > > drivers/gpu/drm/i915/i915_drv.c | 5 ++---
> > > 2 files changed, 8 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > > index 3ae0656..639ed12 100644
> > > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > > @@ -2374,7 +2374,9 @@ static int i915_huc_load_status_info(struct seq_file *m, void *data)
> > > seq_printf(m, "\tRSA: offset is %d; size = %d\n",
> > > huc_fw->rsa_offset, huc_fw->rsa_size);
> > > + intel_runtime_pm_get(dev_priv);
> > > seq_printf(m, "\nHuC status 0x%08x:\n", I915_READ(HUC_STATUS2));
> > > + intel_runtime_pm_put(dev_priv);
> > > return 0;
> > > }
> > Are you sure that HUC_STATUS2 requires RPM get for reading?
> >
> > I remember trying reading it with device forcefully asleep and it
> > succeed just fine.
> Hi Arek,
>
> Faced following warning with device runtime_status=suspended.
> Also this register lies in media forcewake range and should have similar RPM
> get/put needs as other registers unless this has special behavior I am not
> aware of.
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
--
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-02-07 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 8:28 [PATCH v2 1/1] drm/i915: Do RPM Wake during GuC/HuC status read Sagar Arun Kamble
2017-02-03 8:54 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork
2017-02-16 10:07 ` Tvrtko Ursulin
2017-02-04 14:10 ` [PATCH v2 1/1] " Arkadiusz Hiler
2017-02-06 5:04 ` Kamble, Sagar A
2017-02-07 13:20 ` Arkadiusz Hiler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207132014.GA8914@ahiler-desk.igk.intel.com \
--to=arkadiusz.hiler@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox