public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Daniel Vetter" <daniel.vetter@intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: [PATCH resend 14/15] drm/i915/dsi: Call MIPI_SEQ_TEAR_ON and DISPLAY_ON for cmd-mode (untested)
Date: Mon, 20 Feb 2017 15:08:44 +0100	[thread overview]
Message-ID: <20170220140845.1714-15-hdegoede@redhat.com> (raw)
In-Reply-To: <20170220140845.1714-1-hdegoede@redhat.com>

According to the spec we should call MIPI_SEQ_TEAR_ON and DISPLAY_ON
on enable for cmd-mode, just like we already call their counterparts
on disable. Note: untested, my panel is a vid-mode panel.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/gpu/drm/i915/intel_dsi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 90263d6..a001e43 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -680,6 +680,8 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder,
 	if (is_cmd_mode(intel_dsi)) {
 		for_each_dsi_port(port, intel_dsi->ports)
 			I915_WRITE(MIPI_MAX_RETURN_PKT_SIZE(port), 8 * 4);
+		intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_TEAR_ON);
+		intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_DISPLAY_ON);
 	} else {
 		msleep(20); /* XXX */
 		for_each_dsi_port(port, intel_dsi->ports)
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-02-20 14:09 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 14:08 [PATCH resend 00/15] drm/i915/dsi: Fix / cleanup dsi enable / disable sequences Hans de Goede
2017-02-20 14:08 ` [PATCH resend 01/15] drm/i915/dsi: Move calling of wait_for_dsi_fifo_empty to mipi_exec_send_packet Hans de Goede
2017-02-24 16:59   ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 02/15] drm/i915/dsi: Merge intel_dsi_disable/enable into their respective callers Hans de Goede
2017-02-24 16:59   ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 03/15] drm/i915/dsi: Add intel_dsi_unprepare() helper Hans de Goede
2017-02-24 16:59   ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 04/15] drm/i915/dsi: Move intel_dsi_clear_device_ready() Hans de Goede
2017-02-24 17:00   ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 05/15] drm/i915/dsi: Document the panel enable / disable sequences from the spec Hans de Goede
2017-02-24 17:00   ` Bob Paauwe
2017-02-25 10:31     ` Hans de Goede
2017-02-28  9:38       ` Hans de Goede
2017-02-20 14:08 ` [PATCH resend 06/15] drm/i915/dsi: Make intel_dsi_enable/disable directly exec VBT sequences Hans de Goede
2017-02-24 17:00   ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 07/15] drm/i915/dsi: Drop bogus MIPI_SEQ_ASSERT_RESET before POWER_ON Hans de Goede
2017-02-24 17:00   ` Bob Paauwe
2017-02-25 10:35     ` Hans de Goede
2017-02-27 16:56       ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 08/15] drm/i915/dsi: Move MIPI_SEQ_POWER_ON/OFF calls together with pmic gpio calls Hans de Goede
2017-02-24 17:00   ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 09/15] drm/i915/dsi: Group DPOunit clock gate workaround with PLL enable Hans de Goede
2017-02-24 17:00   ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 10/15] drm/i915/dsi: Execute MIPI_SEQ_DEASSERT_RESET before calling device_ready() Hans de Goede
2017-02-24 17:00   ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 11/15] drm/i915/dsi: Group MIPI_SEQ_BACKLIGHT_ON/OFF with panel_[en|dis]able_backlight Hans de Goede
2017-02-24 17:00   ` Bob Paauwe
2017-02-25 10:37     ` Hans de Goede
2017-02-27 17:06       ` Bob Paauwe
2017-02-27 17:40         ` Jani Nikula
2017-02-27 22:04         ` Hans de Goede
2017-02-20 14:08 ` [PATCH resend 12/15] drm/i915/dsi: Document always using v3 SHUTDOWN / MIPI_SEQ_DISPLAY_OFF order Hans de Goede
2017-02-24 17:02   ` Bob Paauwe
2017-02-25 10:42     ` Hans de Goede
2017-02-27 17:16       ` Bob Paauwe
2017-02-27 17:44         ` Jani Nikula
2017-02-28  9:00         ` Hans de Goede
2017-02-20 14:08 ` [PATCH resend 13/15] drm/i915/dsi: Execute MIPI_SEQ_TEAR_OFF from intel_dsi_post_disable Hans de Goede
2017-02-24 17:02   ` Bob Paauwe
2017-02-25 10:45     ` Hans de Goede
2017-02-27 17:47       ` Jani Nikula
2017-02-20 14:08 ` Hans de Goede [this message]
2017-02-24 17:02   ` [PATCH resend 14/15] drm/i915/dsi: Call MIPI_SEQ_TEAR_ON and DISPLAY_ON for cmd-mode (untested) Bob Paauwe
2017-02-25 10:47     ` Hans de Goede
2017-02-27 17:21       ` Bob Paauwe
2017-02-20 14:08 ` [PATCH resend 15/15] drm/i915/dsi: Skip delays for v3 VBTs in vid-mode Hans de Goede
2017-02-24 17:02   ` Bob Paauwe
2017-02-25 10:49     ` Hans de Goede
2017-02-27 17:23       ` Bob Paauwe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170220140845.1714-15-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox