public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Du, Changbin" <changbin.du@intel.com>
To: changbin.du@intel.com
Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [RFC PATCH] drm/i915: make context status notifier head be per engine
Date: Thu, 9 Mar 2017 16:44:14 +0800	[thread overview]
Message-ID: <20170309084414.GA4316@intel.com> (raw)
In-Reply-To: <20170302112305.9628-1-changbin.du@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1745 bytes --]

hi, is there any comments for this? I'd like hear chris and daniel's
comments. :)

Thanks,
Changbin

On Thu, Mar 02, 2017 at 07:23:05PM +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
> 
> hi, Daniel, Chris and All,
> As you know, GVTg introduced the context status notifier to schedule
> the GVTg workload. At that time, the notifier is bound to GVTg context
> only, so GVTg is not aware of host workloads.
> 
> Now we are going to improve GVTg's guest workload scheduler policy,
> and add Guc emulation support for new Gen graphics. Both these two
> features require acknowledgment for all contexts running on hardware.
> (But will not alter host workload.) So here try to make some change.
> 
> The change is easy:
>   1. Move the context status notifier head from i915_gem_context to
>      intel_engine_cs. Which means there is a notifier head per engine
>      instead of per context. Execlist driver still call notifier for
>      each context sched-in/out events of current engine.
>   2. At GVTg side, it binds a notifier_block for each physical engine
>      at GVTg initialization period. Then GVTg can hear all context
>      status events.
> 
> In this RFC patch, GVTg do nothing for host context event, but later
> will add a function there. But in any case, the notifier callback is
> a noop if this is no active vGPU.
> 
> Since intel_gvt_init() is called at early initialization stage and
> require the status notifier head has been initiated, I initiate it in
> intel_engine_setup(). I am not sure if this is the right place, please
> correct me if wrong. Thank you! Look forward to your feedback. :)
> 
> Signed-off-by: Changbin Du <changbin.du@intel.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-03-09  8:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 11:23 [RFC PATCH] drm/i915: make context status notifier head be per engine changbin.du
2017-03-02 11:47 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-03-09  8:44 ` Du, Changbin [this message]
2017-03-09 11:27 ` [PATCH] " changbin.du
2017-03-10 17:17   ` Chris Wilson
2017-03-13  2:14     ` Du, Changbin
2017-03-13  2:47   ` [PATCH v2] " changbin.du
2017-03-13  4:03     ` Zhenyu Wang
2017-03-16 16:28       ` Chris Wilson
2017-03-17  2:28         ` Du, Changbin
2017-03-09 15:22 ` ✓ Fi.CI.BAT: success for drm/i915: make context status notifier head be per engine (rev2) Patchwork
2017-03-13  4:25 ` ✗ Fi.CI.BAT: failure for drm/i915: make context status notifier head be per engine (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170309084414.GA4316@intel.com \
    --to=changbin.du@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox