From: Thierry Reding <thierry.reding@gmail.com>
To: Shashank Sharma <shashank.sharma@intel.com>
Cc: Jose Abreu <jose.abreu@synopsys.com>,
ander.conselvan.de.oliveira@intel.com,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v3 01/14] drm: add HDMI 2.0 VIC support for AVI info-frames
Date: Wed, 14 Jun 2017 22:20:32 +0200 [thread overview]
Message-ID: <20170614202032.GA8856@ulmo> (raw)
In-Reply-To: <1497462465-14066-2-git-send-email-shashank.sharma@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1132 bytes --]
On Wed, Jun 14, 2017 at 11:17:32PM +0530, Shashank Sharma wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 2e55599..d312fe1 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4334,12 +4334,14 @@ EXPORT_SYMBOL(drm_set_preferred_mode);
> * data from a DRM display mode
> * @frame: HDMI AVI infoframe
> * @mode: DRM display mode
> + * @is_hdmi2_sink: Sink is HDMI 2.0 compliant
> *
> * Return: 0 on success or a negative error code on failure.
> */
> int
> drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame,
> - const struct drm_display_mode *mode)
> + const struct drm_display_mode *mode,
> + bool is_hdmi2_sink)
Perhaps instead of passing a boolean flag here we could pass a const
struct drm_hdmi_info *. That way the checks could be made more explicit
and it becomes more obvious what to pass into the function. Also, as it
is every driver will have to derive is_hdmi2_sink by itself, and they're
likely to have to do the same thing as i915 anyway.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-06-14 20:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 17:47 [PATCH v3 00/14] HDMI YCBCR output handling in DRM layer Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 01/14] drm: add HDMI 2.0 VIC support for AVI info-frames Shashank Sharma
2017-06-14 20:20 ` Thierry Reding [this message]
2017-06-15 4:11 ` Sharma, Shashank
2017-06-14 17:47 ` [PATCH v3 02/14] drm/edid: Complete CEA modedb(VIC 1-107) Shashank Sharma
2017-06-15 13:29 ` Ville Syrjälä
2017-06-15 13:31 ` Sharma, Shashank
2017-06-15 14:51 ` Ville Syrjälä
2017-06-14 17:47 ` [PATCH v3 03/14] drm: add hdmi 2.0 source identifier Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 04/14] drm/edid: parse YCBCR 420 videomodes from EDID Shashank Sharma
2017-06-15 14:43 ` Ville Syrjälä
2017-06-15 15:35 ` Sharma, Shashank
2017-06-15 16:12 ` Ville Syrjälä
2017-06-15 16:48 ` Sharma, Shashank
2017-06-15 16:59 ` Ville Syrjälä
2017-06-15 17:02 ` Sharma, Shashank
2017-06-16 18:55 ` kbuild test robot
2017-06-14 17:47 ` [PATCH v3 05/14] drm: parse ycbcr 420 deep color information Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 06/14] drm: create hdmi output property Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 07/14] drm: set output colorspace in AVI infoframe Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 08/14] drm: add helper functions for YCBCR output handling Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 09/14] drm/i915: add compute_config for YCBCR outputs Shashank Sharma
2017-06-16 21:15 ` kbuild test robot
2017-06-14 17:47 ` [PATCH v3 10/14] drm/i915: prepare scaler for YCBCR420 modeset Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 11/14] drm/i915: prepare pipe for YCBCR output Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 12/14] drm/i915: prepare csc unit for YCBCR HDMI output Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 13/14] drm/i915: set colorspace for ycbcr outputs Shashank Sharma
2017-06-14 17:47 ` [PATCH v3 14/14] drm/i915/glk: set HDMI 2.0 identifier Shashank Sharma
2017-06-14 17:52 ` ✗ Fi.CI.BAT: failure for HDMI YCBCR output handling in DRM layer (rev3) Patchwork
2017-06-14 17:53 ` Sharma, Shashank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614202032.GA8856@ulmo \
--to=thierry.reding@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.abreu@synopsys.com \
--cc=shashank.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox