From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: gustavo.padovan@collabora.co.uk
Subject: [PATCH i-g-t 3/5] tests/kms_atomic_transition: Only request fence on enabled pipes
Date: Thu, 6 Jul 2017 09:11:45 +0200 [thread overview]
Message-ID: <20170706071147.15414-4-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20170706071147.15414-1-maarten.lankhorst@linux.intel.com>
Trying to set a fence on disabled pipes will be rejected by the kernel:
[ 1275.865029] [drm:drm_atomic_check_only [drm]] [CRTC:39:pipe B] requesting event but off
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99911
---
tests/kms_atomic_transition.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 2b56eef66b7b..a2470c0c3571 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -717,11 +717,11 @@ static void run_modeset_tests(igt_display_t *display, int howmany, bool nonblock
igt_plane_set_fb(plane, &fbs[1]);
igt_fb_set_size(&fbs[1], plane, mode->hdisplay, mode->vdisplay);
igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+
+ if (fencing)
+ igt_pipe_request_out_fence(&display->pipes[i]);
} else
igt_plane_set_fb(plane, NULL);
-
- if(fencing)
- igt_pipe_request_out_fence(&display->pipes[i]);
}
/*
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-06 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 7:11 [PATCH i-g-t 0/5] igt/kms: Make fence waiting explicit Maarten Lankhorst
2017-07-06 7:11 ` [PATCH i-g-t 1/5] tests/kms_atomic_transition: Add test for plane completion ordering Maarten Lankhorst
2017-07-06 7:11 ` [PATCH i-g-t 2/5] lib/kms: Handle fence interaction correctly WRT TEST_ONLY Maarten Lankhorst
2017-07-06 7:11 ` Maarten Lankhorst [this message]
2017-07-06 7:11 ` [PATCH i-g-t 4/5] tests/kms_atomic_transition: Do not clear in-fences after atomic commit Maarten Lankhorst
2017-07-06 7:11 ` [PATCH i-g-t 5/5] igt/kms: Do not wait for fence completion during commit Maarten Lankhorst
2017-07-07 0:15 ` [PATCH i-g-t 0/5] igt/kms: Make fence waiting explicit Gustavo Padovan
2017-07-10 7:06 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706071147.15414-4-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox