From: David Weinehall <david.weinehall@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Speed up DMC firmware loading
Date: Mon, 4 Sep 2017 22:09:10 +0300 [thread overview]
Message-ID: <20170904190909.6chy2mmdp6gecxc4@boom> (raw)
In-Reply-To: <150455135640.23157.3588702654803164181@mail.alporthouse.com>
On Mon, Sep 04, 2017 at 07:55:56PM +0100, Chris Wilson wrote:
> Quoting David Weinehall (2017-09-04 19:38:04)
> > v2: Per feedback from Chris & Ville there's no need to do the whole
> > forcewake dance, so lose that bit (Chris, Ville)
>
> > @@ -251,9 +253,20 @@ void intel_csr_load_program(struct drm_i915_private *dev_priv)
> > return;
> > }
> >
> > + fw_domains = intel_uncore_forcewake_for_reg(dev_priv,
> > + CSR_PROGRAM(0),
> > + FW_REG_WRITE);
> > +
> > fw_size = dev_priv->csr.dmc_fw_size;
> > + assert_rpm_wakelock_held(dev_priv);
> > + spin_lock_irqsave(&dev_priv->uncore.lock, flags);
> > + intel_uncore_forcewake_get__locked(dev_priv, fw_domains);
>
> Still there!
Yeah, I missed the git add... Whooopsie; check v3.
Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-04 19:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 18:38 [PATCH v2] drm/i915: Speed up DMC firmware loading David Weinehall
2017-09-04 18:55 ` Chris Wilson
2017-09-04 19:09 ` David Weinehall [this message]
2017-09-04 18:57 ` ✓ Fi.CI.BAT: success for drm/i915: Speed up DMC firmware loading (rev2) Patchwork
2017-09-04 19:08 ` [PATCH v3] drm/i915: Speed up DMC firmware loading David Weinehall
2017-09-04 19:14 ` Chris Wilson
2017-09-04 19:15 ` Chris Wilson
2017-09-04 19:25 ` David Weinehall
2017-09-04 19:46 ` ✓ Fi.CI.BAT: success for drm/i915: Speed up DMC firmware loading (rev3) Patchwork
2017-09-04 19:59 ` ✗ Fi.CI.IGT: warning for drm/i915: Speed up DMC firmware loading (rev2) Patchwork
2017-09-04 21:32 ` ✗ Fi.CI.IGT: warning for drm/i915: Speed up DMC firmware loading (rev3) Patchwork
2017-09-05 13:10 ` [PATCH v4] drm/i915: Speed up DMC firmware loading David Weinehall
2017-09-05 13:25 ` Chris Wilson
2017-09-05 13:33 ` David Weinehall
2017-09-05 14:09 ` Chris Wilson
2017-09-05 13:38 ` ✓ Fi.CI.BAT: success for drm/i915: Speed up DMC firmware loading (rev4) Patchwork
2017-09-05 15:10 ` ✓ Fi.CI.IGT: " Patchwork
2017-09-25 13:49 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904190909.6chy2mmdp6gecxc4@boom \
--to=david.weinehall@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox