* [PATCH v3] drm: drm_vblank_cleanup: WARN when refcount > 0
@ 2017-10-25 16:24 PrasannaKumar Muralidharan
2017-10-25 17:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-26 2:43 ` [PATCH v3] " PrasannaKumar Muralidharan
0 siblings, 2 replies; 3+ messages in thread
From: PrasannaKumar Muralidharan @ 2017-10-25 16:24 UTC (permalink / raw)
To: daniel.vetter, jani.nikula, seanpaul, airlied, dri-devel,
ville.syrjala, intel-gfx
Cc: PrasannaKumar Muralidharan
Warn when refcount > 0 in drm_vblank_cleanup.
Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
---
Changes in v3:
* Dropped i915 patch that is used for testing this.
No changes in v2.
drivers/gpu/drm/drm_vblank.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 70f2b95..3e61aeb 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -405,6 +405,8 @@ void drm_vblank_cleanup(struct drm_device *dev)
for (pipe = 0; pipe < dev->num_crtcs; pipe++) {
struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
+ WARN_ON(atomic_read(&vblank->refcount) > 0);
+
WARN_ON(READ_ONCE(vblank->enabled) &&
drm_core_check_feature(dev, DRIVER_MODESET));
--
2.10.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* ✗ Fi.CI.BAT: failure for drm: drm_vblank_cleanup: WARN when refcount > 0
2017-10-25 16:24 [PATCH v3] drm: drm_vblank_cleanup: WARN when refcount > 0 PrasannaKumar Muralidharan
@ 2017-10-25 17:24 ` Patchwork
2017-10-26 2:43 ` [PATCH v3] " PrasannaKumar Muralidharan
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-10-25 17:24 UTC (permalink / raw)
To: PrasannaKumar Muralidharan; +Cc: intel-gfx
== Series Details ==
Series: drm: drm_vblank_cleanup: WARN when refcount > 0
URL : https://patchwork.freedesktop.org/series/32648/
State : failure
== Summary ==
Series 32648v1 drm: drm_vblank_cleanup: WARN when refcount > 0
https://patchwork.freedesktop.org/api/1.0/series/32648/revisions/1/mbox/
Test kms_busy:
Subgroup basic-flip-c:
incomplete -> PASS (fi-bxt-j4205)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
incomplete -> PASS (fi-cnl-y)
Subgroup suspend-read-crc-pipe-a:
pass -> FAIL (fi-skl-6700k)
Test drv_module_reload:
Subgroup basic-reload:
pass -> DMESG-WARN (fi-blb-e6850)
pass -> DMESG-WARN (fi-pnv-d510)
pass -> DMESG-WARN (fi-bwr-2160)
pass -> DMESG-WARN (fi-elk-e7500)
pass -> DMESG-WARN (fi-ilk-650)
pass -> DMESG-WARN (fi-snb-2520m)
pass -> DMESG-WARN (fi-snb-2600)
pass -> DMESG-WARN (fi-ivb-3520m)
pass -> DMESG-WARN (fi-ivb-3770)
pass -> DMESG-WARN (fi-byt-j1900)
pass -> DMESG-WARN (fi-byt-n2820)
pass -> DMESG-WARN (fi-hsw-4770)
pass -> DMESG-WARN (fi-hsw-4770r)
pass -> DMESG-WARN (fi-bdw-5557u)
pass -> DMESG-WARN (fi-bsw-n3050) fdo#103165 +1
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6600u)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-gvtdvm)
pass -> DMESG-WARN (fi-bxt-dsi)
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-kbl-7560u)
pass -> DMESG-WARN (fi-kbl-r)
pass -> DMESG-WARN (fi-glk-1)
pass -> DMESG-WARN (fi-glk-dsi)
Subgroup basic-no-display:
pass -> DMESG-WARN (fi-gdg-551) fdo#102707 +1
pass -> DMESG-WARN (fi-blb-e6850)
pass -> DMESG-WARN (fi-pnv-d510)
pass -> DMESG-WARN (fi-bwr-2160)
pass -> DMESG-WARN (fi-elk-e7500)
pass -> DMESG-WARN (fi-ilk-650)
pass -> DMESG-WARN (fi-snb-2520m)
pass -> DMESG-WARN (fi-snb-2600)
pass -> DMESG-WARN (fi-ivb-3520m)
pass -> DMESG-WARN (fi-ivb-3770)
pass -> DMESG-WARN (fi-byt-j1900)
pass -> DMESG-WARN (fi-byt-n2820)
pass -> DMESG-WARN (fi-hsw-4770)
pass -> DMESG-WARN (fi-hsw-4770r)
pass -> DMESG-WARN (fi-bdw-5557u)
pass -> DMESG-WARN (fi-bsw-n3050)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6600u)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-gvtdvm)
pass -> DMESG-WARN (fi-bxt-dsi)
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-kbl-7560u)
pass -> DMESG-WARN (fi-kbl-7567u)
pass -> DMESG-WARN (fi-kbl-r)
pass -> DMESG-WARN (fi-glk-1)
pass -> DMESG-WARN (fi-glk-dsi)
Subgroup basic-reload-inject:
pass -> DMESG-WARN (fi-blb-e6850)
pass -> DMESG-WARN (fi-pnv-d510)
pass -> DMESG-WARN (fi-bwr-2160)
pass -> DMESG-WARN (fi-elk-e7500)
pass -> DMESG-WARN (fi-ilk-650)
pass -> DMESG-WARN (fi-snb-2520m)
pass -> DMESG-WARN (fi-snb-2600)
pass -> DMESG-WARN (fi-ivb-3520m)
pass -> DMESG-WARN (fi-ivb-3770)
pass -> DMESG-WARN (fi-byt-j1900)
pass -> DMESG-WARN (fi-byt-n2820)
pass -> DMESG-WARN (fi-hsw-4770)
pass -> DMESG-WARN (fi-hsw-4770r)
pass -> DMESG-WARN (fi-bdw-5557u)
pass -> DMESG-WARN (fi-bsw-n3050)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6600u)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-gvtdvm)
pass -> DMESG-WARN (fi-bxt-dsi)
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-kbl-7560u)
pass -> DMESG-WARN (fi-kbl-7567u)
pass -> DMESG-WARN (fi-kbl-r)
pass -> DMESG-WARN (fi-glk-1)
pass -> DMESG-WARN (fi-glk-dsi)
WARNING: Long output truncated
5e39e3539f6330cf7d08cc83d34bc693f0be8920 drm-tip: 2017y-10m-25d-13h-19m-05s UTC integration manifest
ae906dc779f9 drm: drm_vblank_cleanup: WARN when refcount > 0
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6188/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] drm: drm_vblank_cleanup: WARN when refcount > 0
2017-10-25 16:24 [PATCH v3] drm: drm_vblank_cleanup: WARN when refcount > 0 PrasannaKumar Muralidharan
2017-10-25 17:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-10-26 2:43 ` PrasannaKumar Muralidharan
1 sibling, 0 replies; 3+ messages in thread
From: PrasannaKumar Muralidharan @ 2017-10-26 2:43 UTC (permalink / raw)
To: daniel.vetter, jani.nikula, Sean Paul, airlied, dri-devel,
Ville Syrjälä, intel-gfx, Chris Wilson
[-- Attachment #1.1: Type: text/plain, Size: 1435 bytes --]
Hi Chris,
Sorry I missed adding you in to list while sending the vblank refcount
patch. Hope you saw that.
On 25-Oct-2017 9:55 PM, "PrasannaKumar Muralidharan" <
prasannatsmkumar@gmail.com> wrote:
Warn when refcount > 0 in drm_vblank_cleanup.
Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
---
Changes in v3:
* Dropped i915 patch that is used for testing this.
No changes in v2.
drivers/gpu/drm/drm_vblank.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 70f2b95..3e61aeb 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -405,6 +405,8 @@ void drm_vblank_cleanup(struct drm_device *dev)
for (pipe = 0; pipe < dev->num_crtcs; pipe++) {
struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
+ WARN_ON(atomic_read(&vblank->refcount) > 0);
+
WARN_ON(READ_ONCE(vblank->enabled) &&
drm_core_check_feature(dev, DRIVER_MODESET));
--
2.10.0
As you anticipated Intel CI found that this patch triggers the non zero
vblank refcount warning on module unload.
Please advice on what to do next. Should I don't think I have to do
something for this patch. If that's not the case please let me know what to
do from my side for this patch.
Note: Replying from an Android device. Please forgive typos.
Thanks and regards,
PrasannaKumar
[-- Attachment #1.2: Type: text/html, Size: 2451 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-26 2:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-25 16:24 [PATCH v3] drm: drm_vblank_cleanup: WARN when refcount > 0 PrasannaKumar Muralidharan
2017-10-25 17:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-26 2:43 ` [PATCH v3] " PrasannaKumar Muralidharan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox