From: Tvrtko Ursulin <tursulin@ursulin.net>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t v2] intel_gvtg_test: Handle system(3) return value.
Date: Wed, 8 Nov 2017 12:47:43 +0000 [thread overview]
Message-ID: <20171108124743.14035-1-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20171108122203.mgqe7iwhkdvyx5jn@platvala-desk.ger.corp.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Avoid the build warning by checking the pkill either did not find
any guests or managed to send a signal to all of them.
v2: Inspect system(3) return value properly. (Petri Latvala)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gvtg_test.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/intel_gvtg_test.c b/tools/intel_gvtg_test.c
index 7a29fbdde7cd..659b7956725c 100644
--- a/tools/intel_gvtg_test.c
+++ b/tools/intel_gvtg_test.c
@@ -144,7 +144,10 @@ static void create_guest(void)
static void destroy_all_guest(void)
{
- system("pkill qemu");
+ int ret = system("pkill qemu");
+
+ igt_assert(ret >= 0 && WIFEXITED(ret));
+ igt_assert(WEXITSTATUS(ret) == 0 || WEXITSTATUS(ret) == 1);
}
static void remove_vgpu(void)
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-08 12:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 12:06 [PATCH i-g-t 0/5] Assorted compile warnings fixes Tvrtko Ursulin
2017-11-08 12:06 ` [PATCH i-g-t 1/5] intel-gpu-overlay: Avoid theoretical string overflow Tvrtko Ursulin
2017-11-08 12:25 ` Petri Latvala
2017-11-08 12:06 ` [PATCH i-g-t 2/5] aubdump: Avoid mixing declarations and code Tvrtko Ursulin
2017-11-08 12:06 ` [PATCH i-g-t 3/5] lib/core: Avoid unused result in backtrace printing Tvrtko Ursulin
2017-11-22 17:44 ` Tvrtko Ursulin
2017-11-22 17:52 ` Chris Wilson
2017-11-08 12:06 ` [PATCH i-g-t 4/5] gem_syslatency: Avoid arithmetic on void * warning Tvrtko Ursulin
2017-11-08 12:28 ` Petri Latvala
2017-11-09 10:18 ` Tvrtko Ursulin
2017-11-08 12:06 ` [PATCH i-g-t 5/5] intel_gvtg_test: Handle system(3) return value Tvrtko Ursulin
2017-11-08 12:19 ` Chris Wilson
2017-11-08 12:50 ` Tvrtko Ursulin
2017-11-08 12:22 ` Petri Latvala
2017-11-08 12:47 ` Tvrtko Ursulin [this message]
2017-11-08 12:52 ` [PATCH i-g-t v2] " Petri Latvala
2017-11-09 10:16 ` Tvrtko Ursulin
2017-11-08 18:09 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-11-08 20:14 ` ✗ Fi.CI.IGT: " Patchwork
2017-11-08 17:36 ` ✗ Fi.CI.BAT: failure for Assorted compile warnings fixes Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108124743.14035-1-tvrtko.ursulin@linux.intel.com \
--to=tursulin@ursulin.net \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox