public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Petri Latvala <petri.latvala@intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 4/5] gem_syslatency: Avoid arithmetic on void * warning
Date: Thu, 9 Nov 2017 10:18:09 +0000	[thread overview]
Message-ID: <968b62e4-0722-8be0-1c27-1318d61ae9d7@linux.intel.com> (raw)
In-Reply-To: <20171108122855.rxr2d63lcowibcdh@platvala-desk.ger.corp.intel.com>


On 08/11/2017 12:28, Petri Latvala wrote:
> On Wed, Nov 08, 2017 at 12:06:53PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Chris wanted to disable the warning here instead. Either way is fine
> with me so
> 
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Thanks, I did not want to go into discussion of changing the build 
environment for the entire project. Or even just this file, while just 
getting rid build warnings.

Regards,

Tvrtko


> 
> 
>> ---
>>   benchmarks/gem_syslatency.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/benchmarks/gem_syslatency.c b/benchmarks/gem_syslatency.c
>> index e2b1f74a43f4..580edc5f5c72 100644
>> --- a/benchmarks/gem_syslatency.c
>> +++ b/benchmarks/gem_syslatency.c
>> @@ -206,7 +206,7 @@ static void *sys_thp_alloc(void *arg)
>>   		assert(ptr != MAP_FAILED);
>>   		madvise(ptr, sz, MADV_HUGEPAGE);
>>   		for (size_t page = 0; page < sz; page += PAGE_SIZE)
>> -			*(volatile uint32_t *)(ptr + page) = 0;
>> +			*(volatile uint32_t *)((unsigned char *)ptr + page) = 0;
>>   		munmap(ptr, sz);
>>   
>>   		clock_gettime(CLOCK_MONOTONIC, &now);
>> -- 
>> 2.14.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-11-09 10:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 12:06 [PATCH i-g-t 0/5] Assorted compile warnings fixes Tvrtko Ursulin
2017-11-08 12:06 ` [PATCH i-g-t 1/5] intel-gpu-overlay: Avoid theoretical string overflow Tvrtko Ursulin
2017-11-08 12:25   ` Petri Latvala
2017-11-08 12:06 ` [PATCH i-g-t 2/5] aubdump: Avoid mixing declarations and code Tvrtko Ursulin
2017-11-08 12:06 ` [PATCH i-g-t 3/5] lib/core: Avoid unused result in backtrace printing Tvrtko Ursulin
2017-11-22 17:44   ` Tvrtko Ursulin
2017-11-22 17:52     ` Chris Wilson
2017-11-08 12:06 ` [PATCH i-g-t 4/5] gem_syslatency: Avoid arithmetic on void * warning Tvrtko Ursulin
2017-11-08 12:28   ` Petri Latvala
2017-11-09 10:18     ` Tvrtko Ursulin [this message]
2017-11-08 12:06 ` [PATCH i-g-t 5/5] intel_gvtg_test: Handle system(3) return value Tvrtko Ursulin
2017-11-08 12:19   ` Chris Wilson
2017-11-08 12:50     ` Tvrtko Ursulin
2017-11-08 12:22   ` Petri Latvala
2017-11-08 12:47     ` [PATCH i-g-t v2] " Tvrtko Ursulin
2017-11-08 12:52       ` Petri Latvala
2017-11-09 10:16         ` Tvrtko Ursulin
2017-11-08 18:09     ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-11-08 20:14     ` ✗ Fi.CI.IGT: " Patchwork
2017-11-08 17:36 ` ✗ Fi.CI.BAT: failure for Assorted compile warnings fixes Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=968b62e4-0722-8be0-1c27-1318d61ae9d7@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox