public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Don't use GEN6_RC_VIDEO_FREQ on gen10+
@ 2017-11-10 14:29 David Weinehall
  2017-11-10 15:03 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 11+ messages in thread
From: David Weinehall @ 2017-11-10 14:29 UTC (permalink / raw)
  To: intel-gfx; +Cc: rodrigo.vivi

GEN6_RC_VIDEO_FREQ is deprecated for >= gen10;
don't try to program it.

Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 07118c0b69d3..9f0ca3ae28f8 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6568,11 +6568,14 @@ static void gen9_enable_rps(struct drm_i915_private *dev_priv)
 {
 	intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL);
 
-	/* Program defaults and thresholds for RPS*/
-	I915_WRITE(GEN6_RC_VIDEO_FREQ,
-		GEN9_FREQUENCY(dev_priv->gt_pm.rps.rp1_freq));
+	/* Program defaults and thresholds for RPS */
+
+	/* GEN6_RC_VIDEO_FREQ is deprecated for >= gen10 */
+	if (INTEL_GEN(dev_priv) == 9)
+		I915_WRITE(GEN6_RC_VIDEO_FREQ,
+			GEN9_FREQUENCY(dev_priv->gt_pm.rps.rp1_freq));
 
-	/* 1 second timeout*/
+	/* 1 second timeout */
 	I915_WRITE(GEN6_RP_DOWN_TIMEOUT,
 		GT_INTERVAL_FROM_US(dev_priv, 1000000));
 
-- 
2.15.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2017-11-20 22:33 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-10 14:29 [PATCH] drm/i915: Don't use GEN6_RC_VIDEO_FREQ on gen10+ David Weinehall
2017-11-10 15:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-10 17:21 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-10 19:53 ` [PATCH] " Rodrigo Vivi
2017-11-13 14:06   ` David Weinehall
2017-11-13 18:20     ` Rodrigo Vivi
2017-11-17  8:01 ` [PATCH v2] " David Weinehall
2017-11-20 22:33   ` Rodrigo Vivi
2017-11-17  8:26 ` ✓ Fi.CI.BAT: success for drm/i915: Don't use GEN6_RC_VIDEO_FREQ on gen10+ (rev2) Patchwork
2017-11-17  9:11 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-17 18:29 ` ✓ Fi.CI.BAT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox