public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH] drm/i915: Ignore TMDS clock limit for DP++ when EDID override is set
Date: Thu, 14 Dec 2017 10:24:46 +0200	[thread overview]
Message-ID: <20171214082446.5039-1-abdiel.janulgue@linux.intel.com> (raw)

4K modes testing by using dummy EDID data has never been working
properly on boxes with DP++ (dual-mode) adaptors. The reason for
this is that  those modes got pruned during hdmi mode validation.
intel_hdmi_mode_valid returns CLOCK_HIGH  because the pixel clock
reported by the 4k mode is higher than dual port TMDS clock limit.

However 4k injection does work properly on machines that don't have
DP++ adapters because the mode is never validated against the DP++
TMDS clock limit.

Ignore the limits when we're testing using overriden EDIDs.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101649
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index bced7b9..d133353 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1576,7 +1576,7 @@ intel_hdmi_dp_dual_mode_detect(struct drm_connector *connector, bool has_edid)
 		}
 	}
 
-	if (type == DRM_DP_DUAL_MODE_NONE)
+	if (type == DRM_DP_DUAL_MODE_NONE || connector->override_edid)
 		return;
 
 	hdmi->dp_dual_mode.type = type;
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2017-12-14  8:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14  8:24 Abdiel Janulgue [this message]
2017-12-14  8:59 ` ✓ Fi.CI.BAT: success for drm/i915: Ignore TMDS clock limit for DP++ when EDID override is set Patchwork
2017-12-14  9:19 ` [PATCH] " Jani Nikula
2017-12-14 11:16 ` ✓ Fi.CI.IGT: success for " Patchwork
2017-12-15 10:20 ` [PATCH v2] " Abdiel Janulgue
2018-01-19 10:35   ` Jani Nikula
2017-12-15 11:10 ` ✓ Fi.CI.BAT: success for drm/i915: Ignore TMDS clock limit for DP++ when EDID override is set (rev2) Patchwork
2017-12-15 12:52 ` ✓ Fi.CI.IGT: " Patchwork
2018-01-09 11:16 ` ✓ Fi.CI.BAT: " Patchwork
2018-01-09 12:52 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-09 20:45 ` ✓ Fi.CI.BAT: success " Patchwork
2018-01-10  7:43 ` Patchwork
2018-01-11  9:54 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-11 10:01   ` Petri Latvala
2018-01-11 14:48     ` Saarinen, Jani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214082446.5039-1-abdiel.janulgue@linux.intel.com \
    --to=abdiel.janulgue@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox