* [PATCH i-g-t] tests/gem_eio: Fix usage of gem_quiescent_gpu
@ 2017-12-14 22:01 Antonio Argenziano
2017-12-14 22:45 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Antonio Argenziano @ 2017-12-14 22:01 UTC (permalink / raw)
To: intel-gfx
After change "lib: Ask the kernel to quiesce the GPU" was merged,
gem_quiescent_gpu() would not submit noop batches to all engines
therefore the test should submit the workload and use the library
function to wait for the workload to complete.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
---
tests/gem_eio.c | 30 +++++++++++++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/tests/gem_eio.c b/tests/gem_eio.c
index 2ac9f0a9..868f2236 100644
--- a/tests/gem_eio.c
+++ b/tests/gem_eio.c
@@ -60,13 +60,41 @@ static bool i915_reset_control(bool enable)
return ret;
}
+static void noop(int fd, unsigned flags)
+{
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ struct drm_i915_gem_execbuffer2 eb;
+ struct drm_i915_gem_exec_object2 exec;
+
+ memset(&exec, 0, sizeof(exec));
+ exec.handle = gem_create(fd, 4096);
+ igt_assert((int)exec.handle > 0);
+ gem_write(fd, exec.handle, 0, &bbe, sizeof(bbe));
+
+ memset(&eb, 0, sizeof(eb));
+ eb.buffers_ptr = to_user_pointer(&exec);
+ eb.buffer_count = 1;
+ eb.flags = flags;
+
+ gem_execbuf(fd, &eb);
+}
+
+static void noop_all_engines(int fd)
+{
+ unsigned engine;
+ for_each_engine(fd, engine)
+ noop(fd, engine);
+
+ gem_quiescent_gpu(fd);
+}
+
static void trigger_reset(int fd)
{
igt_force_gpu_reset(fd);
/* And just check the gpu is indeed running again */
igt_debug("Checking that the GPU recovered\n");
- gem_quiescent_gpu(fd);
+ noop_all_engines(fd);
}
static void wedge_gpu(int fd)
--
2.14.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH i-g-t] tests/gem_eio: Fix usage of gem_quiescent_gpu
2017-12-14 22:01 [PATCH i-g-t] tests/gem_eio: Fix usage of gem_quiescent_gpu Antonio Argenziano
@ 2017-12-14 22:45 ` Chris Wilson
2017-12-14 23:00 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-15 0:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2017-12-14 22:45 UTC (permalink / raw)
To: Antonio Argenziano, intel-gfx
Quoting Antonio Argenziano (2017-12-14 22:01:31)
> After change "lib: Ask the kernel to quiesce the GPU" was merged,
> gem_quiescent_gpu() would not submit noop batches to all engines
> therefore the test should submit the workload and use the library
> function to wait for the workload to complete.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> ---
> tests/gem_eio.c | 30 +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/tests/gem_eio.c b/tests/gem_eio.c
> index 2ac9f0a9..868f2236 100644
> --- a/tests/gem_eio.c
> +++ b/tests/gem_eio.c
> @@ -60,13 +60,41 @@ static bool i915_reset_control(bool enable)
> return ret;
> }
>
> +static void noop(int fd, unsigned flags)
> +{
> + const uint32_t bbe = MI_BATCH_BUFFER_END;
> + struct drm_i915_gem_execbuffer2 eb;
> + struct drm_i915_gem_exec_object2 exec;
> +
> + memset(&exec, 0, sizeof(exec));
> + exec.handle = gem_create(fd, 4096);
> + igt_assert((int)exec.handle > 0);
gem_create() provides the checks.
exec.handle is u32, with 0 being the only special invalid value. It just
happens that in the linux implementation it is limited internally by the
idr (but that limit may well be removed). Other implementations may use
a psuedo-random handle generator.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for tests/gem_eio: Fix usage of gem_quiescent_gpu
2017-12-14 22:01 [PATCH i-g-t] tests/gem_eio: Fix usage of gem_quiescent_gpu Antonio Argenziano
2017-12-14 22:45 ` Chris Wilson
@ 2017-12-14 23:00 ` Patchwork
2017-12-15 0:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-12-14 23:00 UTC (permalink / raw)
To: Antonio Argenziano; +Cc: intel-gfx
== Series Details ==
Series: tests/gem_eio: Fix usage of gem_quiescent_gpu
URL : https://patchwork.freedesktop.org/series/35382/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
103af7286e2d1014e3d7126691fe046ab2c9f73e lib: Ask the kernel to quiesce the GPU
with latest DRM-Tip kernel build CI_DRM_3521
ad43db157c69 drm-tip: 2017y-12m-14d-20h-09m-53s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989 +1
incomplete -> PASS (fi-snb-2520m) fdo#103713
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test gem_sync:
Subgroup basic-each:
skip -> PASS (fi-blb-e6850)
Subgroup basic-many-each:
skip -> PASS (fi-blb-e6850)
Subgroup basic-store-all:
skip -> PASS (fi-blb-e6850)
Subgroup basic-store-each:
skip -> PASS (fi-blb-e6850)
Test gem_tiled_blits:
Subgroup basic:
skip -> PASS (fi-blb-e6850)
Test gem_tiled_fence_blits:
Subgroup basic:
skip -> PASS (fi-blb-e6850)
Test gem_wait:
Subgroup basic-busy-all:
skip -> PASS (fi-blb-e6850)
Subgroup basic-wait-all:
skip -> PASS (fi-blb-e6850)
Subgroup basic-await-all:
skip -> PASS (fi-blb-e6850)
Test kms_busy:
Subgroup basic-flip-a:
skip -> PASS (fi-blb-e6850)
Subgroup basic-flip-b:
skip -> PASS (fi-blb-e6850)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
skip -> PASS (fi-blb-e6850)
Test kms_psr_sink_crc:
Subgroup psr_basic:
dmesg-warn -> PASS (fi-skl-6700hq) fdo#101144
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:440s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:438s
fi-blb-e6850 total:288 pass:222 dwarn:1 dfail:1 fail:0 skip:64 time:395s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:502s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:278s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:497s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:503s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:487s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:478s
fi-elk-e7500 total:224 pass:163 dwarn:15 dfail:0 fail:0 skip:45
fi-gdg-551 total:288 pass:179 dwarn:1 dfail:0 fail:0 skip:108 time:263s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:535s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:410s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:416s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:396s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:467s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:427s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:481s
fi-kbl-7560u total:288 pass:268 dwarn:1 dfail:0 fail:0 skip:19 time:522s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:470s
fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:529s
fi-pnv-d510 total:288 pass:221 dwarn:1 dfail:0 fail:1 skip:65 time:597s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:449s
fi-skl-6600u total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:535s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:559s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:494s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:445s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:549s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:417s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:601s
fi-glk-dsi total:288 pass:176 dwarn:1 dfail:4 fail:0 skip:107 time:335s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_676/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.IGT: failure for tests/gem_eio: Fix usage of gem_quiescent_gpu
2017-12-14 22:01 [PATCH i-g-t] tests/gem_eio: Fix usage of gem_quiescent_gpu Antonio Argenziano
2017-12-14 22:45 ` Chris Wilson
2017-12-14 23:00 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-12-15 0:23 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-12-15 0:23 UTC (permalink / raw)
To: Antonio Argenziano; +Cc: intel-gfx
== Series Details ==
Series: tests/gem_eio: Fix usage of gem_quiescent_gpu
URL : https://patchwork.freedesktop.org/series/35382/
State : failure
== Summary ==
Test gem_tiled_swapping:
Subgroup non-threaded:
dmesg-warn -> PASS (shard-hsw) fdo#104218 +1
Test kms_flip:
Subgroup flip-vs-expired-vblank-interruptible:
pass -> INCOMPLETE (shard-snb)
Subgroup vblank-vs-suspend:
incomplete -> PASS (shard-hsw) fdo#103375
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623
Test gem_eio:
Subgroup suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103990
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103990 https://bugs.freedesktop.org/show_bug.cgi?id=103990
shard-hsw total:2681 pass:1517 dwarn:1 dfail:0 fail:10 skip:1152 time:9252s
shard-snb total:2663 pass:1282 dwarn:1 dfail:0 fail:11 skip:1368 time:7791s
Blacklisted hosts:
shard-apl total:2690 pass:1642 dwarn:3 dfail:0 fail:25 skip:1019 time:13115s
shard-kbl total:2669 pass:1759 dwarn:14 dfail:1 fail:30 skip:864 time:10559s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_676/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-15 0:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-14 22:01 [PATCH i-g-t] tests/gem_eio: Fix usage of gem_quiescent_gpu Antonio Argenziano
2017-12-14 22:45 ` Chris Wilson
2017-12-14 23:00 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-15 0:23 ` ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox