From: Thierry Reding <thierry.reding@gmail.com>
To: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"treding@nvidia.com" <treding@nvidia.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 06/10] drm/tegra: Handle 64-bit return from drm_crtc_vblank_count()
Date: Thu, 15 Feb 2018 13:17:01 +0100 [thread overview]
Message-ID: <20180215121701.GA29499@ulmo> (raw)
In-Reply-To: <1517969059.11349.39.camel@dk-H97M-D3H>
[-- Attachment #1.1: Type: text/plain, Size: 770 bytes --]
On Wed, Feb 07, 2018 at 01:41:18AM +0000, Pandiyan, Dhinakaran wrote:
> On Fri, 2018-02-02 at 21:12 -0800, Dhinakaran Pandiyan wrote:
> > 570e86963a51 ("drm: Widen vblank count to 64-bits [v3]") changed the
> > return type for drm_crtc_vblank_count() to u64. This could cause
> > potential problems if the return value is used in arithmetic operations
> > with a 32-bit reference HW vblank count. Explicitly typecasting this
> > down to u32 either fixes a potential problem or serves to add clarity in
> > case the implicit typecasting was already correct.
> >
> > Cc: Keith Packard <keithp@keithp.com>
> > Cc: Thierry Reding <treding@nvidia.com>
>
>
> Thierry,
>
> Can I get an Ack on this please?
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-15 12:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 5:12 [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences Dhinakaran Pandiyan
2018-02-03 5:12 ` [PATCH 02/10] drm/i915/vblank: Make the vblank counter u64 -> u32 typecast explicit Dhinakaran Pandiyan
2018-02-03 5:12 ` [PATCH 03/10] drm/i915: Handle 64-bit return from drm_crtc_vblank_count() Dhinakaran Pandiyan
2018-02-03 5:12 ` [PATCH 04/10] drm/amdgpu: " Dhinakaran Pandiyan
2018-02-05 15:20 ` Harry Wentland
2018-02-05 18:11 ` Alex Deucher
2018-02-03 5:12 ` [PATCH 05/10] drm/radeon: " Dhinakaran Pandiyan
2018-02-03 5:12 ` [PATCH 06/10] drm/tegra: " Dhinakaran Pandiyan
2018-02-07 1:41 ` Pandiyan, Dhinakaran
2018-02-07 9:41 ` Thierry Reding
2018-02-07 21:32 ` Pandiyan, Dhinakaran
2018-02-13 7:55 ` Rodrigo Vivi
2018-02-14 18:41 ` [Intel-gfx] " Rodrigo Vivi
2018-02-15 12:17 ` Thierry Reding [this message]
2018-02-03 5:12 ` [PATCH 07/10] drm/atomic: " Dhinakaran Pandiyan
2018-02-03 5:13 ` [PATCH 08/10] drm/vblank: Do not update vblank count if interrupts are already disabled Dhinakaran Pandiyan
2018-02-03 5:13 ` [PATCH 09/10] drm/vblank: Restoring vblank counts after device PM events Dhinakaran Pandiyan
2018-02-19 22:39 ` Daniel Vetter
2018-02-03 5:13 ` [PATCH 10/10] drm/i915: Estimate and update missed vblanks Dhinakaran Pandiyan
2018-02-03 6:16 ` ✓ Fi.CI.BAT: success for series starting with [01/10] drm/vblank: Data type fixes for 64-bit vblank sequences Patchwork
2018-02-03 8:14 ` [PATCH 01/10] " Keith Packard
2018-02-05 20:32 ` Rodrigo Vivi
2018-02-05 20:37 ` Dave Airlie
2018-02-05 20:49 ` Rodrigo Vivi
2018-02-05 21:11 ` [Intel-gfx] " Pandiyan, Dhinakaran
2018-02-05 23:41 ` Keith Packard
2018-02-15 19:55 ` Rodrigo Vivi
2018-02-16 18:49 ` [Intel-gfx] " Pandiyan, Dhinakaran
2018-02-03 9:58 ` ✗ Fi.CI.IGT: failure for series starting with [01/10] " Patchwork
2018-02-06 18:38 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-07 7:20 ` ✗ Fi.CI.BAT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215121701.GA29499@ulmo \
--to=thierry.reding@gmail.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox