public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/todo: i915 could use device_link_add
@ 2018-02-20 13:20 Daniel Vetter
  2018-02-20 13:40 ` ✓ Fi.CI.BAT: success for " Patchwork
  2018-02-20 14:17 ` [PATCH] " Imre Deak
  0 siblings, 2 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-02-20 13:20 UTC (permalink / raw)
  To: Intel Graphics Development
  Cc: Takashi Iwai, Daniel Vetter, DRI Development, Daniel Vetter

Noticed while reading some unrelated patches. Unfortunately Imre's
patch to add our early/late hooks predated the device_link
infrastructure by 2 years.

Cc: Imre Deak <imre.deak@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/gpu/todo.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 1a0a413eeced..f4d0b3476d9c 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -450,5 +450,12 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
 
 Contact: Harry Wentland, Alex Deucher
 
+i915
+----
+
+- Our early/late pm callbacks could be removed in favour of using
+  device_link_add to model the dependency between i915 and snd_had. See
+  https://dri.freedesktop.org/docs/drm/driver-api/device_link.html
+
 Outside DRM
 ===========
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* ✓ Fi.CI.BAT: success for drm/todo: i915 could use device_link_add
  2018-02-20 13:20 [PATCH] drm/todo: i915 could use device_link_add Daniel Vetter
@ 2018-02-20 13:40 ` Patchwork
  2018-02-20 14:17 ` [PATCH] " Imre Deak
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-02-20 13:40 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

== Series Details ==

Series: drm/todo: i915 could use device_link_add
URL   : https://patchwork.freedesktop.org/series/38588/
State : success

== Summary ==

Series 38588v1 drm/todo: i915 could use device_link_add
https://patchwork.freedesktop.org/api/1.0/series/38588/revisions/1/mbox/

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:415s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:432s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:371s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:476s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:283s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:476s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:479s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:463s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:455s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:573s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:413s
fi-gdg-551       total:288  pass:180  dwarn:0   dfail:0   fail:0   skip:108 time:282s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:508s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:387s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:411s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:453s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:412s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:450s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:490s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:447s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:490s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:595s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:426s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:503s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:517s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:491s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:486s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:407s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:428s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:510s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:394s

2c22e35947dba3af04655046412457c83401aa63 drm-tip: 2018y-02m-20d-11h-11m-23s UTC integration manifest
9b4e4492ca4d drm/todo: i915 could use device_link_add

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8080/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/todo: i915 could use device_link_add
  2018-02-20 13:20 [PATCH] drm/todo: i915 could use device_link_add Daniel Vetter
  2018-02-20 13:40 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-02-20 14:17 ` Imre Deak
  2018-02-20 23:48   ` Daniel Vetter
  1 sibling, 1 reply; 4+ messages in thread
From: Imre Deak @ 2018-02-20 14:17 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: Daniel Vetter, Intel Graphics Development, DRI Development

On Tue, Feb 20, 2018 at 02:20:17PM +0100, Daniel Vetter wrote:
> Noticed while reading some unrelated patches. Unfortunately Imre's
> patch to add our early/late hooks predated the device_link
> infrastructure by 2 years.
> 
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Yep, good idea to convert over:
Acked-by: Imre Deak <imre.deak@intel.com>

> ---
>  Documentation/gpu/todo.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 1a0a413eeced..f4d0b3476d9c 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -450,5 +450,12 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
>  
>  Contact: Harry Wentland, Alex Deucher
>  
> +i915
> +----
> +
> +- Our early/late pm callbacks could be removed in favour of using
> +  device_link_add to model the dependency between i915 and snd_had. See
> +  https://dri.freedesktop.org/docs/drm/driver-api/device_link.html
> +
>  Outside DRM
>  ===========
> -- 
> 2.15.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/todo: i915 could use device_link_add
  2018-02-20 14:17 ` [PATCH] " Imre Deak
@ 2018-02-20 23:48   ` Daniel Vetter
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-02-20 23:48 UTC (permalink / raw)
  To: Imre Deak
  Cc: Takashi Iwai, Daniel Vetter, Intel Graphics Development,
	DRI Development, Daniel Vetter

On Tue, Feb 20, 2018 at 04:17:19PM +0200, Imre Deak wrote:
> On Tue, Feb 20, 2018 at 02:20:17PM +0100, Daniel Vetter wrote:
> > Noticed while reading some unrelated patches. Unfortunately Imre's
> > patch to add our early/late hooks predated the device_link
> > infrastructure by 2 years.
> > 
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Yep, good idea to convert over:
> Acked-by: Imre Deak <imre.deak@intel.com>

Pushed to dinq.
-Daniel

> 
> > ---
> >  Documentation/gpu/todo.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> > index 1a0a413eeced..f4d0b3476d9c 100644
> > --- a/Documentation/gpu/todo.rst
> > +++ b/Documentation/gpu/todo.rst
> > @@ -450,5 +450,12 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
> >  
> >  Contact: Harry Wentland, Alex Deucher
> >  
> > +i915
> > +----
> > +
> > +- Our early/late pm callbacks could be removed in favour of using
> > +  device_link_add to model the dependency between i915 and snd_had. See
> > +  https://dri.freedesktop.org/docs/drm/driver-api/device_link.html
> > +
> >  Outside DRM
> >  ===========
> > -- 
> > 2.15.1
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-02-20 23:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-20 13:20 [PATCH] drm/todo: i915 could use device_link_add Daniel Vetter
2018-02-20 13:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-20 14:17 ` [PATCH] " Imre Deak
2018-02-20 23:48   ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox