public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Tvrtko Ursulin <tursulin@ursulin.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Eliminate devid sprinkle
Date: Thu, 22 Feb 2018 08:16:34 -0000	[thread overview]
Message-ID: <20180222081634.2958.36906@emeril.freedesktop.org> (raw)
In-Reply-To: <20180222080907.14716-1-tvrtko.ursulin@linux.intel.com>

== Series Details ==

Series: drm/i915: Eliminate devid sprinkle
URL   : https://patchwork.freedesktop.org/series/38749/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2cce38de5993 drm/i915: Eliminate devid sprinkle
-:171: WARNING: line over 80 characters
#171: FILE: drivers/gpu/drm/i915/intel_device_info.c:114:
+	drm_printf(p, "pciid=0x%04x rev=0x%02x platform=%s (subplatform=%x) gen=%i\n",

-:230: WARNING: suspect code indent for conditional statements (8, 17)
#230: FILE: drivers/gpu/drm/i915/intel_device_info.c:509:
+	} else if (IS_COFFEELAKE(i915)) {
+		 if ((devid & 0x00F0) == 0x00A0)

-:231: WARNING: Statements should start on a tabstop
#231: FILE: drivers/gpu/drm/i915/intel_device_info.c:510:
+		 if ((devid & 0x00F0) == 0x00A0)

total: 0 errors, 3 warnings, 0 checks, 237 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-02-22  8:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22  8:09 [RFC] drm/i915: Eliminate devid sprinkle Tvrtko Ursulin
2018-02-22  8:16 ` Patchwork [this message]
2018-02-22  8:24 ` Chris Wilson
2018-02-22 10:39   ` Tvrtko Ursulin
2018-02-22  8:30 ` ✗ Fi.CI.BAT: warning for " Patchwork
2018-02-22  8:35   ` Chris Wilson
2018-02-22  8:59     ` Tvrtko Ursulin
2018-02-22  9:05 ` [RFC v2] " Tvrtko Ursulin
2018-02-22 10:15   ` [RFC v3] " Tvrtko Ursulin
2018-02-22 10:27     ` Chris Wilson
2018-02-22 10:59     ` Chris Wilson
2018-02-26 14:00     ` Jani Nikula
2018-02-26 15:53       ` Chris Wilson
2018-02-26 16:08         ` Jani Nikula
2018-02-22  9:25 ` ✗ Fi.CI.BAT: warning for drm/i915: Eliminate devid sprinkle (rev2) Patchwork
2018-02-22 10:47 ` ✗ Fi.CI.BAT: warning for drm/i915: Eliminate devid sprinkle (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222081634.2958.36906@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox