Re: ✗ Fi.CI.BAT: warning for drm/i915: Eliminate devid sprinkle

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 22/02/2018 08:35, Chris Wilson wrote:
> Quoting Patchwork (2018-02-22 08:30:36)
>> == Series Details ==
>>
>> Series: drm/i915: Eliminate devid sprinkle
>> URL   : https://patchwork.freedesktop.org/series/38749/
>> State : warning
>>
>> == Summary ==
>>
>> Series 38749v1 drm/i915: Eliminate devid sprinkle
>> https://patchwork.freedesktop.org/api/1.0/series/38749/revisions/1/mbox/
>>
>> Test gem_mmap_gtt:
>>          Subgroup basic-small-bo-tiledx:
>>                  fail       -> PASS       (fi-gdg-551) fdo#102575
>> Test kms_busy:
>>          Subgroup basic-flip-a:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-b:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-c:
>>                  pass       -> SKIP       (fi-hsw-4770)
>> Test kms_cursor_legacy:
>>          Subgroup basic-busy-flip-before-cursor-atomic:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-busy-flip-before-cursor-legacy:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-after-cursor-atomic:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-after-cursor-legacy:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-after-cursor-varying-size:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-before-cursor-atomic:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-before-cursor-legacy:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-before-cursor-varying-size:
>>                  pass       -> SKIP       (fi-hsw-4770)
>> Test kms_flip:
>>          Subgroup basic-flip-vs-dpms:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-vs-modeset:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-flip-vs-wf_vblank:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-plain-flip:
>>                  pass       -> SKIP       (fi-hsw-4770)
>> Test kms_frontbuffer_tracking:
>>          Subgroup basic:
>>                  pass       -> SKIP       (fi-hsw-4770)
>> Test kms_pipe_crc_basic:
>>          Subgroup hang-read-crc-pipe-a:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup hang-read-crc-pipe-b:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup hang-read-crc-pipe-c:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup nonblocking-crc-pipe-a:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup nonblocking-crc-pipe-a-frame-sequence:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup nonblocking-crc-pipe-b:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup nonblocking-crc-pipe-b-frame-sequence:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup nonblocking-crc-pipe-c:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup nonblocking-crc-pipe-c-frame-sequence:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup read-crc-pipe-a:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup read-crc-pipe-a-frame-sequence:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup read-crc-pipe-b:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup read-crc-pipe-b-frame-sequence:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup read-crc-pipe-c:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup read-crc-pipe-c-frame-sequence:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup suspend-read-crc-pipe-a:
>>                  pass       -> SKIP       (fi-hsw-4770) fdo#104944
>>          Subgroup suspend-read-crc-pipe-b:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup suspend-read-crc-pipe-c:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>                  incomplete -> PASS       (fi-bxt-dsi) fdo#103927
>> Test pm_rpm:
>>          Subgroup basic-pci-d3-state:
>>                  pass       -> SKIP       (fi-hsw-4770)
>>          Subgroup basic-rte:
>>                  pass       -> SKIP       (fi-hsw-4770)
>> Test prime_vgem:
>>          Subgroup basic-fence-flip:
>>                  pass       -> SKIP       (fi-hsw-4770)
>> Test drv_module_reload:
>>          Subgroup basic-reload:
>>                  pass       -> DMESG-WARN (fi-hsw-4770)
>>          Subgroup basic-no-display:
>>                  pass       -> DMESG-WARN (fi-hsw-4770)
>>          Subgroup basic-reload-inject:
>>                  pass       -> DMESG-WARN (fi-hsw-4770)
> 
> I regret everything!
> 
> WARN_ON(((dev_priv)->info.platform_subplatform_mask & ((1UL << (INTEL_HASWELL)) | (1UL << ((32 - (2)) + (0))))) || ((dev_priv)->info.platform_subplatform_mask & ((1UL << (INTEL_BROADWELL)) | (1UL << ((32 - (2)) + (0))))))
> WARNING: CPU: 0 PID: 4450 at drivers/gpu/drm/i915/i915_drv.c:146 intel_pch_type+0x4e3/0x510 [i915]
> 
> Looks just to be an ordering issue.

Bug in the IS_SUBPLATFORM macro. It's checking for any bit set, but has 
to be both in this scheme. At least with that fixed text size is still 
in check.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx