Re: [PATCH 2/2] drm/i915/icl: implement icl_digital_port_connected()

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

Hi Paulo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20180620]
[cannot apply to v4.18-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Anusha-Srivatsa/drm-i915-icp-Add-Interrupt-Support/20180621-052041
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x011-201824 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/intel_dp.c: In function 'icl_tc_port_connected':
>> drivers/gpu/drm/i915/intel_dp.c:4766:19: error: implicit declaration of function 'ICP_TC_HOTPLUG'; did you mean 'GEN11_TC_HOTPLUG'? [-Werror=implicit-function-declaration]
     u32 legacy_bit = ICP_TC_HOTPLUG(tc_port);
                      ^~~~~~~~~~~~~~
                      GEN11_TC_HOTPLUG
   cc1: some warnings being treated as errors

vim +4766 drivers/gpu/drm/i915/intel_dp.c

  4760	
  4761	static bool icl_tc_port_connected(struct drm_i915_private *dev_priv,
  4762					  struct intel_digital_port *intel_dig_port)
  4763	{
  4764		enum port port = intel_dig_port->base.port;
  4765		enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
> 4766		u32 legacy_bit = ICP_TC_HOTPLUG(tc_port);
  4767		u32 typec_bit = GEN11_TC_HOTPLUG(tc_port);
  4768		u32 tbt_bit = GEN11_TBT_HOTPLUG(tc_port);
  4769		bool is_legacy = false, is_typec = false, is_tbt = false;
  4770		u32 cpu_isr;
  4771	
  4772		if (I915_READ(SDEISR) & legacy_bit)
  4773			is_legacy = true;
  4774	
  4775		cpu_isr = I915_READ(GEN11_DE_HPD_ISR);
  4776		if (cpu_isr & typec_bit)
  4777			is_typec = true;
  4778		if (cpu_isr & tbt_bit)
  4779			is_tbt = true;
  4780	
  4781		WARN_ON(is_legacy + is_typec + is_tbt > 1);
  4782		if (!is_legacy && !is_typec && !is_tbt)
  4783			return false;
  4784	
  4785		return true;
  4786	}
  4787	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34875 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx