* [PATCH] drm/i915: Redefine EINVAL for debugging
@ 2018-06-21 8:01 Chris Wilson
2018-06-21 8:22 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2018-06-21 8:01 UTC (permalink / raw)
To: intel-gfx
To aide debugging spurious EINVALs, include a debug message every time
we emit one from execbuf.
References: https://bugs.freedesktop.org/show_bug.cgi?id=106744
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 437441f4af41..c2dd9b4cdace 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -66,6 +66,15 @@ enum {
#define __I915_EXEC_ILLEGAL_FLAGS \
(__I915_EXEC_UNKNOWN_FLAGS | I915_EXEC_CONSTANTS_MASK)
+/* Catch emission of unexpected errors for CI! */
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)
+#undef EINVAL
+#define EINVAL ({ \
+ DRM_DEBUG_DRIVER("EINVAL at %s:%d\n", __func__, __LINE__); \
+ 22; \
+})
+#endif
+
/**
* DOC: User command execution
*
--
2.18.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Redefine EINVAL for debugging
2018-06-21 8:01 [PATCH] drm/i915: Redefine EINVAL for debugging Chris Wilson
@ 2018-06-21 8:22 ` Patchwork
2018-06-21 8:53 ` [PATCH] " Joonas Lahtinen
2018-06-21 11:02 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-21 8:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Redefine EINVAL for debugging
URL : https://patchwork.freedesktop.org/series/45142/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4356 -> Patchwork_9378 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/45142/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9378 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-skl-gvtdvm: INCOMPLETE (fdo#105600) -> PASS
fi-skl-6700k2: INCOMPLETE -> PASS
igt@gem_exec_gttfill@basic:
fi-byt-n2820: FAIL (fdo#106744) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#105128) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
fi-skl-guc: FAIL (fdo#104724, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#105600 https://bugs.freedesktop.org/show_bug.cgi?id=105600
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744
== Participating hosts (43 -> 37) ==
Additional (1): fi-bxt-dsi
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-glk-dsi fi-bsw-cyan fi-ctg-p8600 fi-kbl-x1275
== Build changes ==
* Linux: CI_DRM_4356 -> Patchwork_9378
CI_DRM_4356: a4e89d32048de56cde61e40efec9a0a697c238b6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4527: 04afec3ccfcb35e994f2e78254ff499f6b94f097 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9378: 2c63268cc448d5d5e6435f0e21c27916588a8c08 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2c63268cc448 drm/i915: Redefine EINVAL for debugging
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9378/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Redefine EINVAL for debugging
2018-06-21 8:01 [PATCH] drm/i915: Redefine EINVAL for debugging Chris Wilson
2018-06-21 8:22 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-06-21 8:53 ` Joonas Lahtinen
2018-06-21 9:14 ` Chris Wilson
2018-06-21 11:02 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Joonas Lahtinen @ 2018-06-21 8:53 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Quoting Chris Wilson (2018-06-21 11:01:50)
> To aide debugging spurious EINVALs, include a debug message every time
> we emit one from execbuf.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=106744
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
That's special kind of evil. But should do the job.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
You might be able to get away from hardcoding the 22 with first
calling the macro __EINVAL and then doing some trickery.
Regards, Joonas
> ---
> drivers/gpu/drm/i915/i915_gem_execbuffer.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index 437441f4af41..c2dd9b4cdace 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -66,6 +66,15 @@ enum {
> #define __I915_EXEC_ILLEGAL_FLAGS \
> (__I915_EXEC_UNKNOWN_FLAGS | I915_EXEC_CONSTANTS_MASK)
>
> +/* Catch emission of unexpected errors for CI! */
> +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)
> +#undef EINVAL
> +#define EINVAL ({ \
> + DRM_DEBUG_DRIVER("EINVAL at %s:%d\n", __func__, __LINE__); \
> + 22; \
> +})
> +#endif
> +
> /**
> * DOC: User command execution
> *
> --
> 2.18.0.rc2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Redefine EINVAL for debugging
2018-06-21 8:53 ` [PATCH] " Joonas Lahtinen
@ 2018-06-21 9:14 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-06-21 9:14 UTC (permalink / raw)
To: Joonas Lahtinen, intel-gfx
Quoting Joonas Lahtinen (2018-06-21 09:53:20)
> Quoting Chris Wilson (2018-06-21 11:01:50)
> > To aide debugging spurious EINVALs, include a debug message every time
> > we emit one from execbuf.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=106744
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> That's special kind of evil. But should do the job.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> You might be able to get away from hardcoding the 22 with first
> calling the macro __EINVAL and then doing some trickery.
Not sure what trickery. I tried the usual
#define __concat(x, y) x##y
indirection, but my CPP magic needs more power.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Redefine EINVAL for debugging
2018-06-21 8:01 [PATCH] drm/i915: Redefine EINVAL for debugging Chris Wilson
2018-06-21 8:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-21 8:53 ` [PATCH] " Joonas Lahtinen
@ 2018-06-21 11:02 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-21 11:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Redefine EINVAL for debugging
URL : https://patchwork.freedesktop.org/series/45142/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4356_full -> Patchwork_9378_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9378_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9378_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9378_full:
=== IGT changes ===
==== Warnings ====
igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
shard-snb: SKIP -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render:
shard-hsw: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9378_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
shard-kbl: PASS -> DMESG-FAIL (fdo#106947, fdo#106560)
shard-apl: PASS -> DMESG-FAIL (fdo#106947, fdo#106560)
igt@kms_flip_tiling@flip-y-tiled:
shard-glk: PASS -> FAIL (fdo#103822, fdo#104724)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-apl: FAIL (fdo#105347) -> PASS
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
shard-glk: FAIL (fdo#105703) -> PASS
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: FAIL (fdo#103355) -> PASS
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_flip@modeset-vs-vblank-race-interruptible:
shard-glk: FAIL (fdo#103060) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4356 -> Patchwork_9378
CI_DRM_4356: a4e89d32048de56cde61e40efec9a0a697c238b6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4527: 04afec3ccfcb35e994f2e78254ff499f6b94f097 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9378: 2c63268cc448d5d5e6435f0e21c27916588a8c08 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9378/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-21 11:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-21 8:01 [PATCH] drm/i915: Redefine EINVAL for debugging Chris Wilson
2018-06-21 8:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-21 8:53 ` [PATCH] " Joonas Lahtinen
2018-06-21 9:14 ` Chris Wilson
2018-06-21 11:02 ` ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox