Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: Remove defunct dma_buf_kmap stubs
@ 2018-08-07 17:47 Chris Wilson
  2018-08-07 17:53 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-07 17:47 UTC (permalink / raw)
  To: dri-devel, amd-gfx
  Cc: intel-gfx, Gerd Hoffmann, Alex Deucher, Christian König

Since commit 09ea0dfbf972 ("dma-buf: make map_atomic and map function
pointers optional"), we no longer need to provide stub no-op functions
as the core now provides them directly.

References: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c |  2 --
 drivers/gpu/drm/drm_prime.c               | 30 -----------------------
 include/drm/drm_prime.h                   |  3 ---
 3 files changed, 35 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
index 1c5d97f4b4dd..3fdd5688da0b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
@@ -338,8 +338,6 @@ static const struct dma_buf_ops amdgpu_dmabuf_ops = {
 	.unmap_dma_buf = drm_gem_unmap_dma_buf,
 	.release = drm_gem_dmabuf_release,
 	.begin_cpu_access = amdgpu_gem_begin_cpu_access,
-	.map = drm_gem_dmabuf_kmap,
-	.unmap = drm_gem_dmabuf_kunmap,
 	.mmap = drm_gem_dmabuf_mmap,
 	.vmap = drm_gem_dmabuf_vmap,
 	.vunmap = drm_gem_dmabuf_vunmap,
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 186db2e4c57a..e03d3bdaa59b 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -433,34 +433,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, void *vaddr)
 }
 EXPORT_SYMBOL(drm_gem_dmabuf_vunmap);
 
-/**
- * drm_gem_dmabuf_kmap - map implementation for GEM
- * @dma_buf: buffer to be mapped
- * @page_num: page number within the buffer
- *
- * Not implemented. This can be used as the &dma_buf_ops.map callback.
- */
-void *drm_gem_dmabuf_kmap(struct dma_buf *dma_buf, unsigned long page_num)
-{
-	return NULL;
-}
-EXPORT_SYMBOL(drm_gem_dmabuf_kmap);
-
-/**
- * drm_gem_dmabuf_kunmap - unmap implementation for GEM
- * @dma_buf: buffer to be unmapped
- * @page_num: page number within the buffer
- * @addr: virtual address of the buffer
- *
- * Not implemented. This can be used as the &dma_buf_ops.unmap callback.
- */
-void drm_gem_dmabuf_kunmap(struct dma_buf *dma_buf, unsigned long page_num,
-			   void *addr)
-{
-
-}
-EXPORT_SYMBOL(drm_gem_dmabuf_kunmap);
-
 /**
  * drm_gem_dmabuf_mmap - dma_buf mmap implementation for GEM
  * @dma_buf: buffer to be mapped
@@ -489,8 +461,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops =  {
 	.map_dma_buf = drm_gem_map_dma_buf,
 	.unmap_dma_buf = drm_gem_unmap_dma_buf,
 	.release = drm_gem_dmabuf_release,
-	.map = drm_gem_dmabuf_kmap,
-	.unmap = drm_gem_dmabuf_kunmap,
 	.mmap = drm_gem_dmabuf_mmap,
 	.vmap = drm_gem_dmabuf_vmap,
 	.vunmap = drm_gem_dmabuf_vunmap,
diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
index d716d653b096..e2032fbc0f08 100644
--- a/include/drm/drm_prime.h
+++ b/include/drm/drm_prime.h
@@ -93,9 +93,6 @@ void drm_gem_unmap_dma_buf(struct dma_buf_attachment *attach,
 			   enum dma_data_direction dir);
 void *drm_gem_dmabuf_vmap(struct dma_buf *dma_buf);
 void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, void *vaddr);
-void *drm_gem_dmabuf_kmap(struct dma_buf *dma_buf, unsigned long page_num);
-void drm_gem_dmabuf_kunmap(struct dma_buf *dma_buf, unsigned long page_num,
-			   void *addr);
 int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
 
 int drm_prime_sg_to_page_addr_arrays(struct sg_table *sgt, struct page **pages,
-- 
2.18.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for drm: Remove defunct dma_buf_kmap stubs
  2018-08-07 17:47 [PATCH] drm: Remove defunct dma_buf_kmap stubs Chris Wilson
@ 2018-08-07 17:53 ` Patchwork
       [not found] ` <20180807174748.4503-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-07 17:53 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm: Remove defunct dma_buf_kmap stubs
URL   : https://patchwork.freedesktop.org/series/47829/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ee6d380149a7 drm: Remove defunct dma_buf_kmap stubs
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13: 
References: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional")

-:13: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional")'
#13: 
References: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional")

total: 1 errors, 1 warnings, 0 checks, 59 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm: Remove defunct dma_buf_kmap stubs
       [not found] ` <20180807174748.4503-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
@ 2018-08-07 17:54   ` Christian König
  0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2018-08-07 17:54 UTC (permalink / raw)
  To: Chris Wilson, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: Alex Deucher, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	Gerd Hoffmann, Daniel Vetter

Am 07.08.2018 um 19:47 schrieb Chris Wilson:
> Since commit 09ea0dfbf972 ("dma-buf: make map_atomic and map function
> pointers optional"), we no longer need to provide stub no-op functions
> as the core now provides them directly.
>
> References: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c |  2 --
>   drivers/gpu/drm/drm_prime.c               | 30 -----------------------
>   include/drm/drm_prime.h                   |  3 ---
>   3 files changed, 35 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
> index 1c5d97f4b4dd..3fdd5688da0b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
> @@ -338,8 +338,6 @@ static const struct dma_buf_ops amdgpu_dmabuf_ops = {
>   	.unmap_dma_buf = drm_gem_unmap_dma_buf,
>   	.release = drm_gem_dmabuf_release,
>   	.begin_cpu_access = amdgpu_gem_begin_cpu_access,
> -	.map = drm_gem_dmabuf_kmap,
> -	.unmap = drm_gem_dmabuf_kunmap,
>   	.mmap = drm_gem_dmabuf_mmap,
>   	.vmap = drm_gem_dmabuf_vmap,
>   	.vunmap = drm_gem_dmabuf_vunmap,
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 186db2e4c57a..e03d3bdaa59b 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -433,34 +433,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, void *vaddr)
>   }
>   EXPORT_SYMBOL(drm_gem_dmabuf_vunmap);
>   
> -/**
> - * drm_gem_dmabuf_kmap - map implementation for GEM
> - * @dma_buf: buffer to be mapped
> - * @page_num: page number within the buffer
> - *
> - * Not implemented. This can be used as the &dma_buf_ops.map callback.
> - */
> -void *drm_gem_dmabuf_kmap(struct dma_buf *dma_buf, unsigned long page_num)
> -{
> -	return NULL;
> -}
> -EXPORT_SYMBOL(drm_gem_dmabuf_kmap);
> -
> -/**
> - * drm_gem_dmabuf_kunmap - unmap implementation for GEM
> - * @dma_buf: buffer to be unmapped
> - * @page_num: page number within the buffer
> - * @addr: virtual address of the buffer
> - *
> - * Not implemented. This can be used as the &dma_buf_ops.unmap callback.
> - */
> -void drm_gem_dmabuf_kunmap(struct dma_buf *dma_buf, unsigned long page_num,
> -			   void *addr)
> -{
> -
> -}
> -EXPORT_SYMBOL(drm_gem_dmabuf_kunmap);
> -
>   /**
>    * drm_gem_dmabuf_mmap - dma_buf mmap implementation for GEM
>    * @dma_buf: buffer to be mapped
> @@ -489,8 +461,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops =  {
>   	.map_dma_buf = drm_gem_map_dma_buf,
>   	.unmap_dma_buf = drm_gem_unmap_dma_buf,
>   	.release = drm_gem_dmabuf_release,
> -	.map = drm_gem_dmabuf_kmap,
> -	.unmap = drm_gem_dmabuf_kunmap,
>   	.mmap = drm_gem_dmabuf_mmap,
>   	.vmap = drm_gem_dmabuf_vmap,
>   	.vunmap = drm_gem_dmabuf_vunmap,
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index d716d653b096..e2032fbc0f08 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -93,9 +93,6 @@ void drm_gem_unmap_dma_buf(struct dma_buf_attachment *attach,
>   			   enum dma_data_direction dir);
>   void *drm_gem_dmabuf_vmap(struct dma_buf *dma_buf);
>   void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, void *vaddr);
> -void *drm_gem_dmabuf_kmap(struct dma_buf *dma_buf, unsigned long page_num);
> -void drm_gem_dmabuf_kunmap(struct dma_buf *dma_buf, unsigned long page_num,
> -			   void *addr);
>   int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
>   
>   int drm_prime_sg_to_page_addr_arrays(struct sg_table *sgt, struct page **pages,

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm: Remove defunct dma_buf_kmap stubs
  2018-08-07 17:47 [PATCH] drm: Remove defunct dma_buf_kmap stubs Chris Wilson
  2018-08-07 17:53 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
       [not found] ` <20180807174748.4503-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
@ 2018-08-07 17:55 ` Daniel Vetter
  2018-08-07 18:09 ` ✗ Fi.CI.BAT: failure for " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2018-08-07 17:55 UTC (permalink / raw)
  To: Chris Wilson
  Cc: intel-gfx, amd-gfx, dri-devel, Alex Deucher, Christian König,
	Gerd Hoffmann

On Tue, Aug 07, 2018 at 06:47:48PM +0100, Chris Wilson wrote:
> Since commit 09ea0dfbf972 ("dma-buf: make map_atomic and map function
> pointers optional"), we no longer need to provide stub no-op functions
> as the core now provides them directly.
> 
> References: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c |  2 --
>  drivers/gpu/drm/drm_prime.c               | 30 -----------------------
>  include/drm/drm_prime.h                   |  3 ---
>  3 files changed, 35 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
> index 1c5d97f4b4dd..3fdd5688da0b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c
> @@ -338,8 +338,6 @@ static const struct dma_buf_ops amdgpu_dmabuf_ops = {
>  	.unmap_dma_buf = drm_gem_unmap_dma_buf,
>  	.release = drm_gem_dmabuf_release,
>  	.begin_cpu_access = amdgpu_gem_begin_cpu_access,
> -	.map = drm_gem_dmabuf_kmap,
> -	.unmap = drm_gem_dmabuf_kunmap,
>  	.mmap = drm_gem_dmabuf_mmap,
>  	.vmap = drm_gem_dmabuf_vmap,
>  	.vunmap = drm_gem_dmabuf_vunmap,
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 186db2e4c57a..e03d3bdaa59b 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -433,34 +433,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, void *vaddr)
>  }
>  EXPORT_SYMBOL(drm_gem_dmabuf_vunmap);
>  
> -/**
> - * drm_gem_dmabuf_kmap - map implementation for GEM
> - * @dma_buf: buffer to be mapped
> - * @page_num: page number within the buffer
> - *
> - * Not implemented. This can be used as the &dma_buf_ops.map callback.
> - */
> -void *drm_gem_dmabuf_kmap(struct dma_buf *dma_buf, unsigned long page_num)
> -{
> -	return NULL;
> -}
> -EXPORT_SYMBOL(drm_gem_dmabuf_kmap);
> -
> -/**
> - * drm_gem_dmabuf_kunmap - unmap implementation for GEM
> - * @dma_buf: buffer to be unmapped
> - * @page_num: page number within the buffer
> - * @addr: virtual address of the buffer
> - *
> - * Not implemented. This can be used as the &dma_buf_ops.unmap callback.
> - */
> -void drm_gem_dmabuf_kunmap(struct dma_buf *dma_buf, unsigned long page_num,
> -			   void *addr)
> -{
> -
> -}
> -EXPORT_SYMBOL(drm_gem_dmabuf_kunmap);
> -
>  /**
>   * drm_gem_dmabuf_mmap - dma_buf mmap implementation for GEM
>   * @dma_buf: buffer to be mapped
> @@ -489,8 +461,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops =  {
>  	.map_dma_buf = drm_gem_map_dma_buf,
>  	.unmap_dma_buf = drm_gem_unmap_dma_buf,
>  	.release = drm_gem_dmabuf_release,
> -	.map = drm_gem_dmabuf_kmap,
> -	.unmap = drm_gem_dmabuf_kunmap,
>  	.mmap = drm_gem_dmabuf_mmap,
>  	.vmap = drm_gem_dmabuf_vmap,
>  	.vunmap = drm_gem_dmabuf_vunmap,
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index d716d653b096..e2032fbc0f08 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -93,9 +93,6 @@ void drm_gem_unmap_dma_buf(struct dma_buf_attachment *attach,
>  			   enum dma_data_direction dir);
>  void *drm_gem_dmabuf_vmap(struct dma_buf *dma_buf);
>  void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, void *vaddr);
> -void *drm_gem_dmabuf_kmap(struct dma_buf *dma_buf, unsigned long page_num);
> -void drm_gem_dmabuf_kunmap(struct dma_buf *dma_buf, unsigned long page_num,
> -			   void *addr);
>  int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
>  
>  int drm_prime_sg_to_page_addr_arrays(struct sg_table *sgt, struct page **pages,
> -- 
> 2.18.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* ✗ Fi.CI.BAT: failure for drm: Remove defunct dma_buf_kmap stubs
  2018-08-07 17:47 [PATCH] drm: Remove defunct dma_buf_kmap stubs Chris Wilson
                   ` (2 preceding siblings ...)
  2018-08-07 17:55 ` Daniel Vetter
@ 2018-08-07 18:09 ` Patchwork
  2018-08-07 18:20   ` Chris Wilson
  3 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-08-07 18:09 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm: Remove defunct dma_buf_kmap stubs
URL   : https://patchwork.freedesktop.org/series/47829/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4627 -> Patchwork_9871 =

== Summary - FAILURE ==

  Serious unknown changes coming with Patchwork_9871 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9871, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47829/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9871:

  === IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_fence@basic-await-default:
      fi-gdg-551:         SKIP -> DMESG-FAIL +3

    igt@gem_exec_fence@basic-busy-default:
      fi-blb-e6850:       PASS -> DMESG-FAIL +23
      fi-cfl-guc:         PASS -> DMESG-FAIL +23
      fi-skl-guc:         PASS -> DMESG-FAIL +23

    igt@gem_exec_fence@basic-wait-default:
      fi-skl-6770hq:      PASS -> DMESG-FAIL +23
      fi-skl-6600u:       PASS -> DMESG-FAIL +22
      fi-pnv-d510:        PASS -> DMESG-FAIL +23
      fi-kbl-7560u:       PASS -> DMESG-FAIL +22
      fi-whl-u:           PASS -> DMESG-FAIL +22
      fi-bwr-2160:        SKIP -> DMESG-FAIL +3
      {fi-skl-caroline}:  PASS -> DMESG-FAIL +3

    igt@gem_ringfill@basic-default:
      fi-bdw-gvtdvm:      PASS -> DMESG-FAIL +23
      fi-ivb-3770:        PASS -> DMESG-FAIL +23
      fi-bxt-dsi:         PASS -> DMESG-FAIL +22

    igt@gem_ringfill@basic-default-fd:
      fi-skl-6700k2:      PASS -> DMESG-FAIL +23
      fi-elk-e7500:       SKIP -> DMESG-FAIL
      fi-ilk-650:         SKIP -> DMESG-FAIL

    igt@gem_ringfill@basic-default-forked:
      fi-skl-gvtdvm:      PASS -> DMESG-FAIL +23
      fi-hsw-peppy:       PASS -> DMESG-FAIL +22
      {fi-icl-u}:         PASS -> DMESG-FAIL +22
      fi-kbl-x1275:       PASS -> DMESG-FAIL +22

    igt@prime_vgem@basic-busy-default:
      fi-bsw-n3050:       PASS -> DMESG-FAIL +22

    igt@prime_vgem@basic-fence-flip:
      fi-hsw-4770r:       PASS -> DMESG-FAIL +23
      fi-kbl-7500u:       PASS -> DMESG-FAIL +23
      {fi-bsw-kefka}:     SKIP -> DMESG-FAIL
      fi-snb-2520m:       NOTRUN -> DMESG-FAIL +23
      fi-glk-dsi:         SKIP -> DMESG-FAIL
      fi-bsw-n3050:       SKIP -> DMESG-FAIL
      fi-bxt-dsi:         SKIP -> DMESG-FAIL
      fi-ivb-3520m:       SKIP -> DMESG-FAIL
      fi-cnl-psr:         SKIP -> DMESG-FAIL
      fi-hsw-peppy:       SKIP -> DMESG-FAIL
      {fi-kbl-8809g}:     SKIP -> DMESG-FAIL
      {fi-bdw-samus}:     SKIP -> DMESG-FAIL
      fi-kbl-r:           SKIP -> DMESG-FAIL
      fi-kbl-x1275:       SKIP -> DMESG-FAIL
      {fi-icl-u}:         SKIP -> DMESG-FAIL
      fi-skl-6600u:       SKIP -> DMESG-FAIL
      fi-whl-u:           SKIP -> DMESG-FAIL
      fi-skl-6700hq:      SKIP -> DMESG-FAIL
      fi-kbl-7560u:       SKIP -> DMESG-FAIL
      fi-cfl-s3:          SKIP -> DMESG-FAIL
      fi-kbl-guc:         SKIP -> DMESG-FAIL
      {fi-byt-clapper}:   SKIP -> DMESG-FAIL

    igt@prime_vgem@basic-fence-mmap:
      {fi-skl-iommu}:     PASS -> DMESG-FAIL +23

    igt@prime_vgem@basic-fence-read:
      {fi-bsw-kefka}:     PASS -> DMESG-FAIL +22
      fi-cnl-psr:         PASS -> DMESG-FAIL +22
      fi-ilk-650:         PASS -> DMESG-FAIL +22
      fi-elk-e7500:       PASS -> DMESG-FAIL +22

    igt@prime_vgem@basic-fence-wait-default:
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL +23
      fi-kbl-7567u:       PASS -> DMESG-FAIL +23

    igt@prime_vgem@basic-gtt:
      fi-glk-j4005:       PASS -> DMESG-FAIL +23

    igt@prime_vgem@basic-read:
      {fi-bdw-samus}:     PASS -> DMESG-FAIL +22
      fi-bdw-5557u:       PASS -> DMESG-FAIL +23

    igt@prime_vgem@basic-sync-default:
      fi-byt-n2820:       PASS -> DMESG-FAIL +23
      fi-bxt-j4205:       PASS -> DMESG-FAIL +23
      fi-skl-6260u:       PASS -> DMESG-FAIL +23
      fi-byt-j1900:       PASS -> DMESG-FAIL +23

    igt@prime_vgem@basic-wait-default:
      fi-kbl-guc:         PASS -> DMESG-FAIL +22
      fi-hsw-4770:        PASS -> DMESG-FAIL +23

    igt@vgem_basic@dmabuf-export:
      {fi-kbl-8809g}:     PASS -> DMESG-FAIL +22
      fi-cfl-8700k:       PASS -> DMESG-FAIL +23
      fi-kbl-r:           PASS -> DMESG-FAIL +22
      {fi-byt-clapper}:   PASS -> DMESG-FAIL +22
      fi-bwr-2160:        PASS -> DMESG-FAIL +11

    igt@vgem_basic@dmabuf-fence:
      fi-ivb-3520m:       PASS -> DMESG-FAIL +22
      fi-snb-2600:        PASS -> DMESG-FAIL +23
      fi-gdg-551:         PASS -> DMESG-FAIL +11

    igt@vgem_basic@dmabuf-fence-before:
      fi-glk-dsi:         PASS -> DMESG-FAIL +22
      fi-skl-6700hq:      PASS -> DMESG-FAIL +22

    igt@vgem_basic@dmabuf-mmap:
      fi-cfl-s3:          PASS -> DMESG-FAIL +22

    
== Known issues ==

  Here are the changes found in Patchwork_9871 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    {igt@amdgpu/amd_basic@userptr}:
      {fi-kbl-8809g}:     PASS -> INCOMPLETE (fdo#107402)

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         PASS -> DMESG-FAIL (fdo#107174)

    igt@drv_selftest@live_workarounds:
      fi-cfl-8700k:       PASS -> DMESG-FAIL (fdo#107292)
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL (fdo#107292)

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103191, fdo#107362) +1

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       DMESG-WARN (fdo#107425) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-cfl-guc:         DMESG-FAIL -> PASS
      fi-kbl-7567u:       DMESG-FAIL (fdo#106947, fdo#106560) -> PASS

    igt@drv_selftest@live_workarounds:
      fi-kbl-x1275:       DMESG-FAIL (fdo#107292) -> PASS
      fi-cnl-psr:         DMESG-FAIL (fdo#107292) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
      {fi-byt-clapper}:   FAIL (fdo#107362) -> PASS

    
    ==== Warnings ====

    {igt@kms_psr@primary_page_flip}:
      fi-cnl-psr:         DMESG-FAIL (fdo#107372) -> DMESG-WARN (fdo#107372)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
  fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402
  fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425


== Participating hosts (53 -> 48) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4627 -> Patchwork_9871

  CI_DRM_4627: 02a516dd8c6aeb57812d08034a90624bc7fc431a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4587: 5d78c73d871525ec9caecd88ad7d9abe36637314 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9871: ee6d380149a73f782d290d4b936362af73e669d9 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

ee6d380149a7 drm: Remove defunct dma_buf_kmap stubs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9871/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ✗ Fi.CI.BAT: failure for drm: Remove defunct dma_buf_kmap stubs
  2018-08-07 18:09 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-08-07 18:20   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-07 18:20 UTC (permalink / raw)
  To: Patchwork; +Cc: intel-gfx, Gerd Hoffmann

Quoting Patchwork (2018-08-07 19:09:06)
> == Series Details ==
> 
> Series: drm: Remove defunct dma_buf_kmap stubs
> URL   : https://patchwork.freedesktop.org/series/47829/
> State : failure
> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_4627 -> Patchwork_9871 =
> 
> == Summary - FAILURE ==
> 
>   Serious unknown changes coming with Patchwork_9871 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_9871, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://patchwork.freedesktop.org/api/1.0/series/47829/revisions/1/mbox/
> 
> == Possible new issues ==
> 
>   Here are the unknown changes that may have been introduced in Patchwork_9871:
> 
>   === IGT changes ===
> 
>     ==== Possible regressions ====
> 
>     igt@gem_exec_fence@basic-await-default:
>       fi-gdg-551:         SKIP -> DMESG-FAIL +3

Grr. One little extra check to kill in dma_buf_export first(). Gerd,
come back here! :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-08-07 18:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07 17:47 [PATCH] drm: Remove defunct dma_buf_kmap stubs Chris Wilson
2018-08-07 17:53 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
     [not found] ` <20180807174748.4503-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2018-08-07 17:54   ` [PATCH] " Christian König
2018-08-07 17:55 ` Daniel Vetter
2018-08-07 18:09 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-08-07 18:20   ` Chris Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox