From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org,
Imre Deak <imre.deak@intel.linux.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s
Date: Tue, 4 Sep 2018 16:52:39 +0300 [thread overview]
Message-ID: <20180904135239.GG23558@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20180904101938.5545-1-chris@chris-wilson.co.uk>
On Tue, Sep 04, 2018 at 11:19:38AM +0100, Chris Wilson wrote:
> 5s is often not enough for the sound module to finish loading, so bump
> the timeout to 10s. For fun, poll quicker over the 1s!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.linux.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> lib/igt_pm.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index e86fa4a40..615463a08 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -258,12 +258,15 @@ void igt_pm_enable_audio_runtime_pm(void)
> if (__igt_pm_audio_runtime_power_save[0])
> return;
>
> - for (int count = 0; count < 5; count++) {
> + for (int count = 0; count < 110; count++) {
> if (!__igt_pm_enable_audio_runtime_pm())
> return;
>
> /* modprobe(sna-hda-intel) acts async so poll for sysfs */
> - sleep(1);
> + if (count < 100)
> + usleep(10 * 1000); /* poll at 10ms for the first 1s */
> + else
> + sleep(1);
> }
>
> err = __igt_pm_enable_audio_runtime_pm();
> --
> 2.19.0.rc1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-09-04 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 10:19 [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s Chris Wilson
2018-09-04 13:52 ` Imre Deak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904135239.GG23558@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=imre.deak@intel.linux.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox