* [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s
@ 2018-09-04 10:19 Chris Wilson
2018-09-04 13:52 ` [igt-dev] " Imre Deak
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wilson @ 2018-09-04 10:19 UTC (permalink / raw)
To: igt-dev; +Cc: Imre Deak, intel-gfx
5s is often not enough for the sound module to finish loading, so bump
the timeout to 10s. For fun, poll quicker over the 1s!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.linux.com>
---
lib/igt_pm.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index e86fa4a40..615463a08 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -258,12 +258,15 @@ void igt_pm_enable_audio_runtime_pm(void)
if (__igt_pm_audio_runtime_power_save[0])
return;
- for (int count = 0; count < 5; count++) {
+ for (int count = 0; count < 110; count++) {
if (!__igt_pm_enable_audio_runtime_pm())
return;
/* modprobe(sna-hda-intel) acts async so poll for sysfs */
- sleep(1);
+ if (count < 100)
+ usleep(10 * 1000); /* poll at 10ms for the first 1s */
+ else
+ sleep(1);
}
err = __igt_pm_enable_audio_runtime_pm();
--
2.19.0.rc1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [igt-dev] [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s
2018-09-04 10:19 [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s Chris Wilson
@ 2018-09-04 13:52 ` Imre Deak
0 siblings, 0 replies; 2+ messages in thread
From: Imre Deak @ 2018-09-04 13:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, Imre Deak, intel-gfx
On Tue, Sep 04, 2018 at 11:19:38AM +0100, Chris Wilson wrote:
> 5s is often not enough for the sound module to finish loading, so bump
> the timeout to 10s. For fun, poll quicker over the 1s!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.linux.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> lib/igt_pm.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index e86fa4a40..615463a08 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -258,12 +258,15 @@ void igt_pm_enable_audio_runtime_pm(void)
> if (__igt_pm_audio_runtime_power_save[0])
> return;
>
> - for (int count = 0; count < 5; count++) {
> + for (int count = 0; count < 110; count++) {
> if (!__igt_pm_enable_audio_runtime_pm())
> return;
>
> /* modprobe(sna-hda-intel) acts async so poll for sysfs */
> - sleep(1);
> + if (count < 100)
> + usleep(10 * 1000); /* poll at 10ms for the first 1s */
> + else
> + sleep(1);
> }
>
> err = __igt_pm_enable_audio_runtime_pm();
> --
> 2.19.0.rc1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-04 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-04 10:19 [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s Chris Wilson
2018-09-04 13:52 ` [igt-dev] " Imre Deak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox