* [PATCH v2 1/2] drm/i915/guc: Update GuC power domain states @ 2018-09-06 19:00 Michal Wajdeczko 2018-09-06 19:00 ` [PATCH v2 2/2] HAX Enable HuC testing without GuC submission Michal Wajdeczko 2018-09-06 19:25 ` ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/guc: Update GuC power domain states Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Michal Wajdeczko @ 2018-09-06 19:00 UTC (permalink / raw) To: intel-gfx We should update GuC power domain states also when GuC submission is disabled, otherwise GuC might complain or ignore our requests. This seems to be required for all currently released GuC firmwares. v2: it is only needed by pre-Gen11 firmwares Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: John Spotswood <john.a.spotswood@intel.com> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com> Cc: Tomasz Lis <tomasz.lis@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> --- drivers/gpu/drm/i915/intel_uc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c index 7c95697..b1b3e81 100644 --- a/drivers/gpu/drm/i915/intel_uc.c +++ b/drivers/gpu/drm/i915/intel_uc.c @@ -401,6 +401,10 @@ int intel_uc_init_hw(struct drm_i915_private *i915) ret = intel_guc_submission_enable(guc); if (ret) goto err_communication; + } else if (INTEL_GEN(i915) < 11) { + ret = intel_guc_sample_forcewake(guc); + if (ret) + goto err_communication; } dev_info(i915->drm.dev, "GuC firmware version %u.%u\n", -- 1.9.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] HAX Enable HuC testing without GuC submission 2018-09-06 19:00 [PATCH v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko @ 2018-09-06 19:00 ` Michal Wajdeczko 2018-09-06 19:25 ` ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/guc: Update GuC power domain states Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Michal Wajdeczko @ 2018-09-06 19:00 UTC (permalink / raw) To: intel-gfx This will let the driver decide where GuC can be used Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> --- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_uc.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 6c4d4a2..323fdc2 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/gpu/drm/i915/i915_params.h @@ -46,7 +46,7 @@ param(int, disable_power_well, -1) \ param(int, enable_ips, 1) \ param(int, invert_brightness, 0) \ - param(int, enable_guc, 0) \ + param(int, enable_guc, -1) \ param(int, guc_log_level, -1) \ param(char *, guc_firmware_path, NULL) \ param(char *, huc_firmware_path, NULL) \ diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c index b1b3e81..87be3c7 100644 --- a/drivers/gpu/drm/i915/intel_uc.c +++ b/drivers/gpu/drm/i915/intel_uc.c @@ -64,6 +64,9 @@ static int __get_platform_enable_guc(struct drm_i915_private *i915) /* Any platform specific fine-tuning can be done here */ + /* HAX: Do not enable GuC submission in auto mode */ + enable_guc &= ~ENABLE_GUC_SUBMISSION; + return enable_guc; } -- 1.9.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/guc: Update GuC power domain states 2018-09-06 19:00 [PATCH v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko 2018-09-06 19:00 ` [PATCH v2 2/2] HAX Enable HuC testing without GuC submission Michal Wajdeczko @ 2018-09-06 19:25 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-09-06 19:25 UTC (permalink / raw) To: Michal Wajdeczko; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915/guc: Update GuC power domain states URL : https://patchwork.freedesktop.org/series/49294/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4782 -> Patchwork_10112 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_10112 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_10112, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/49294/revisions/1/mbox/ == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_10112: === IGT changes === ==== Possible regressions ==== igt@drv_selftest@live_hangcheck: fi-skl-gvtdvm: PASS -> DMESG-FAIL == Known issues == Here are the changes found in Patchwork_10112 that come from known issues: === IGT changes === ==== Issues hit ==== igt@amdgpu/amd_basic@userptr: fi-kbl-8809g: PASS -> INCOMPLETE (fdo#107402) igt@drv_selftest@live_evict: fi-bsw-kefka: PASS -> DMESG-WARN (fdo#107709) igt@drv_selftest@live_hangcheck: fi-skl-6770hq: PASS -> DMESG-FAIL (fdo#107174) igt@gem_exec_suspend@basic-s3: fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718) igt@kms_chamelium@dp-crc-fast: fi-kbl-7500u: PASS -> FAIL (fdo#103841) igt@kms_frontbuffer_tracking@basic: fi-icl-u: SKIP -> FAIL (fdo#103167) fi-byt-clapper: PASS -> FAIL (fdo#103167) igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927) ==== Possible fixes ==== igt@kms_psr@primary_page_flip: fi-kbl-7560u: FAIL (fdo#107336) -> PASS fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167 fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841 fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927 fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174 fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336 fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402 fdo#107709 https://bugs.freedesktop.org/show_bug.cgi?id=107709 fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718 == Participating hosts (52 -> 49) == Additional (2): fi-byt-j1900 fi-gdg-551 Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u == Build changes == * Linux: CI_DRM_4782 -> Patchwork_10112 CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_10112: ee9aa96d5c38e5114ab5263bf3bc76b157d29d9a @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == ee9aa96d5c38 HAX Enable HuC testing without GuC submission d1f9bbe76ce7 drm/i915/guc: Update GuC power domain states == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10112/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-06 19:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-09-06 19:00 [PATCH v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko 2018-09-06 19:00 ` [PATCH v2 2/2] HAX Enable HuC testing without GuC submission Michal Wajdeczko 2018-09-06 19:25 ` ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/guc: Update GuC power domain states Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox