* [PATCH] drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
@ 2018-09-06 18:19 kai.chen
2018-09-06 18:44 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: kai.chen @ 2018-09-06 18:19 UTC (permalink / raw)
To: intel-gfx
From: Kai Chen <kai.chen@intel.com>
On GEN9LP, raise the RPS FUp Interrupt Limiter above softmax so that the
HW won't miss interrupt when requested max_freq is set back to RP0
value.
Signed-off-by: Kai Chen <kai.chen@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index d99e5fabe93c..bf2494294c9d 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6276,7 +6276,20 @@ static u32 intel_rps_limits(struct drm_i915_private *dev_priv, u8 val)
* frequency, if the down threshold expires in that window we will not
* receive a down interrupt. */
if (INTEL_GEN(dev_priv) >= 9) {
- limits = (rps->max_freq_softlimit) << 23;
+ int max_freq = rps->max_freq_softlimit;
+ int rp0_freq = rps->rp0_freq;
+
+ if (IS_GEN9_LP(dev_priv) && (max_freq == rp0_freq))
+ /*
+ * For GEN9_LP, it is suggested to increase the upper
+ * interrupt limiter by 1 (16.6MHz) so that the HW will
+ * generate an interrupt when we are near or just below
+ * the upper limit.
+ */
+ limits = (rps->max_freq_softlimit + 1) << 23;
+ else
+ limits = (rps->max_freq_softlimit) << 23;
+
if (val <= rps->min_freq_softlimit)
limits |= (rps->min_freq_softlimit) << 14;
} else {
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
2018-09-06 18:19 [PATCH] drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax kai.chen
@ 2018-09-06 18:44 ` Patchwork
2018-09-06 18:51 ` [PATCH] " Chris Wilson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-09-06 18:44 UTC (permalink / raw)
To: kai.chen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
URL : https://patchwork.freedesktop.org/series/49293/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e67dcf0dbc2b drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
-:25: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_freq == rp0_freq'
#25: FILE: drivers/gpu/drm/i915/intel_pm.c:6282:
+ if (IS_GEN9_LP(dev_priv) && (max_freq == rp0_freq))
total: 0 errors, 0 warnings, 1 checks, 21 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
2018-09-06 18:19 [PATCH] drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax kai.chen
2018-09-06 18:44 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-09-06 18:51 ` Chris Wilson
2018-09-06 19:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-09-06 20:00 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-09-06 18:51 UTC (permalink / raw)
To: intel-gfx, kai.chen
Quoting kai.chen@intel.com (2018-09-06 19:19:02)
> From: Kai Chen <kai.chen@intel.com>
>
> On GEN9LP, raise the RPS FUp Interrupt Limiter above softmax so that the
> HW won't miss interrupt when requested max_freq is set back to RP0
> value.
>
> Signed-off-by: Kai Chen <kai.chen@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index d99e5fabe93c..bf2494294c9d 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -6276,7 +6276,20 @@ static u32 intel_rps_limits(struct drm_i915_private *dev_priv, u8 val)
> * frequency, if the down threshold expires in that window we will not
> * receive a down interrupt. */
> if (INTEL_GEN(dev_priv) >= 9) {
> - limits = (rps->max_freq_softlimit) << 23;
> + int max_freq = rps->max_freq_softlimit;
> + int rp0_freq = rps->rp0_freq;
> +
> + if (IS_GEN9_LP(dev_priv) && (max_freq == rp0_freq))
> + /*
> + * For GEN9_LP, it is suggested to increase the upper
> + * interrupt limiter by 1 (16.6MHz) so that the HW will
> + * generate an interrupt when we are near or just below
> + * the upper limit.
By that explanation there is nothing peculiar to rp0. If the HW
calculation is unstable, it is unstable. One can postulate any number of
rounding errors that could cause an obo error, so without a better
explanation, one would say just increase it by one always.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
2018-09-06 18:19 [PATCH] drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax kai.chen
2018-09-06 18:44 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-09-06 18:51 ` [PATCH] " Chris Wilson
@ 2018-09-06 19:05 ` Patchwork
2018-09-06 20:00 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-09-06 19:05 UTC (permalink / raw)
To: kai.chen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
URL : https://patchwork.freedesktop.org/series/49293/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4782 -> Patchwork_10111 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49293/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10111 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_coherency:
fi-gdg-551: NOTRUN -> DMESG-FAIL (fdo#107164)
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#107362)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
fi-kbl-8809g: DMESG-WARN (fdo#107762) -> PASS
igt@kms_psr@primary_page_flip:
fi-kbl-7560u: FAIL (fdo#107336) -> PASS
==== Warnings ====
igt@amdgpu/amd_prime@amd-to-i915:
fi-kbl-8809g: DMESG-FAIL (fdo#107762) -> FAIL (fdo#107341)
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107762 https://bugs.freedesktop.org/show_bug.cgi?id=107762
== Participating hosts (52 -> 48) ==
Additional (2): fi-byt-j1900 fi-gdg-551
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4782 -> Patchwork_10111
CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10111: e67dcf0dbc2bbde9872cb385bd50dd38c695f2e4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e67dcf0dbc2b drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10111/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
2018-09-06 18:19 [PATCH] drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax kai.chen
` (2 preceding siblings ...)
2018-09-06 19:05 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-09-06 20:00 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-09-06 20:00 UTC (permalink / raw)
To: kai.chen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax
URL : https://patchwork.freedesktop.org/series/49293/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4782_full -> Patchwork_10111_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10111_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@fbc-suspend:
shard-apl: PASS -> DMESG-WARN (fdo#103558)
igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
shard-apl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +5
igt@pm_rpm@system-suspend:
shard-apl: PASS -> DMESG-WARN (fdo#103841)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-snb: INCOMPLETE (fdo#106886, fdo#105411) -> PASS
shard-glk: FAIL (fdo#106886) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4782 -> Patchwork_10111
CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10111: e67dcf0dbc2bbde9872cb385bd50dd38c695f2e4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10111/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-06 20:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-06 18:19 [PATCH] drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax kai.chen
2018-09-06 18:44 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-09-06 18:51 ` [PATCH] " Chris Wilson
2018-09-06 19:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-09-06 20:00 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox