Re: [Intel-gfx] [PATCH 18/18] drm/i915: Include infoframes in the crtc state dump

From: Daniel Vetter <daniel@ffwll.ch>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 18/18] drm/i915: Include infoframes in the crtc state dump
Date: Mon, 24 Sep 2018 18:14:45 +0200	[thread overview]
Message-ID: <20180924161445.GD11082@phenom.ffwll.local> (raw)
In-Reply-To: <20180920185145.1912-19-ville.syrjala@linux.intel.com>

On Thu, Sep 20, 2018 at 09:51:45PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Dump out the infoframes in the normal crtc state dump.
> 
> TODO: Try to better integrate the infoframe dumps with
>       drm state dumps
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Going to make dmesg with state debugging enabled even more noisier, but
hey, whatever gives us more data to drown in :-)

More seriously, maybe eventually someone ports drm debug over to one of
the more scalable logging thingies.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 3dce49e36a05..27ac33a2a4d3 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -10924,6 +10924,16 @@ intel_dump_m_n_config(struct intel_crtc_state *pipe_config, char *id,
>  		      m_n->link_m, m_n->link_n, m_n->tu);
>  }
>  
> +static void
> +intel_dump_infoframe(struct drm_i915_private *dev_priv,
> +		     const union hdmi_infoframe *frame)
> +{
> +	if ((drm_debug & DRM_UT_KMS) == 0)
> +		return;
> +
> +	hdmi_infoframe_log(KERN_DEBUG, dev_priv->drm.dev, frame);
> +}
> +
>  #define OUTPUT_TYPE(x) [INTEL_OUTPUT_ ## x] = #x
>  
>  static const char * const output_type_str[] = {
> @@ -11013,6 +11023,22 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
>  	DRM_DEBUG_KMS("audio: %i, infoframes: %i\n",
>  		      pipe_config->has_audio, pipe_config->has_infoframe);
>  
> +	DRM_DEBUG_KMS("infoframes enabled: 0x%x\n",
> +		      pipe_config->infoframes.enable);
> +
> +	if (pipe_config->infoframes.enable &
> +	    intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL))
> +		DRM_DEBUG_KMS("GCP: 0x%x\n", pipe_config->infoframes.gcp);
> +	if (pipe_config->infoframes.enable &
> +	    intel_hdmi_infoframe_enable(HDMI_INFOFRAME_TYPE_AVI))
> +		intel_dump_infoframe(dev_priv, &pipe_config->infoframes.avi);
> +	if (pipe_config->infoframes.enable &
> +	    intel_hdmi_infoframe_enable(HDMI_INFOFRAME_TYPE_SPD))
> +		intel_dump_infoframe(dev_priv, &pipe_config->infoframes.spd);
> +	if (pipe_config->infoframes.enable &
> +	    intel_hdmi_infoframe_enable(HDMI_INFOFRAME_TYPE_VENDOR))
> +		intel_dump_infoframe(dev_priv, &pipe_config->infoframes.hdmi);
> +
>  	DRM_DEBUG_KMS("requested mode:\n");
>  	drm_mode_debug_printmodeline(&pipe_config->base.mode);
>  	DRM_DEBUG_KMS("adjusted mode:\n");
> -- 
> 2.16.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel