Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Manasi Navare <manasi.d.navare@intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts
Date: Thu, 4 Oct 2018 16:28:36 -0700	[thread overview]
Message-ID: <20181004232835.GA4163@intel.com> (raw)
In-Reply-To: <a1c486a8068f7f6874a14d68346c7059c615cbb1.camel@intel.com>

On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote:
> On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote:
> > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote:
> > > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the
> > > definitions are unused.
> > 
> > If they are unused why are we fixing them instead of removing? Or
> > better,
> > why did we add them?
> I guess there are plans to make use of them, no idea.
>

Yes, the VDIP_RNABLE_PPS and DIP enables get used in the DSC patch series:

https://patchwork.freedesktop.org/series/47514/

If you want I can combine this fixes patch with the new revision of DSC patchseries
I am about to send out

Manasi
 
> Cc: Anusha, Manasi
> 
> > 
> > Lucas De Marchi
> > 
> > > 
> > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Fixes: 7af2be6d54d4 ("drm/i915/icl: Add VIDEO_DIP registers")
> > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/i915_reg.h | 18 +++++++++---------
> > >  1 file changed, 9 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > > b/drivers/gpu/drm/i915/i915_reg.h
> > > index 27e650fe591b..a0ad77b9212b 100644
> > > --- a/drivers/gpu/drm/i915/i915_reg.h
> > > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > > @@ -4584,6 +4584,15 @@ enum {
> > >  #define   VIDEO_DIP_FREQ_2VSYNC		(2 << 16)
> > >  #define   VIDEO_DIP_FREQ_MASK		(3 << 16)
> > >  /* HSW and later: */
> > > +#define   DRM_DIP_ENABLE		(1 << 28)
> > > +#define   PSR_VSC_BIT_7_SET		(1 << 27)
> > > +#define   VSC_SELECT_MASK		(0x3 << 25)
> > > +#define   VSC_SELECT_SHIFT		25
> > > +#define   VSC_DIP_HW_HEA_DATA		(0 << 25)
> > > +#define   VSC_DIP_HW_HEA_SW_DATA	(1 << 25)
> > > +#define   VSC_DIP_HW_DATA_SW_HEA	(2 << 25)
> > > +#define   VSC_DIP_SW_HEA_DATA		(3 << 25)
> > > +#define   VDIP_ENABLE_PPS		(1 << 24)
> > >  #define   VIDEO_DIP_ENABLE_VSC_HSW	(1 << 20)
> > >  #define   VIDEO_DIP_ENABLE_GCP_HSW	(1 << 16)
> > >  #define   VIDEO_DIP_ENABLE_AVI_HSW	(1 << 12)
> > > @@ -4591,15 +4600,6 @@ enum {
> > >  #define   VIDEO_DIP_ENABLE_GMP_HSW	(1 << 4)
> > >  #define   VIDEO_DIP_ENABLE_SPD_HSW	(1 << 0)
> > >  
> > > -#define  DRM_DIP_ENABLE			(1 << 28)
> > > -#define  PSR_VSC_BIT_7_SET		(1 << 27)
> > > -#define  VSC_SELECT_MASK		(0x3 << 26)
> > > -#define  VSC_SELECT_SHIFT		26
> > > -#define  VSC_DIP_HW_HEA_DATA		(0 << 26)
> > > -#define  VSC_DIP_HW_HEA_SW_DATA		(1 << 26)
> > > -#define  VSC_DIP_HW_DATA_SW_HEA		(2 << 26)
> > > -#define  VSC_DIP_SW_HEA_DATA		(3 << 26)
> > > -#define  VDIP_ENABLE_PPS		(1 << 24)
> > >  
> > >  /* Panel power sequencing */
> > >  #define PPS_BASE			0x61200
> > > -- 
> > > 2.14.1
> > > 
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-10-04 23:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 20:51 [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts Dhinakaran Pandiyan
2018-10-04 21:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-04 23:03 ` [PATCH] " Lucas De Marchi
2018-10-04 23:13   ` Dhinakaran Pandiyan
2018-10-04 23:28     ` Manasi Navare [this message]
2018-10-05  0:00       ` Dhinakaran Pandiyan
2018-10-05  0:27         ` Manasi Navare
2018-10-05  2:56           ` Dhinakaran Pandiyan
2018-10-05 18:10             ` Manasi Navare
2018-10-05 18:33               ` Dhinakaran Pandiyan
2018-10-04 23:24   ` Rodrigo Vivi
2018-10-05  3:54 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181004232835.GA4163@intel.com \
    --to=manasi.d.navare@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox