From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Switch the order of function parameters
Date: Mon, 29 Oct 2018 16:18:58 +0200 [thread overview]
Message-ID: <20181029141858.GM9144@intel.com> (raw)
In-Reply-To: <20181026195342.16828-1-dhinakaran.pandiyan@intel.com>
On Fri, Oct 26, 2018 at 12:53:42PM -0700, Dhinakaran Pandiyan wrote:
> intel_fb_pitch_limit() has the parameters pixel_format and fb_modifier
> switched in their positions. The parameters are however used correctly,
> but change the order for consistency.
>
> Also use kernel data types for both parameters.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index fe045abb6472..e7521664a724 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14346,7 +14346,7 @@ static const struct drm_framebuffer_funcs intel_fb_funcs = {
>
> static
> u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv,
> - uint64_t fb_modifier, uint32_t pixel_format)
> + u32 pixel_format, u64 fb_modifier)
> {
> struct intel_crtc *crtc;
> struct intel_plane *plane;
> @@ -14446,8 +14446,8 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
> goto err;
> }
>
> - pitch_limit = intel_fb_pitch_limit(dev_priv, mode_cmd->modifier[0],
> - mode_cmd->pixel_format);
> + pitch_limit = intel_fb_pitch_limit(dev_priv, mode_cmd->pixel_format,
> + mode_cmd->modifier[0]);
> if (mode_cmd->pitches[0] > pitch_limit) {
> DRM_DEBUG_KMS("%s pitch (%u) must be at most %d\n",
> mode_cmd->modifier[0] != DRM_FORMAT_MOD_LINEAR ?
> --
> 2.14.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-29 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 19:53 [PATCH] drm/i915: Switch the order of function parameters Dhinakaran Pandiyan
2018-10-26 20:58 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-27 5:28 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-29 14:18 ` Ville Syrjälä [this message]
2018-10-29 19:50 ` [PATCH] " Dhinakaran Pandiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029141858.GM9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox