* [PATCH 2/3] drm/i915: Remove pointless goto fail
2018-11-07 21:35 [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Ville Syrjala
@ 2018-11-07 21:35 ` Ville Syrjala
2018-11-07 21:35 ` [PATCH 3/3] drm/i915: Clean up the baseline bpp computation Ville Syrjala
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjala @ 2018-11-07 21:35 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We just 'return ret' immediately after jumping to the label. Let's
return directly instead.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index de989b4265b6..2af142860b73 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11297,7 +11297,7 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
struct intel_encoder *encoder;
struct drm_connector *connector;
struct drm_connector_state *connector_state;
- int base_bpp, ret = -EINVAL;
+ int base_bpp, ret;
int i;
bool retry = true;
@@ -11322,7 +11322,7 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
base_bpp = compute_baseline_pipe_bpp(to_intel_crtc(crtc),
pipe_config);
if (base_bpp < 0)
- goto fail;
+ return -EINVAL;
/*
* Determine the real pipe dimensions. Note that stereo modes can
@@ -11344,7 +11344,7 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
if (!check_single_encoder_cloning(state, to_intel_crtc(crtc), encoder)) {
DRM_DEBUG_KMS("rejecting invalid cloning configuration\n");
- goto fail;
+ return -EINVAL;
}
/*
@@ -11380,7 +11380,7 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
if (!(encoder->compute_config(encoder, pipe_config, connector_state))) {
DRM_DEBUG_KMS("Encoder config failure\n");
- goto fail;
+ return -EINVAL;
}
}
@@ -11392,17 +11392,15 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
ret = intel_crtc_compute_config(to_intel_crtc(crtc), pipe_config);
if (ret == -EDEADLK)
- goto fail;
+ return ret;
if (ret < 0) {
DRM_DEBUG_KMS("CRTC fixup failed\n");
- goto fail;
+ return ret;
}
if (ret == RETRY) {
- if (WARN(!retry, "loop in pipe configuration computation\n")) {
- ret = -EINVAL;
- goto fail;
- }
+ if (WARN(!retry, "loop in pipe configuration computation\n"))
+ return -EINVAL;
DRM_DEBUG_KMS("CRTC bw constrained, retrying\n");
retry = false;
@@ -11418,8 +11416,7 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
DRM_DEBUG_KMS("hw max bpp: %i, pipe bpp: %i, dithering: %i\n",
base_bpp, pipe_config->pipe_bpp, pipe_config->dither);
-fail:
- return ret;
+ return 0;
}
static bool intel_fuzzy_clock_check(int clock1, int clock2)
--
2.18.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/3] drm/i915: Clean up the baseline bpp computation
2018-11-07 21:35 [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Ville Syrjala
2018-11-07 21:35 ` [PATCH 2/3] drm/i915: Remove pointless goto fail Ville Syrjala
@ 2018-11-07 21:35 ` Ville Syrjala
2018-11-07 22:22 ` [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Imre Deak
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjala @ 2018-11-07 21:35 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pass on the errno all the way from connected_sink_max_bpp(),
and make the base_bpp handling in intel_modeset_pipe_config()
a bit less ugly. We'll also rename connected_sink_max_bpp()
to not give the impression that it return the bpp value,
and we'll pimp up the debug message within to include the
connector name/id.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 42 ++++++++++++++++------------
1 file changed, 24 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 2af142860b73..3534bc0d4fa8 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -10929,11 +10929,12 @@ static void intel_modeset_update_connector_atomic_state(struct drm_device *dev)
}
static int
-connected_sink_max_bpp(const struct drm_connector_state *conn_state,
- struct intel_crtc_state *pipe_config)
+compute_sink_pipe_bpp(const struct drm_connector_state *conn_state,
+ struct intel_crtc_state *pipe_config)
{
+ struct drm_connector *connector = conn_state->connector;
+ const struct drm_display_info *info = &connector->display_info;
int bpp;
- struct drm_display_info *info = &conn_state->connector->display_info;
switch (conn_state->max_bpc) {
case 6 ... 7:
@@ -10953,12 +10954,15 @@ connected_sink_max_bpp(const struct drm_connector_state *conn_state,
}
if (bpp < pipe_config->pipe_bpp) {
- DRM_DEBUG_KMS("Limiting display bpp to %d instead of Edid bpp "
- "%d, requested bpp %d, max platform bpp %d\n", bpp,
- 3 * info->bpc, 3 * conn_state->max_requested_bpc,
+ DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Limiting display bpp to %d instead of "
+ "EDID bpp %d, requested bpp %d, max platform bpp %d\n",
+ connector->base.id, connector->name,
+ bpp, 3 * info->bpc, 3 * conn_state->max_requested_bpc,
pipe_config->pipe_bpp);
+
pipe_config->pipe_bpp = bpp;
}
+
return 0;
}
@@ -10967,7 +10971,7 @@ compute_baseline_pipe_bpp(struct intel_crtc *crtc,
struct intel_crtc_state *pipe_config)
{
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
- struct drm_atomic_state *state;
+ struct drm_atomic_state *state = pipe_config->base.state;
struct drm_connector *connector;
struct drm_connector_state *connector_state;
int bpp, i;
@@ -10980,21 +10984,21 @@ compute_baseline_pipe_bpp(struct intel_crtc *crtc,
else
bpp = 8*3;
-
pipe_config->pipe_bpp = bpp;
- state = pipe_config->base.state;
-
- /* Clamp display bpp to EDID value */
+ /* Clamp display bpp to connector max bpp */
for_each_new_connector_in_state(state, connector, connector_state, i) {
+ int ret;
+
if (connector_state->crtc != &crtc->base)
continue;
- if (connected_sink_max_bpp(connector_state, pipe_config) < 0)
- return -EINVAL;
+ ret = compute_sink_pipe_bpp(connector_state, pipe_config);
+ if (ret)
+ return ret;
}
- return bpp;
+ return 0;
}
static void intel_dump_crtc_timings(const struct drm_display_mode *mode)
@@ -11319,10 +11323,12 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
(DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC)))
pipe_config->base.adjusted_mode.flags |= DRM_MODE_FLAG_NVSYNC;
- base_bpp = compute_baseline_pipe_bpp(to_intel_crtc(crtc),
- pipe_config);
- if (base_bpp < 0)
- return -EINVAL;
+ ret = compute_baseline_pipe_bpp(to_intel_crtc(crtc),
+ pipe_config);
+ if (ret)
+ return ret;
+
+ base_bpp = pipe_config->pipe_bpp;
/*
* Determine the real pipe dimensions. Note that stereo modes can
--
2.18.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
2018-11-07 21:35 [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Ville Syrjala
2018-11-07 21:35 ` [PATCH 2/3] drm/i915: Remove pointless goto fail Ville Syrjala
2018-11-07 21:35 ` [PATCH 3/3] drm/i915: Clean up the baseline bpp computation Ville Syrjala
@ 2018-11-07 22:22 ` Imre Deak
2018-11-07 22:34 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Imre Deak @ 2018-11-07 22:22 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
On Wed, Nov 07, 2018 at 11:35:20PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> ironlake_check_fdi_lanes() may try to grab some extra crtc locks.
> If that fails we need to propagate the -EDEADLK all the way up,
> and we shouldn't dump out the crtc state or other debug messages
> either since it wasn't the crtc state that caused the failure.
>
> Just hit this on my IVB:
> [drm:intel_atomic_check [i915]] checking fdi config on pipe C, lanes 3
> [drm:intel_atomic_check [i915]] only 2 lanes on pipe C: required 3 lanes
> [drm:intel_atomic_check [i915]] fdi link bw constraint, reducing pipe bpp to 18
> [drm:intel_atomic_check [i915]] checking fdi config on pipe C, lanes 2
> [drm:intel_atomic_check [i915]] CRTC bw constrained, retrying
> [drm:intel_dp_compute_config [i915]] DP link computation with max lane count 4 max rate 270000 max bpp 18 pixel clock 185580KHz
> [drm:intel_dp_compute_config [i915]] DP lane count 4 clock 162000 bpp 18
> [drm:intel_dp_compute_config [i915]] DP link rate required 417555 available 648000
> [drm:intel_atomic_check [i915]] checking fdi config on pipe C, lanes 2
> WARNING: CPU: 4 PID: 25115 at ../drivers/gpu/drm/drm_modeset_lock.c:241 drm_modeset_lock+0xbc/0xd0 [drm]
> ...
> WARNING: CPU: 4 PID: 25115 at ../drivers/gpu/drm/drm_modeset_lock.c:223 drm_modeset_drop_locks+0x4a/0x50 [drm]
>
> The warnings are from 'WARN_ON(ctx->contended)'.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Series looks ok:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ae6d58dbf1ed..de989b4265b6 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6447,6 +6447,9 @@ static int ironlake_fdi_compute_config(struct intel_crtc *intel_crtc,
> link_bw, &pipe_config->fdi_m_n, false);
>
> ret = ironlake_check_fdi_lanes(dev, intel_crtc->pipe, pipe_config);
> + if (ret == -EDEADLK)
> + return ret;
> +
> if (ret == -EINVAL && pipe_config->pipe_bpp > 6*3) {
> pipe_config->pipe_bpp -= 2*3;
> DRM_DEBUG_KMS("fdi link bw constraint, reducing pipe bpp to %i\n",
> @@ -11388,6 +11391,8 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
> * pipe_config->pixel_multiplier;
>
> ret = intel_crtc_compute_config(to_intel_crtc(crtc), pipe_config);
> + if (ret == -EDEADLK)
> + goto fail;
> if (ret < 0) {
> DRM_DEBUG_KMS("CRTC fixup failed\n");
> goto fail;
> @@ -12525,6 +12530,8 @@ static int intel_atomic_check(struct drm_device *dev,
> }
>
> ret = intel_modeset_pipe_config(crtc, pipe_config);
> + if (ret == -EDEADLK)
> + return ret;
> if (ret) {
> intel_dump_pipe_config(to_intel_crtc(crtc),
> pipe_config, "[failed]");
> --
> 2.18.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
2018-11-07 21:35 [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Ville Syrjala
` (2 preceding siblings ...)
2018-11-07 22:22 ` [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Imre Deak
@ 2018-11-07 22:34 ` Patchwork
2018-11-07 22:56 ` ✗ Fi.CI.BAT: failure " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-11-07 22:34 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
URL : https://patchwork.freedesktop.org/series/52191/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9c3a2b626b3e drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17:
[drm:intel_atomic_check [i915]] fdi link bw constraint, reducing pipe bpp to 18
total: 0 errors, 1 warnings, 0 checks, 25 lines checked
0175929e93e5 drm/i915: Remove pointless goto fail
1af6bc96f2a8 drm/i915: Clean up the baseline bpp computation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
2018-11-07 21:35 [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Ville Syrjala
` (3 preceding siblings ...)
2018-11-07 22:34 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork
@ 2018-11-07 22:56 ` Patchwork
2018-11-09 17:46 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-10 1:48 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-11-07 22:56 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
URL : https://patchwork.freedesktop.org/series/52191/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5103 -> Patchwork_10759 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10759 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10759, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52191/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10759:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@live_execlists:
fi-cfl-8109u: PASS -> DMESG-FAIL
igt@drv_selftest@live_hangcheck:
fi-bwr-2160: PASS -> DMESG-FAIL
==== Warnings ====
igt@drv_selftest@live_guc:
fi-skl-iommu: PASS -> SKIP +1
== Known issues ==
Here are the changes found in Patchwork_10759 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-skl-iommu: PASS -> INCOMPLETE (fdo#108602)
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: PASS -> WARN (fdo#108680)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-icl-u: PASS -> INCOMPLETE (fdo#107713)
fi-skl-6700k2: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@kms_flip@basic-flip-vs-modeset:
fi-hsw-4770r: DMESG-WARN (fdo#105602) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
fdo#108602 https://bugs.freedesktop.org/show_bug.cgi?id=108602
fdo#108680 https://bugs.freedesktop.org/show_bug.cgi?id=108680
== Participating hosts (54 -> 47) ==
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5103 -> Patchwork_10759
CI_DRM_5103: 23c1138030ad65402f698ab0b356e2f55722bc77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10759: 1af6bc96f2a8014cc9d21d9c23d955e32ada4085 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1af6bc96f2a8 drm/i915: Clean up the baseline bpp computation
0175929e93e5 drm/i915: Remove pointless goto fail
9c3a2b626b3e drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10759/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
2018-11-07 21:35 [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Ville Syrjala
` (4 preceding siblings ...)
2018-11-07 22:56 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2018-11-09 17:46 ` Patchwork
2018-11-10 1:48 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-11-09 17:46 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
URL : https://patchwork.freedesktop.org/series/52191/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5115 -> Patchwork_10796 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52191/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10796 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@gem_ctx_switch@basic-default:
fi-icl-u2: PASS -> DMESG-WARN (fdo#107724)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-icl-u2: FAIL (fdo#103167) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
== Participating hosts (52 -> 45) ==
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-icl-u
== Build changes ==
* Linux: CI_DRM_5115 -> Patchwork_10796
CI_DRM_5115: 95830469c0077bb86031e794106fdd7781369625 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10796: bb90c8eac186682956168a680f55bf95afdf7f9b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bb90c8eac186 drm/i915: Clean up the baseline bpp computation
cf1be25f9c7a drm/i915: Remove pointless goto fail
7f7a78ce3234 drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10796/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
2018-11-07 21:35 [PATCH 1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes() Ville Syrjala
` (5 preceding siblings ...)
2018-11-09 17:46 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-10 1:48 ` Patchwork
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-11-10 1:48 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915: Handle -EDEADLK from ironlake_check_fdi_lanes()
URL : https://patchwork.freedesktop.org/series/52191/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5115_full -> Patchwork_10796_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10796_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10796_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10796_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: SKIP -> PASS
igt@tools_test@tools_test:
shard-apl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10796_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@forcewake:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-skl: NOTRUN -> TIMEOUT (fdo#108039)
igt@gem_userptr_blits@readonly-unsync:
shard-skl: PASS -> INCOMPLETE (fdo#108074)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: NOTRUN -> FAIL (fdo#106641)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-snb: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
shard-kbl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-apl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
shard-skl: PASS -> FAIL (fdo#103184)
igt@kms_flip@flip-vs-expired-vblank:
shard-apl: PASS -> FAIL (fdo#102887, fdo#105363)
igt@kms_flip@modeset-vs-vblank-race-interruptible:
shard-glk: PASS -> FAIL (fdo#103060)
igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
shard-skl: NOTRUN -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
shard-skl: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
shard-skl: PASS -> FAIL (fdo#107815)
igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
shard-glk: PASS -> FAIL (fdo#103166)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@pm_rpm@gem-pread:
shard-skl: PASS -> INCOMPLETE (fdo#107807)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-glk: INCOMPLETE (k.org#198133, fdo#106886, fdo#103359) -> PASS
igt@gem_ctx_isolation@vecs0-s3:
shard-skl: INCOMPLETE (fdo#107773, fdo#104108) -> PASS
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665, fdo#106887) -> PASS
igt@gem_pwrite@big-gtt-fbr:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@kms_color@pipe-c-legacy-gamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-128x128-random:
shard-apl: FAIL (fdo#103232) -> PASS +2
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: FAIL (fdo#103355) -> PASS
igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
shard-skl: FAIL (fdo#106081) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-glk: FAIL (fdo#103166) -> PASS
igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
shard-apl: FAIL (fdo#103166) -> PASS
igt@perf@oa-exponents:
shard-glk: FAIL (fdo#105483) -> PASS
igt@pm_rpm@drm-resources-equal:
shard-skl: INCOMPLETE (fdo#107807) -> PASS
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105483 https://bugs.freedesktop.org/show_bug.cgi?id=105483
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106081 https://bugs.freedesktop.org/show_bug.cgi?id=106081
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5115 -> Patchwork_10796
CI_DRM_5115: 95830469c0077bb86031e794106fdd7781369625 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10796: bb90c8eac186682956168a680f55bf95afdf7f9b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10796/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread