Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lyude Paul <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
Subject: [PATCH v6 2/6] drm/dp_mst: Return kref_put() result from drm_dp_put_port()
Date: Thu, 15 Nov 2018 19:50:04 -0500	[thread overview]
Message-ID: <20181116005008.7243-3-lyude@redhat.com> (raw)
In-Reply-To: <20181116005008.7243-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

This will let us warn if we end up freeing a port when we're not
expecting to, which will make reporting erroneous usage of the new MST
VCPI helpers a little easier.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 529414556962..00fbe7a2699d 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -45,7 +45,7 @@ static bool dump_dp_payload_table(struct drm_dp_mst_topology_mgr *mgr,
 				  char *buf);
 static int test_calc_pbn_mode(void);
 
-static void drm_dp_put_port(struct drm_dp_mst_port *port);
+static int drm_dp_put_port(struct drm_dp_mst_port *port);
 
 static int drm_dp_dpcd_write_payload(struct drm_dp_mst_topology_mgr *mgr,
 				     int id,
@@ -969,9 +969,9 @@ static void drm_dp_destroy_port(struct kref *kref)
 	kfree(port);
 }
 
-static void drm_dp_put_port(struct drm_dp_mst_port *port)
+static int drm_dp_put_port(struct drm_dp_mst_port *port)
 {
-	kref_put(&port->kref, drm_dp_destroy_port);
+	return kref_put(&port->kref, drm_dp_destroy_port);
 }
 
 static struct drm_dp_mst_branch *drm_dp_mst_get_validated_mstb_ref_locked(struct drm_dp_mst_branch *mstb, struct drm_dp_mst_branch *to_find)
-- 
2.19.1

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2018-11-16  0:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16  0:50 [PATCH v6 0/6] drm/dp_mst: Improve VCPI helpers, use in nouveau Lyude Paul
     [not found] ` <20181116005008.7243-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-16  0:50   ` [PATCH v6 1/6] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
2018-11-26 20:24     ` [Nouveau] " Daniel Vetter
2018-11-16  0:50   ` Lyude Paul [this message]
2018-11-16  0:50   ` [PATCH v6 3/6] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
     [not found]     ` <20181116005008.7243-4-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-26 21:04       ` Daniel Vetter
2018-11-26 21:22         ` Daniel Vetter
     [not found]           ` <20181126212250.GS4266-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-11-27 17:48             ` Lyude Paul
2018-11-27 19:44               ` Daniel Vetter
2018-11-28  1:44                 ` Lyude Paul
2018-11-28  8:17                   ` Daniel Vetter
     [not found]                     ` <20181128081708.GG4266-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-11-28 18:48                       ` Lyude Paul
2018-11-29  1:14                     ` Lyude Paul
     [not found]                       ` <2743da9300e7805fd144995d33b9249aefc2857a.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-29  9:21                         ` Daniel Vetter
2018-11-26 21:36         ` Lyude Paul
     [not found]           ` <62577f81fbccbbc1f2c06183abdb490e35a5b0d5.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-27  9:07             ` Daniel Vetter
2018-11-16  0:50   ` [PATCH v6 5/6] drm/nouveau: Stop unsetting mstc->port, check connector registration Lyude Paul
2018-11-16  0:50 ` [PATCH v6 4/6] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
2018-11-16  0:50 ` [PATCH v6 6/6] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2018-11-16  1:11 ` ✗ Fi.CI.CHECKPATCH: warning for drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6) Patchwork
2018-11-16  1:14 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-16  1:29 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-16  4:26 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-11-16 20:01 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-17  9:18 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116005008.7243-3-lyude@redhat.com \
    --to=lyude-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=daniel-/w4YWyX8dFk@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox