Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Lyude Paul <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6)
Date: Fri, 16 Nov 2018 01:11:58 -0000	[thread overview]
Message-ID: <20181116011158.11618.50222@emeril.freedesktop.org> (raw)
In-Reply-To: <20181116005008.7243-1-lyude@redhat.com>

== Series Details ==

Series: drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6)
URL   : https://patchwork.freedesktop.org/series/51412/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
446143844eea drm/dp_mst: Add some atomic state iterator macros
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#55: FILE: include/drm/drm_dp_mst_helper.h:669:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#55: FILE: include/drm/drm_dp_mst_helper.h:669:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:57: WARNING:LONG_LINE: line over 100 characters
#57: FILE: include/drm/drm_dp_mst_helper.h:671:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#72: FILE: include/drm/drm_dp_mst_helper.h:686:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#72: FILE: include/drm/drm_dp_mst_helper.h:686:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:74: WARNING:LONG_LINE: line over 100 characters
#74: FILE: include/drm/drm_dp_mst_helper.h:688:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:90: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#90: FILE: include/drm/drm_dp_mst_helper.h:704:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:90: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#90: FILE: include/drm/drm_dp_mst_helper.h:704:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:92: WARNING:LONG_LINE: line over 100 characters
#92: FILE: include/drm/drm_dp_mst_helper.h:706:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

total: 0 errors, 4 warnings, 6 checks, 81 lines checked
69ff1fdbfe4e drm/dp_mst: Return kref_put() result from drm_dp_put_port()
783d19c2f54c drm/dp_mst: Start tracking per-port VCPI allocations
de21a67c03da drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
e0be5ec00684 drm/nouveau: Stop unsetting mstc->port, check connector registration
70fc28c8d19f drm/nouveau: Use atomic VCPI helpers for MST

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-11-16  1:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16  0:50 [PATCH v6 0/6] drm/dp_mst: Improve VCPI helpers, use in nouveau Lyude Paul
     [not found] ` <20181116005008.7243-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-16  0:50   ` [PATCH v6 1/6] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
2018-11-26 20:24     ` [Nouveau] " Daniel Vetter
2018-11-16  0:50   ` [PATCH v6 2/6] drm/dp_mst: Return kref_put() result from drm_dp_put_port() Lyude Paul
2018-11-16  0:50   ` [PATCH v6 3/6] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
     [not found]     ` <20181116005008.7243-4-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-26 21:04       ` Daniel Vetter
2018-11-26 21:22         ` Daniel Vetter
     [not found]           ` <20181126212250.GS4266-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-11-27 17:48             ` Lyude Paul
2018-11-27 19:44               ` Daniel Vetter
2018-11-28  1:44                 ` Lyude Paul
2018-11-28  8:17                   ` Daniel Vetter
     [not found]                     ` <20181128081708.GG4266-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-11-28 18:48                       ` Lyude Paul
2018-11-29  1:14                     ` Lyude Paul
     [not found]                       ` <2743da9300e7805fd144995d33b9249aefc2857a.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-29  9:21                         ` Daniel Vetter
2018-11-26 21:36         ` Lyude Paul
     [not found]           ` <62577f81fbccbbc1f2c06183abdb490e35a5b0d5.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-27  9:07             ` Daniel Vetter
2018-11-16  0:50   ` [PATCH v6 5/6] drm/nouveau: Stop unsetting mstc->port, check connector registration Lyude Paul
2018-11-16  0:50 ` [PATCH v6 4/6] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
2018-11-16  0:50 ` [PATCH v6 6/6] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2018-11-16  1:11 ` Patchwork [this message]
2018-11-16  1:14 ` ✗ Fi.CI.SPARSE: warning for drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6) Patchwork
2018-11-16  1:29 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-16  4:26 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-11-16 20:01 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-17  9:18 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116011158.11618.50222@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox