Re: [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in

From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Intel graphics driver community testing & development
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in
Date: Mon, 19 Nov 2018 10:02:36 +0800	[thread overview]
Message-ID: <20181119020236.GX7021@zhen-hp.sh.intel.com> (raw)
In-Reply-To: <20181116144447.7836-1-joonas.lahtinen@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1545 bytes --]

On 2018.11.16 16:44:47 +0200, Joonas Lahtinen wrote:
> Hide the enable_gvt modparam in the default scenario where
> support has not been compiled in.
> 
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 8d71886b5f03..2e0356561839 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -167,8 +167,10 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400,
>  i915_param_named(enable_dpcd_backlight, bool, 0600,
>  	"Enable support for DPCD backlight control (default:false)");
>  
> +#if IS_ENABLED(CONFIG_DRM_I915_GVT)
>  i915_param_named(enable_gvt, bool, 0400,
>  	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
> +#endif
>  
>  static __always_inline void _print_param(struct drm_printer *p,
>  					 const char *name,

I'm thinking we'd better to remove gvt parameter but depends on kernel
config only in considering of current state and be easier to try, or
better to be handled by gvt module split which will remove this
anyway, so

Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx