* [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it
@ 2018-11-30 23:20 José Roberto de Souza
2018-11-30 23:20 ` [PATCH v3 2/2] drm/i915: Move display device info capabilities to its own struct José Roberto de Souza
` (8 more replies)
0 siblings, 9 replies; 11+ messages in thread
From: José Roberto de Souza @ 2018-11-30 23:20 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
Right now it is decided if GEN has display by checking the num_pipes,
so lets make it explicit and use a macro.
Cc: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 10 +++++-----
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/intel_bios.c | 2 +-
drivers/gpu/drm/i915/intel_device_info.c | 4 ++--
drivers/gpu/drm/i915/intel_display.c | 4 ++--
drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
drivers/gpu/drm/i915/intel_i2c.c | 2 +-
7 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index e39016713464..6cd976a6a4d7 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -287,7 +287,7 @@ static void intel_detect_pch(struct drm_i915_private *dev_priv)
* Use PCH_NOP (PCH but no South Display) for PCH platforms without
* display.
*/
- if (pch && INTEL_INFO(dev_priv)->num_pipes == 0) {
+ if (pch && !HAS_DISPLAY(dev_priv)) {
DRM_DEBUG_KMS("Display disabled, reverting to NOP PCH\n");
dev_priv->pch_type = PCH_NOP;
dev_priv->pch_id = 0;
@@ -645,7 +645,7 @@ static int i915_load_modeset_init(struct drm_device *dev)
if (i915_inject_load_failure())
return -ENODEV;
- if (INTEL_INFO(dev_priv)->num_pipes) {
+ if (HAS_DISPLAY(dev_priv)) {
ret = drm_vblank_init(&dev_priv->drm,
INTEL_INFO(dev_priv)->num_pipes);
if (ret)
@@ -696,7 +696,7 @@ static int i915_load_modeset_init(struct drm_device *dev)
intel_overlay_setup(dev_priv);
- if (INTEL_INFO(dev_priv)->num_pipes == 0)
+ if (!HAS_DISPLAY(dev_priv))
return 0;
ret = intel_fbdev_init(dev);
@@ -1552,7 +1552,7 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
} else
DRM_ERROR("Failed to register driver for userspace access!\n");
- if (INTEL_INFO(dev_priv)->num_pipes) {
+ if (HAS_DISPLAY(dev_priv)) {
/* Must be done after probing outputs */
intel_opregion_register(dev_priv);
acpi_video_register();
@@ -1576,7 +1576,7 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
* We need to coordinate the hotplugs with the asynchronous fbdev
* configuration, for which we use the fbdev->async_cookie.
*/
- if (INTEL_INFO(dev_priv)->num_pipes)
+ if (HAS_DISPLAY(dev_priv))
drm_kms_helper_poll_init(dev);
intel_power_domains_enable(dev_priv);
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index d45475287130..f38658e1a20a 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2569,6 +2569,8 @@ intel_info(const struct drm_i915_private *dev_priv)
#define GT_FREQUENCY_MULTIPLIER 50
#define GEN9_FREQ_SCALER 3
+#define HAS_DISPLAY(dev_priv) (INTEL_INFO(dev_priv)->num_pipes > 0)
+
#include "i915_trace.h"
static inline bool intel_vtd_active(void)
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 0694aa8bb9bc..6d3e0260d49c 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1752,7 +1752,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
const struct bdb_header *bdb;
u8 __iomem *bios = NULL;
- if (INTEL_INFO(dev_priv)->num_pipes == 0) {
+ if (!HAS_DISPLAY(dev_priv)) {
DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n");
return;
}
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index ceecb5bd5226..677002a9e893 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -782,7 +782,7 @@ void intel_device_info_runtime_init(struct intel_device_info *info)
if (i915_modparams.disable_display) {
DRM_INFO("Display disabled (module parameter)\n");
info->num_pipes = 0;
- } else if (info->num_pipes > 0 &&
+ } else if (HAS_DISPLAY(dev_priv) &&
(IS_GEN7(dev_priv) || IS_GEN8(dev_priv)) &&
HAS_PCH_SPLIT(dev_priv)) {
u32 fuse_strap = I915_READ(FUSE_STRAP);
@@ -807,7 +807,7 @@ void intel_device_info_runtime_init(struct intel_device_info *info)
DRM_INFO("PipeC fused off\n");
info->num_pipes -= 1;
}
- } else if (info->num_pipes > 0 && IS_GEN9(dev_priv)) {
+ } else if (HAS_DISPLAY(dev_priv) && IS_GEN9(dev_priv)) {
u32 dfsm = I915_READ(SKL_DFSM);
u8 disabled_mask = 0;
bool invalid;
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 789f647bd598..b02b1d61853b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14235,7 +14235,7 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
intel_pps_init(dev_priv);
- if (INTEL_INFO(dev_priv)->num_pipes == 0)
+ if (!HAS_DISPLAY(dev_priv))
return;
/*
@@ -16026,7 +16026,7 @@ intel_display_capture_error_state(struct drm_i915_private *dev_priv)
};
int i;
- if (INTEL_INFO(dev_priv)->num_pipes == 0)
+ if (!HAS_DISPLAY(dev_priv))
return NULL;
error = kzalloc(sizeof(*error), GFP_ATOMIC);
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
index 2480c7d6edee..fb5bb5b32a60 100644
--- a/drivers/gpu/drm/i915/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/intel_fbdev.c
@@ -672,7 +672,7 @@ int intel_fbdev_init(struct drm_device *dev)
struct intel_fbdev *ifbdev;
int ret;
- if (WARN_ON(INTEL_INFO(dev_priv)->num_pipes == 0))
+ if (WARN_ON(!HAS_DISPLAY(dev_priv)))
return -ENODEV;
ifbdev = kzalloc(sizeof(struct intel_fbdev), GFP_KERNEL);
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index 33d87ab93fdd..802d0394ccc4 100644
--- a/drivers/gpu/drm/i915/intel_i2c.c
+++ b/drivers/gpu/drm/i915/intel_i2c.c
@@ -817,7 +817,7 @@ int intel_setup_gmbus(struct drm_i915_private *dev_priv)
unsigned int pin;
int ret;
- if (INTEL_INFO(dev_priv)->num_pipes == 0)
+ if (!HAS_DISPLAY(dev_priv))
return 0;
if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v3 2/2] drm/i915: Move display device info capabilities to its own struct 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza @ 2018-11-30 23:20 ` José Roberto de Souza 2018-11-30 23:32 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it Patchwork ` (7 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: José Roberto de Souza @ 2018-11-30 23:20 UTC (permalink / raw) To: intel-gfx This helps separate what capabilities are display capabilities. v3: Moving display struct right after flags (Lucas) Cc: Jani Nikula <jani.nikula@linux.intel.com> Suggested-by: Jani Nikula <jani.nikula@linux.intel.com> Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: José Roberto de Souza <jose.souza@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 22 ++--- drivers/gpu/drm/i915/i915_pci.c | 117 +++++++++++++---------- drivers/gpu/drm/i915/intel_device_info.c | 4 + drivers/gpu/drm/i915/intel_device_info.h | 32 ++++--- drivers/gpu/drm/i915/intel_display.c | 4 +- drivers/gpu/drm/i915/intel_fbc.c | 2 +- 6 files changed, 103 insertions(+), 78 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index f38658e1a20a..12b8476b09a2 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -2449,9 +2449,9 @@ intel_info(const struct drm_i915_private *dev_priv) ((sizes) & ~(dev_priv)->info.page_sizes) == 0; \ }) -#define HAS_OVERLAY(dev_priv) ((dev_priv)->info.has_overlay) +#define HAS_OVERLAY(dev_priv) ((dev_priv)->info.display.has_overlay) #define OVERLAY_NEEDS_PHYSICAL(dev_priv) \ - ((dev_priv)->info.overlay_needs_physical) + ((dev_priv)->info.display.overlay_needs_physical) /* Early gen2 have a totally busted CS tlb and require pinned batches. */ #define HAS_BROKEN_CS_TLB(dev_priv) (IS_I830(dev_priv) || IS_I845G(dev_priv)) @@ -2472,31 +2472,31 @@ intel_info(const struct drm_i915_private *dev_priv) #define HAS_128_BYTE_Y_TILING(dev_priv) (!IS_GEN2(dev_priv) && \ !(IS_I915G(dev_priv) || \ IS_I915GM(dev_priv))) -#define SUPPORTS_TV(dev_priv) ((dev_priv)->info.supports_tv) -#define I915_HAS_HOTPLUG(dev_priv) ((dev_priv)->info.has_hotplug) +#define SUPPORTS_TV(dev_priv) ((dev_priv)->info.display.supports_tv) +#define I915_HAS_HOTPLUG(dev_priv) ((dev_priv)->info.display.has_hotplug) #define HAS_FW_BLC(dev_priv) (INTEL_GEN(dev_priv) > 2) -#define HAS_FBC(dev_priv) ((dev_priv)->info.has_fbc) +#define HAS_FBC(dev_priv) ((dev_priv)->info.display.has_fbc) #define HAS_CUR_FBC(dev_priv) (!HAS_GMCH_DISPLAY(dev_priv) && INTEL_GEN(dev_priv) >= 7) #define HAS_IPS(dev_priv) (IS_HSW_ULT(dev_priv) || IS_BROADWELL(dev_priv)) -#define HAS_DP_MST(dev_priv) ((dev_priv)->info.has_dp_mst) +#define HAS_DP_MST(dev_priv) ((dev_priv)->info.display.has_dp_mst) -#define HAS_DDI(dev_priv) ((dev_priv)->info.has_ddi) +#define HAS_DDI(dev_priv) ((dev_priv)->info.display.has_ddi) #define HAS_FPGA_DBG_UNCLAIMED(dev_priv) ((dev_priv)->info.has_fpga_dbg) -#define HAS_PSR(dev_priv) ((dev_priv)->info.has_psr) +#define HAS_PSR(dev_priv) ((dev_priv)->info.display.has_psr) #define HAS_RC6(dev_priv) ((dev_priv)->info.has_rc6) #define HAS_RC6p(dev_priv) ((dev_priv)->info.has_rc6p) #define HAS_RC6pp(dev_priv) (false) /* HW was never validated */ -#define HAS_CSR(dev_priv) ((dev_priv)->info.has_csr) +#define HAS_CSR(dev_priv) ((dev_priv)->info.display.has_csr) #define HAS_RUNTIME_PM(dev_priv) ((dev_priv)->info.has_runtime_pm) #define HAS_64BIT_RELOC(dev_priv) ((dev_priv)->info.has_64bit_reloc) -#define HAS_IPC(dev_priv) ((dev_priv)->info.has_ipc) +#define HAS_IPC(dev_priv) ((dev_priv)->info.display.has_ipc) /* * For now, anything with a GuC requires uCode loading, and then supports @@ -2557,7 +2557,7 @@ intel_info(const struct drm_i915_private *dev_priv) #define HAS_PCH_NOP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_NOP) #define HAS_PCH_SPLIT(dev_priv) (INTEL_PCH_TYPE(dev_priv) != PCH_NONE) -#define HAS_GMCH_DISPLAY(dev_priv) ((dev_priv)->info.has_gmch_display) +#define HAS_GMCH_DISPLAY(dev_priv) ((dev_priv)->info.display.has_gmch_display) #define HAS_LSPCON(dev_priv) (INTEL_GEN(dev_priv) >= 9) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 1b81d7cb209e..6350db5503cd 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -79,8 +79,9 @@ #define GEN2_FEATURES \ GEN(2), \ .num_pipes = 1, \ - .has_overlay = 1, .overlay_needs_physical = 1, \ - .has_gmch_display = 1, \ + .display.has_overlay = 1, \ + .display.overlay_needs_physical = 1, \ + .display.has_gmch_display = 1, \ .hws_needs_physical = 1, \ .unfenced_needs_alignment = 1, \ .ring_mask = RENDER_RING, \ @@ -93,7 +94,8 @@ static const struct intel_device_info intel_i830_info = { GEN2_FEATURES, PLATFORM(INTEL_I830), - .is_mobile = 1, .cursor_needs_physical = 1, + .is_mobile = 1, + .display.cursor_needs_physical = 1, .num_pipes = 2, /* legal, last one wins */ }; @@ -107,8 +109,8 @@ static const struct intel_device_info intel_i85x_info = { PLATFORM(INTEL_I85X), .is_mobile = 1, .num_pipes = 2, /* legal, last one wins */ - .cursor_needs_physical = 1, - .has_fbc = 1, + .display.cursor_needs_physical = 1, + .display.has_fbc = 1, }; static const struct intel_device_info intel_i865g_info = { @@ -119,7 +121,7 @@ static const struct intel_device_info intel_i865g_info = { #define GEN3_FEATURES \ GEN(3), \ .num_pipes = 2, \ - .has_gmch_display = 1, \ + .display.has_gmch_display = 1, \ .ring_mask = RENDER_RING, \ .has_snoop = true, \ .has_coherent_ggtt = true, \ @@ -131,8 +133,9 @@ static const struct intel_device_info intel_i915g_info = { GEN3_FEATURES, PLATFORM(INTEL_I915G), .has_coherent_ggtt = false, - .cursor_needs_physical = 1, - .has_overlay = 1, .overlay_needs_physical = 1, + .display.cursor_needs_physical = 1, + .display.has_overlay = 1, + .display.overlay_needs_physical = 1, .hws_needs_physical = 1, .unfenced_needs_alignment = 1, }; @@ -141,10 +144,11 @@ static const struct intel_device_info intel_i915gm_info = { GEN3_FEATURES, PLATFORM(INTEL_I915GM), .is_mobile = 1, - .cursor_needs_physical = 1, - .has_overlay = 1, .overlay_needs_physical = 1, - .supports_tv = 1, - .has_fbc = 1, + .display.cursor_needs_physical = 1, + .display.has_overlay = 1, + .display.overlay_needs_physical = 1, + .display.supports_tv = 1, + .display.has_fbc = 1, .hws_needs_physical = 1, .unfenced_needs_alignment = 1, }; @@ -152,8 +156,10 @@ static const struct intel_device_info intel_i915gm_info = { static const struct intel_device_info intel_i945g_info = { GEN3_FEATURES, PLATFORM(INTEL_I945G), - .has_hotplug = 1, .cursor_needs_physical = 1, - .has_overlay = 1, .overlay_needs_physical = 1, + .display.has_hotplug = 1, + .display.cursor_needs_physical = 1, + .display.has_overlay = 1, + .display.overlay_needs_physical = 1, .hws_needs_physical = 1, .unfenced_needs_alignment = 1, }; @@ -162,10 +168,12 @@ static const struct intel_device_info intel_i945gm_info = { GEN3_FEATURES, PLATFORM(INTEL_I945GM), .is_mobile = 1, - .has_hotplug = 1, .cursor_needs_physical = 1, - .has_overlay = 1, .overlay_needs_physical = 1, - .supports_tv = 1, - .has_fbc = 1, + .display.has_hotplug = 1, + .display.cursor_needs_physical = 1, + .display.has_overlay = 1, + .display.overlay_needs_physical = 1, + .display.supports_tv = 1, + .display.has_fbc = 1, .hws_needs_physical = 1, .unfenced_needs_alignment = 1, }; @@ -173,23 +181,23 @@ static const struct intel_device_info intel_i945gm_info = { static const struct intel_device_info intel_g33_info = { GEN3_FEATURES, PLATFORM(INTEL_G33), - .has_hotplug = 1, - .has_overlay = 1, + .display.has_hotplug = 1, + .display.has_overlay = 1, }; static const struct intel_device_info intel_pineview_info = { GEN3_FEATURES, PLATFORM(INTEL_PINEVIEW), .is_mobile = 1, - .has_hotplug = 1, - .has_overlay = 1, + .display.has_hotplug = 1, + .display.has_overlay = 1, }; #define GEN4_FEATURES \ GEN(4), \ .num_pipes = 2, \ - .has_hotplug = 1, \ - .has_gmch_display = 1, \ + .display.has_hotplug = 1, \ + .display.has_gmch_display = 1, \ .ring_mask = RENDER_RING, \ .has_snoop = true, \ .has_coherent_ggtt = true, \ @@ -200,7 +208,7 @@ static const struct intel_device_info intel_pineview_info = { static const struct intel_device_info intel_i965g_info = { GEN4_FEATURES, PLATFORM(INTEL_I965G), - .has_overlay = 1, + .display.has_overlay = 1, .hws_needs_physical = 1, .has_snoop = false, }; @@ -208,9 +216,10 @@ static const struct intel_device_info intel_i965g_info = { static const struct intel_device_info intel_i965gm_info = { GEN4_FEATURES, PLATFORM(INTEL_I965GM), - .is_mobile = 1, .has_fbc = 1, - .has_overlay = 1, - .supports_tv = 1, + .is_mobile = 1, + .display.has_fbc = 1, + .display.has_overlay = 1, + .display.supports_tv = 1, .hws_needs_physical = 1, .has_snoop = false, }; @@ -224,15 +233,16 @@ static const struct intel_device_info intel_g45_info = { static const struct intel_device_info intel_gm45_info = { GEN4_FEATURES, PLATFORM(INTEL_GM45), - .is_mobile = 1, .has_fbc = 1, - .supports_tv = 1, + .is_mobile = 1, + .display.has_fbc = 1, + .display.supports_tv = 1, .ring_mask = RENDER_RING | BSD_RING, }; #define GEN5_FEATURES \ GEN(5), \ .num_pipes = 2, \ - .has_hotplug = 1, \ + .display.has_hotplug = 1, \ .ring_mask = RENDER_RING | BSD_RING, \ .has_snoop = true, \ .has_coherent_ggtt = true, \ @@ -250,14 +260,15 @@ static const struct intel_device_info intel_ironlake_d_info = { static const struct intel_device_info intel_ironlake_m_info = { GEN5_FEATURES, PLATFORM(INTEL_IRONLAKE), - .is_mobile = 1, .has_fbc = 1, + .is_mobile = 1, + .display.has_fbc = 1, }; #define GEN6_FEATURES \ GEN(6), \ .num_pipes = 2, \ - .has_hotplug = 1, \ - .has_fbc = 1, \ + .display.has_hotplug = 1, \ + .display.has_fbc = 1, \ .ring_mask = RENDER_RING | BSD_RING | BLT_RING, \ .has_coherent_ggtt = true, \ .has_llc = 1, \ @@ -301,8 +312,8 @@ static const struct intel_device_info intel_sandybridge_m_gt2_info = { #define GEN7_FEATURES \ GEN(7), \ .num_pipes = 3, \ - .has_hotplug = 1, \ - .has_fbc = 1, \ + .display.has_hotplug = 1, \ + .display.has_fbc = 1, \ .ring_mask = RENDER_RING | BSD_RING | BLT_RING, \ .has_coherent_ggtt = true, \ .has_llc = 1, \ @@ -359,8 +370,8 @@ static const struct intel_device_info intel_valleyview_info = { .num_pipes = 2, .has_runtime_pm = 1, .has_rc6 = 1, - .has_gmch_display = 1, - .has_hotplug = 1, + .display.has_gmch_display = 1, + .display.has_hotplug = 1, .ppgtt = INTEL_PPGTT_FULL, .has_snoop = true, .has_coherent_ggtt = false, @@ -374,10 +385,10 @@ static const struct intel_device_info intel_valleyview_info = { #define G75_FEATURES \ GEN7_FEATURES, \ .ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING, \ - .has_ddi = 1, \ + .display.has_ddi = 1, \ .has_fpga_dbg = 1, \ - .has_psr = 1, \ - .has_dp_mst = 1, \ + .display.has_psr = 1, \ + .display.has_dp_mst = 1, \ .has_rc6p = 0 /* RC6p removed-by HSW */, \ .has_runtime_pm = 1 @@ -444,14 +455,14 @@ static const struct intel_device_info intel_cherryview_info = { PLATFORM(INTEL_CHERRYVIEW), GEN(8), .num_pipes = 3, - .has_hotplug = 1, + .display.has_hotplug = 1, .is_lp = 1, .ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING, .has_64bit_reloc = 1, .has_runtime_pm = 1, .has_rc6 = 1, .has_logical_ring_contexts = 1, - .has_gmch_display = 1, + .display.has_gmch_display = 1, .ppgtt = INTEL_PPGTT_FULL, .has_reset_engine = 1, .has_snoop = true, @@ -473,15 +484,15 @@ static const struct intel_device_info intel_cherryview_info = { GEN(9), \ GEN9_DEFAULT_PAGE_SIZES, \ .has_logical_ring_preemption = 1, \ - .has_csr = 1, \ + .display.has_csr = 1, \ .has_guc = 1, \ - .has_ipc = 1, \ + .display.has_ipc = 1, \ .ddb_size = 896 #define SKL_PLATFORM \ GEN9_FEATURES, \ /* Display WA #0477 WaDisableIPC: skl */ \ - .has_ipc = 0, \ + .display.has_ipc = 0, \ PLATFORM(INTEL_SKYLAKE) static const struct intel_device_info intel_skylake_gt1_info = { @@ -512,19 +523,19 @@ static const struct intel_device_info intel_skylake_gt4_info = { #define GEN9_LP_FEATURES \ GEN(9), \ .is_lp = 1, \ - .has_hotplug = 1, \ + .display.has_hotplug = 1, \ .ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING, \ .num_pipes = 3, \ .has_64bit_reloc = 1, \ - .has_ddi = 1, \ + .display.has_ddi = 1, \ .has_fpga_dbg = 1, \ - .has_fbc = 1, \ - .has_psr = 1, \ + .display.has_fbc = 1, \ + .display.has_psr = 1, \ .has_runtime_pm = 1, \ .has_pooled_eu = 0, \ - .has_csr = 1, \ + .display.has_csr = 1, \ .has_rc6 = 1, \ - .has_dp_mst = 1, \ + .display.has_dp_mst = 1, \ .has_logical_ring_contexts = 1, \ .has_logical_ring_preemption = 1, \ .has_guc = 1, \ @@ -532,7 +543,7 @@ static const struct intel_device_info intel_skylake_gt4_info = { .has_reset_engine = 1, \ .has_snoop = true, \ .has_coherent_ggtt = false, \ - .has_ipc = 1, \ + .display.has_ipc = 1, \ GEN9_DEFAULT_PAGE_SIZES, \ GEN_DEFAULT_PIPEOFFSETS, \ IVB_CURSOR_OFFSETS, \ diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c index 677002a9e893..1e56319334f3 100644 --- a/drivers/gpu/drm/i915/intel_device_info.c +++ b/drivers/gpu/drm/i915/intel_device_info.c @@ -77,6 +77,10 @@ void intel_device_info_dump_flags(const struct intel_device_info *info, #define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, yesno(info->name)); DEV_INFO_FOR_EACH_FLAG(PRINT_FLAG); #undef PRINT_FLAG + +#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, yesno(info->display.name)); + DEV_INFO_DISPLAY_FOR_EACH_FLAG(PRINT_FLAG); +#undef PRINT_FLAG } static void sseu_dump(const struct sseu_dev_info *sseu, struct drm_printer *p) diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h index 88f97210dc49..1caf24e2cf0b 100644 --- a/drivers/gpu/drm/i915/intel_device_info.h +++ b/drivers/gpu/drm/i915/intel_device_info.h @@ -89,35 +89,38 @@ enum intel_ppgtt { func(is_alpha_support); \ /* Keep has_* in alphabetical order */ \ func(has_64bit_reloc); \ - func(has_csr); \ - func(has_ddi); \ - func(has_dp_mst); \ func(has_reset_engine); \ - func(has_fbc); \ func(has_fpga_dbg); \ - func(has_gmch_display); \ func(has_guc); \ func(has_guc_ct); \ - func(has_hotplug); \ func(has_l3_dpf); \ func(has_llc); \ func(has_logical_ring_contexts); \ func(has_logical_ring_elsq); \ func(has_logical_ring_preemption); \ - func(has_overlay); \ func(has_pooled_eu); \ - func(has_psr); \ func(has_rc6); \ func(has_rc6p); \ func(has_runtime_pm); \ func(has_snoop); \ func(has_coherent_ggtt); \ func(unfenced_needs_alignment); \ + func(hws_needs_physical); + +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \ + /* Keep in alphabetical order */ \ func(cursor_needs_physical); \ - func(hws_needs_physical); \ + func(has_csr); \ + func(has_ddi); \ + func(has_dp_mst); \ + func(has_fbc); \ + func(has_gmch_display); \ + func(has_hotplug); \ + func(has_ipc); \ + func(has_overlay); \ + func(has_psr); \ func(overlay_needs_physical); \ - func(supports_tv); \ - func(has_ipc); + func(supports_tv); #define GEN_MAX_SLICES (6) /* CNL upper bound */ #define GEN_MAX_SUBSLICES (8) /* ICL upper bound */ @@ -172,6 +175,13 @@ struct intel_device_info { #define DEFINE_FLAG(name) u8 name:1 DEV_INFO_FOR_EACH_FLAG(DEFINE_FLAG); #undef DEFINE_FLAG + + struct { +#define DEFINE_FLAG(name) u8 name:1 + DEV_INFO_DISPLAY_FOR_EACH_FLAG(DEFINE_FLAG); +#undef DEFINE_FLAG + } display; + u16 ddb_size; /* in blocks */ /* Register offsets for the various display pipes and transcoders */ diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index b02b1d61853b..23c2a10ae22b 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9703,7 +9703,7 @@ static u32 intel_cursor_base(const struct intel_plane_state *plane_state) const struct drm_i915_gem_object *obj = intel_fb_obj(fb); u32 base; - if (INTEL_INFO(dev_priv)->cursor_needs_physical) + if (INTEL_INFO(dev_priv)->display.cursor_needs_physical) base = obj->phys_handle->busaddr; else base = intel_plane_ggtt_offset(plane_state); @@ -13289,7 +13289,7 @@ static int intel_plane_pin_fb(struct intel_plane_state *plane_state) struct i915_vma *vma; if (plane->id == PLANE_CURSOR && - INTEL_INFO(dev_priv)->cursor_needs_physical) { + INTEL_INFO(dev_priv)->display.cursor_needs_physical) { struct drm_i915_gem_object *obj = intel_fb_obj(fb); const int align = intel_cursor_alignment(dev_priv); int err; diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index 14cbaf4a0e93..f23570c44323 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -1309,7 +1309,7 @@ void intel_fbc_init(struct drm_i915_private *dev_priv) fbc->active = false; if (need_fbc_vtd_wa(dev_priv)) - mkwrite_device_info(dev_priv)->has_fbc = false; + mkwrite_device_info(dev_priv)->display.has_fbc = false; i915_modparams.enable_fbc = intel_sanitize_fbc_option(dev_priv); DRM_DEBUG_KMS("Sanitized enable_fbc value: %d\n", -- 2.19.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza 2018-11-30 23:20 ` [PATCH v3 2/2] drm/i915: Move display device info capabilities to its own struct José Roberto de Souza @ 2018-11-30 23:32 ` Patchwork 2018-11-30 23:34 ` ✗ Fi.CI.SPARSE: " Patchwork ` (6 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-11-30 23:32 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it URL : https://patchwork.freedesktop.org/series/53341/ State : warning == Summary == $ dim checkpatch origin/drm-tip e5e5d91459ef drm/i915: Add HAS_DISPLAY() and use it cf3a99ffde76 drm/i915: Move display device info capabilities to its own struct -:397: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #397: FILE: drivers/gpu/drm/i915/intel_device_info.c:81: +#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, yesno(info->display.name)); -:437: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #437: FILE: drivers/gpu/drm/i915/intel_device_info.h:110: +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \ + /* Keep in alphabetical order */ \ func(cursor_needs_physical); \ + func(has_csr); \ + func(has_ddi); \ + func(has_dp_mst); \ + func(has_fbc); \ + func(has_gmch_display); \ + func(has_hotplug); \ + func(has_ipc); \ + func(has_overlay); \ + func(has_psr); \ func(overlay_needs_physical); \ + func(supports_tv); -:437: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #437: FILE: drivers/gpu/drm/i915/intel_device_info.h:110: +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \ + /* Keep in alphabetical order */ \ func(cursor_needs_physical); \ + func(has_csr); \ + func(has_ddi); \ + func(has_dp_mst); \ + func(has_fbc); \ + func(has_gmch_display); \ + func(has_hotplug); \ + func(has_ipc); \ + func(has_overlay); \ + func(has_psr); \ func(overlay_needs_physical); \ + func(supports_tv); -:437: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #437: FILE: drivers/gpu/drm/i915/intel_device_info.h:110: +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \ + /* Keep in alphabetical order */ \ func(cursor_needs_physical); \ + func(has_csr); \ + func(has_ddi); \ + func(has_dp_mst); \ + func(has_fbc); \ + func(has_gmch_display); \ + func(has_hotplug); \ + func(has_ipc); \ + func(has_overlay); \ + func(has_psr); \ func(overlay_needs_physical); \ + func(supports_tv); total: 1 errors, 2 warnings, 1 checks, 433 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza 2018-11-30 23:20 ` [PATCH v3 2/2] drm/i915: Move display device info capabilities to its own struct José Roberto de Souza 2018-11-30 23:32 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it Patchwork @ 2018-11-30 23:34 ` Patchwork 2018-11-30 23:52 ` ✓ Fi.CI.BAT: success " Patchwork ` (5 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-11-30 23:34 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it URL : https://patchwork.freedesktop.org/series/53341/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Add HAS_DISPLAY() and use it -drivers/gpu/drm/i915/selftests/../i915_drv.h:3571:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3573:16: warning: expression using sizeof(void) Commit: drm/i915: Move display device info capabilities to its own struct Okay! _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza ` (2 preceding siblings ...) 2018-11-30 23:34 ` ✗ Fi.CI.SPARSE: " Patchwork @ 2018-11-30 23:52 ` Patchwork 2018-12-01 18:32 ` ✗ Fi.CI.IGT: failure " Patchwork ` (4 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-11-30 23:52 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it URL : https://patchwork.freedesktop.org/series/53341/ State : success == Summary == CI Bug Log - changes from CI_DRM_5237 -> Patchwork_10985 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/53341/revisions/1/mbox/ Known issues ------------ Here are the changes found in Patchwork_10985 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s4-devices: - fi-ivb-3520m: PASS -> FAIL [fdo#108880] * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence: - fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence: - fi-skl-6700k2: PASS -> FAIL [fdo#103191] / [fdo#107362] * {igt@runner@aborted}: - {fi-icl-y}: NOTRUN -> FAIL [fdo#108070] #### Possible fixes #### * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070 [fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880 Participating hosts (49 -> 44) ------------------------------ Additional (1): fi-icl-y Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 Build changes ------------- * Linux: CI_DRM_5237 -> Patchwork_10985 CI_DRM_5237: 2f99c4889e4124f9cf50b745d037f432318c4bb4 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_10985: cf3a99ffde7648e442e7f49a45f5814c3ff2bd57 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == cf3a99ffde76 drm/i915: Move display device info capabilities to its own struct e5e5d91459ef drm/i915: Add HAS_DISPLAY() and use it == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10985/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza ` (3 preceding siblings ...) 2018-11-30 23:52 ` ✓ Fi.CI.BAT: success " Patchwork @ 2018-12-01 18:32 ` Patchwork 2018-12-03 23:00 ` Souza, Jose 2018-12-03 18:21 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) Patchwork ` (3 subsequent siblings) 8 siblings, 1 reply; 11+ messages in thread From: Patchwork @ 2018-12-01 18:32 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it URL : https://patchwork.freedesktop.org/series/53341/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5237_full -> Patchwork_10985_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_10985_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_10985_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_10985_full: ### IGT changes ### #### Possible regressions #### * igt@gem_eio@in-flight-internal-1us: - {shard-iclb}: PASS -> INCOMPLETE * igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled: - shard-skl: PASS -> FAIL Known issues ------------ Here are the changes found in Patchwork_10985_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@read_all_entries_display_off: - shard-skl: PASS -> INCOMPLETE [fdo#104108] +1 * igt@gem_exec_schedule@pi-ringfull-bsd: - shard-skl: NOTRUN -> FAIL [fdo#103158] * igt@i915_suspend@shrink: - shard-hsw: NOTRUN -> DMESG-WARN [fdo#108784] - {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#108784] * igt@kms_busy@extended-modeset-hang-newfb-render-a: - shard-snb: PASS -> DMESG-WARN [fdo#107956] * igt@kms_busy@extended-modeset-hang-newfb-render-b: - shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] * igt@kms_chv_cursor_fail@pipe-a-128x128-bottom-edge: - shard-skl: PASS -> FAIL [fdo#104671] * igt@kms_cursor_crc@cursor-256x256-dpms: - shard-glk: PASS -> FAIL [fdo#103232] +1 * igt@kms_cursor_crc@cursor-256x256-suspend: - shard-kbl: PASS -> DMESG-WARN [fdo#108566] * igt@kms_cursor_crc@cursor-256x85-offscreen: - shard-skl: PASS -> FAIL [fdo#103232] * igt@kms_cursor_crc@cursor-64x21-sliding: - {shard-iclb}: NOTRUN -> FAIL [fdo#103232] +2 * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-hsw: PASS -> FAIL [fdo#102887] - shard-glk: PASS -> FAIL [fdo#105363] * igt@kms_flip@plain-flip-fb-recreate-interruptible: - shard-skl: PASS -> FAIL [fdo#100368] * igt@kms_flip_tiling@flip-changes-tiling-y: - shard-skl: PASS -> FAIL [fdo#107931] / [fdo#108303] * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu: - shard-apl: PASS -> FAIL [fdo#103167] +2 * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen: - shard-glk: PASS -> FAIL [fdo#103167] +1 * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-skl: NOTRUN -> FAIL [fdo#105683] * igt@kms_frontbuffer_tracking@fbcpsr-tilingchange: - shard-skl: PASS -> FAIL [fdo#105682] +1 * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt: - {shard-iclb}: PASS -> FAIL [fdo#103167] +1 * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu: - {shard-iclb}: NOTRUN -> FAIL [fdo#103167] * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt: - shard-skl: PASS -> FAIL [fdo#103167] +1 * igt@kms_plane@pixel-format-pipe-a-planes: - shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] * igt@kms_plane_multiple@atomic-pipe-c-tiling-x: - shard-glk: PASS -> FAIL [fdo#103166] +1 - shard-apl: PASS -> FAIL [fdo#103166] * igt@kms_rotation_crc@primary-rotation-180: - shard-skl: PASS -> FAIL [fdo#103925] / [fdo#107815] * igt@kms_setmode@basic: - shard-apl: PASS -> FAIL [fdo#99912] - shard-kbl: PASS -> FAIL [fdo#99912] * igt@pm_rpm@system-suspend-execbuf: - shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773] / [fdo#107807] #### Possible fixes #### * igt@gem_ctx_isolation@rcs0-s3: - shard-snb: DMESG-WARN [fdo#102365] -> PASS * igt@kms_busy@extended-modeset-hang-newfb-render-c: - {shard-iclb}: DMESG-WARN [fdo#107956] -> PASS * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b: - shard-hsw: DMESG-WARN [fdo#107956] -> PASS * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c: - shard-skl: DMESG-WARN [fdo#107956] -> PASS * igt@kms_cursor_crc@cursor-64x64-onscreen: - shard-apl: FAIL [fdo#103232] -> PASS +2 * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu: - shard-glk: FAIL [fdo#103167] -> PASS +3 * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff: - {shard-iclb}: FAIL [fdo#103167] -> PASS +1 * igt@kms_plane@plane-position-covered-pipe-b-planes: - {shard-iclb}: FAIL [fdo#103166] -> PASS +1 * igt@kms_plane@plane-position-covered-pipe-c-planes: - shard-glk: FAIL [fdo#103166] -> PASS * igt@kms_plane_multiple@atomic-pipe-b-tiling-y: - shard-apl: FAIL [fdo#103166] -> PASS +2 * igt@kms_plane_scaling@pipe-a-scaler-with-rotation: - {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS * igt@kms_vblank@pipe-b-ts-continuation-suspend: - {shard-iclb}: INCOMPLETE [fdo#107713] -> PASS * igt@pm_rpm@legacy-planes: - {shard-iclb}: DMESG-WARN [fdo#108654] -> PASS #### Warnings #### * igt@i915_suspend@shrink: - shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#108784] {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365 [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103925]: https://bugs.freedesktop.org/show_bug.cgi?id=103925 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 [fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683 [fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885 [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815 [fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931 [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956 [fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654 [fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_5237 -> Patchwork_10985 CI_DRM_5237: 2f99c4889e4124f9cf50b745d037f432318c4bb4 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_10985: cf3a99ffde7648e442e7f49a45f5814c3ff2bd57 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10985/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ✗ Fi.CI.IGT: failure for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it 2018-12-01 18:32 ` ✗ Fi.CI.IGT: failure " Patchwork @ 2018-12-03 23:00 ` Souza, Jose 0 siblings, 0 replies; 11+ messages in thread From: Souza, Jose @ 2018-12-03 23:00 UTC (permalink / raw) To: intel-gfx@lists.freedesktop.org [-- Attachment #1.1: Type: text/plain, Size: 9448 bytes --] On Sat, 2018-12-01 at 18:32 +0000, Patchwork wrote: > == Series Details == > > Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and > use it > URL : https://patchwork.freedesktop.org/series/53341/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5237_full -> Patchwork_10985_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_10985_full absolutely > need to be > verified manually. > > If you think the reported changes have nothing to do with the > changes > introduced in Patchwork_10985_full, please notify your bug team to > allow them > to document this new failure mode, which will reduce false > positives in CI. > > > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in > Patchwork_10985_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@gem_eio@in-flight-internal-1us: > - {shard-iclb}: PASS -> INCOMPLETE > > * igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled: > - shard-skl: PASS -> FAIL > Patches pushed to drm-intel-next-queued as this changes are completely unrelated with this errors. > > Known issues > ------------ > > Here are the changes found in Patchwork_10985_full that come from > known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@debugfs_test@read_all_entries_display_off: > - shard-skl: PASS -> INCOMPLETE [fdo#104108] +1 > > * igt@gem_exec_schedule@pi-ringfull-bsd: > - shard-skl: NOTRUN -> FAIL [fdo#103158] > > * igt@i915_suspend@shrink: > - shard-hsw: NOTRUN -> DMESG-WARN [fdo#108784] > - {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#108784] > > * igt@kms_busy@extended-modeset-hang-newfb-render-a: > - shard-snb: PASS -> DMESG-WARN [fdo#107956] > > * igt@kms_busy@extended-modeset-hang-newfb-render-b: > - shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] > > * igt@kms_chv_cursor_fail@pipe-a-128x128-bottom-edge: > - shard-skl: PASS -> FAIL [fdo#104671] > > * igt@kms_cursor_crc@cursor-256x256-dpms: > - shard-glk: PASS -> FAIL [fdo#103232] +1 > > * igt@kms_cursor_crc@cursor-256x256-suspend: > - shard-kbl: PASS -> DMESG-WARN [fdo#108566] > > * igt@kms_cursor_crc@cursor-256x85-offscreen: > - shard-skl: PASS -> FAIL [fdo#103232] > > * igt@kms_cursor_crc@cursor-64x21-sliding: > - {shard-iclb}: NOTRUN -> FAIL [fdo#103232] +2 > > * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: > - shard-hsw: PASS -> FAIL [fdo#102887] > - shard-glk: PASS -> FAIL [fdo#105363] > > * igt@kms_flip@plain-flip-fb-recreate-interruptible: > - shard-skl: PASS -> FAIL [fdo#100368] > > * igt@kms_flip_tiling@flip-changes-tiling-y: > - shard-skl: PASS -> FAIL [fdo#107931] / [fdo#108303] > > * igt@kms > _frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu: > - shard-apl: PASS -> FAIL [fdo#103167] +2 > > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen > : > - shard-glk: PASS -> FAIL [fdo#103167] +1 > > * igt@kms_frontbuffer_tracking@fbc-stridechange: > - shard-skl: NOTRUN -> FAIL [fdo#105683] > > * igt@kms_frontbuffer_tracking@fbcpsr-tilingchange: > - shard-skl: PASS -> FAIL [fdo#105682] +1 > > * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt: > - {shard-iclb}: PASS -> FAIL [fdo#103167] +1 > > * igt@kms > _frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu: > - {shard-iclb}: NOTRUN -> FAIL [fdo#103167] > > * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt: > - shard-skl: PASS -> FAIL [fdo#103167] +1 > > * igt@kms_plane@pixel-format-pipe-a-planes: > - shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] > > * igt@kms_plane_multiple@atomic-pipe-c-tiling-x: > - shard-glk: PASS -> FAIL [fdo#103166] +1 > - shard-apl: PASS -> FAIL [fdo#103166] > > * igt@kms_rotation_crc@primary-rotation-180: > - shard-skl: PASS -> FAIL [fdo#103925] / [fdo#107815] > > * igt@kms_setmode@basic: > - shard-apl: PASS -> FAIL [fdo#99912] > - shard-kbl: PASS -> FAIL [fdo#99912] > > * igt@pm_rpm@system-suspend-execbuf: > - shard-skl: PASS -> INCOMPLETE [fdo#104108] / > [fdo#107773] / [fdo#107807] > > > #### Possible fixes #### > > * igt@gem_ctx_isolation@rcs0-s3: > - shard-snb: DMESG-WARN [fdo#102365] -> PASS > > * igt@kms_busy@extended-modeset-hang-newfb-render-c: > - {shard-iclb}: DMESG-WARN [fdo#107956] -> PASS > > * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b: > - shard-hsw: DMESG-WARN [fdo#107956] -> PASS > > * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c: > - shard-skl: DMESG-WARN [fdo#107956] -> PASS > > * igt@kms_cursor_crc@cursor-64x64-onscreen: > - shard-apl: FAIL [fdo#103232] -> PASS +2 > > * igt@kms > _frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu: > - shard-glk: FAIL [fdo#103167] -> PASS +3 > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff: > - {shard-iclb}: FAIL [fdo#103167] -> PASS +1 > > * igt@kms_plane@plane-position-covered-pipe-b-planes: > - {shard-iclb}: FAIL [fdo#103166] -> PASS +1 > > * igt@kms_plane@plane-position-covered-pipe-c-planes: > - shard-glk: FAIL [fdo#103166] -> PASS > > * igt@kms_plane_multiple@atomic-pipe-b-tiling-y: > - shard-apl: FAIL [fdo#103166] -> PASS +2 > > * igt@kms_plane_scaling@pipe-a-scaler-with-rotation: > - {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS > > * igt@kms_vblank@pipe-b-ts-continuation-suspend: > - {shard-iclb}: INCOMPLETE [fdo#107713] -> PASS > > * igt@pm_rpm@legacy-planes: > - {shard-iclb}: DMESG-WARN [fdo#108654] -> PASS > > > #### Warnings #### > > * igt@i915_suspend@shrink: > - shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> > DMESG-WARN [fdo#108784] > > > {name}: This element is suppressed. This means it is ignored when > computing > the status of the difference (SUCCESS, WARNING, or > FAILURE). > > [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 > [fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365 > [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 > [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158 > [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 > [fdo#103925]: https://bugs.freedesktop.org/show_bug.cgi?id=103925 > [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 > [fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671 > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 > [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 > [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 > [fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683 > [fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885 > [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886 > [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 > [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 > [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773 > [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 > [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815 > [fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931 > [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956 > [fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303 > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 > [fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654 > [fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784 > [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 > > > Participating hosts (7 -> 7) > ------------------------------ > > No changes in participating hosts > > > Build changes > ------------- > > * Linux: CI_DRM_5237 -> Patchwork_10985 > > CI_DRM_5237: 2f99c4889e4124f9cf50b745d037f432318c4bb4 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_10985: cf3a99ffde7648e442e7f49a45f5814c3ff2bd57 @ > git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ > git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10985/ [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza ` (4 preceding siblings ...) 2018-12-01 18:32 ` ✗ Fi.CI.IGT: failure " Patchwork @ 2018-12-03 18:21 ` Patchwork 2018-12-03 18:23 ` ✗ Fi.CI.SPARSE: " Patchwork ` (2 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-12-03 18:21 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) URL : https://patchwork.freedesktop.org/series/53341/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2ea25bb8bc83 drm/i915: Add HAS_DISPLAY() and use it b7a8a1adc388 drm/i915: Move display device info capabilities to its own struct -:397: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #397: FILE: drivers/gpu/drm/i915/intel_device_info.c:81: +#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, yesno(info->display.name)); -:437: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #437: FILE: drivers/gpu/drm/i915/intel_device_info.h:110: +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \ + /* Keep in alphabetical order */ \ func(cursor_needs_physical); \ + func(has_csr); \ + func(has_ddi); \ + func(has_dp_mst); \ + func(has_fbc); \ + func(has_gmch_display); \ + func(has_hotplug); \ + func(has_ipc); \ + func(has_overlay); \ + func(has_psr); \ func(overlay_needs_physical); \ + func(supports_tv); -:437: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #437: FILE: drivers/gpu/drm/i915/intel_device_info.h:110: +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \ + /* Keep in alphabetical order */ \ func(cursor_needs_physical); \ + func(has_csr); \ + func(has_ddi); \ + func(has_dp_mst); \ + func(has_fbc); \ + func(has_gmch_display); \ + func(has_hotplug); \ + func(has_ipc); \ + func(has_overlay); \ + func(has_psr); \ func(overlay_needs_physical); \ + func(supports_tv); -:437: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #437: FILE: drivers/gpu/drm/i915/intel_device_info.h:110: +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \ + /* Keep in alphabetical order */ \ func(cursor_needs_physical); \ + func(has_csr); \ + func(has_ddi); \ + func(has_dp_mst); \ + func(has_fbc); \ + func(has_gmch_display); \ + func(has_hotplug); \ + func(has_ipc); \ + func(has_overlay); \ + func(has_psr); \ func(overlay_needs_physical); \ + func(supports_tv); total: 1 errors, 2 warnings, 1 checks, 433 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza ` (5 preceding siblings ...) 2018-12-03 18:21 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) Patchwork @ 2018-12-03 18:23 ` Patchwork 2018-12-04 8:38 ` ✓ Fi.CI.BAT: success " Patchwork 2018-12-04 10:34 ` ✓ Fi.CI.IGT: " Patchwork 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-12-03 18:23 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) URL : https://patchwork.freedesktop.org/series/53341/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Add HAS_DISPLAY() and use it -drivers/gpu/drm/i915/selftests/../i915_drv.h:3571:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3573:16: warning: expression using sizeof(void) Commit: drm/i915: Move display device info capabilities to its own struct Okay! _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza ` (6 preceding siblings ...) 2018-12-03 18:23 ` ✗ Fi.CI.SPARSE: " Patchwork @ 2018-12-04 8:38 ` Patchwork 2018-12-04 10:34 ` ✓ Fi.CI.IGT: " Patchwork 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-12-04 8:38 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) URL : https://patchwork.freedesktop.org/series/53341/ State : success == Summary == CI Bug Log - changes from CI_DRM_5247 -> Patchwork_11002 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/53341/revisions/2/mbox/ Known issues ------------ Here are the changes found in Patchwork_11002 that come from known issues: ### IGT changes ### #### Possible fixes #### * igt@gem_ctx_create@basic-files: - fi-bsw-n3050: FAIL [fdo#108656] -> PASS * igt@gem_exec_suspend@basic-s3: - fi-cfl-8109u: DMESG-WARN [fdo#107345] -> PASS +3 * igt@i915_selftest@live_evict: - fi-bsw-kefka: DMESG-WARN [fdo#107709] -> PASS [fdo#107345]: https://bugs.freedesktop.org/show_bug.cgi?id=107345 [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709 [fdo#108656]: https://bugs.freedesktop.org/show_bug.cgi?id=108656 Participating hosts (48 -> 42) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-skl-6260u fi-ctg-p8600 Build changes ------------- * Linux: CI_DRM_5247 -> Patchwork_11002 CI_DRM_5247: ff3d336ae5b3ef75e12ed400fd4ccb55701c212a @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_11002: b7a8a1adc388f6c90053f40a3538b9c599a7480f @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == b7a8a1adc388 drm/i915: Move display device info capabilities to its own struct 2ea25bb8bc83 drm/i915: Add HAS_DISPLAY() and use it == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11002/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza ` (7 preceding siblings ...) 2018-12-04 8:38 ` ✓ Fi.CI.BAT: success " Patchwork @ 2018-12-04 10:34 ` Patchwork 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-12-04 10:34 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) URL : https://patchwork.freedesktop.org/series/53341/ State : success == Summary == CI Bug Log - changes from CI_DRM_5247_full -> Patchwork_11002_full ==================================================== Summary ------- **WARNING** Minor unknown changes coming with Patchwork_11002_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_11002_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_11002_full: ### IGT changes ### #### Warnings #### * igt@kms_vblank@pipe-a-wait-forked-hang: - shard-snb: SKIP -> PASS Known issues ------------ Here are the changes found in Patchwork_11002_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ppgtt@blt-vs-render-ctx0: - shard-skl: PASS -> TIMEOUT [fdo#108039] * igt@gem_userptr_blits@readonly-unsync: - shard-skl: NOTRUN -> TIMEOUT [fdo#108887] * igt@kms_busy@extended-modeset-hang-newfb-render-c: - shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] * igt@kms_cursor_crc@cursor-256x256-offscreen: - shard-skl: NOTRUN -> FAIL [fdo#103232] * igt@kms_flip@2x-flip-vs-expired-vblank: - shard-hsw: PASS -> FAIL [fdo#102887] * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: PASS -> FAIL [fdo#105363] * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu: - shard-apl: PASS -> FAIL [fdo#103167] +1 * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt: - shard-skl: NOTRUN -> FAIL [fdo#103167] / [fdo#105682] * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-gtt: - shard-skl: NOTRUN -> FAIL [fdo#105682] +1 * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu: - shard-skl: NOTRUN -> FAIL [fdo#103167] +1 * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] * igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb: - shard-kbl: NOTRUN -> FAIL [fdo#108145] * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb: - shard-skl: NOTRUN -> FAIL [fdo#108145] +2 * igt@kms_plane_multiple@atomic-pipe-c-tiling-y: - shard-apl: PASS -> FAIL [fdo#103166] * igt@kms_vblank@pipe-b-query-forked-busy-hang: - shard-kbl: PASS -> DMESG-WARN [fdo#103313] / [fdo#105345] * igt@pm_backlight@basic-brightness: - {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] +1 * igt@pm_rpm@sysfs-read: - shard-skl: PASS -> INCOMPLETE [fdo#107807] +1 * igt@pm_rps@min-max-config-idle: - shard-apl: PASS -> INCOMPLETE [fdo#103927] #### Possible fixes #### * igt@debugfs_test@read_all_entries_display_off: - shard-skl: INCOMPLETE [fdo#104108] -> PASS * igt@gem_ppgtt@blt-vs-render-ctxn: - shard-kbl: INCOMPLETE [fdo#103665] / [fdo#106023] / [fdo#106887] -> PASS * igt@kms_cursor_crc@cursor-256x256-suspend: - shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS * igt@kms_cursor_crc@cursor-64x21-random: - shard-glk: FAIL [fdo#103232] -> PASS * igt@kms_cursor_crc@cursor-64x64-random: - shard-skl: FAIL [fdo#103232] -> PASS * igt@kms_cursor_crc@cursor-size-change: - shard-apl: FAIL [fdo#103232] -> PASS +1 * igt@kms_flip@nonexisting-fb-interruptible: - {shard-iclb}: DMESG-WARN [fdo#108928] -> PASS * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc: - shard-apl: FAIL [fdo#103167] -> PASS * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: - shard-glk: FAIL [fdo#108145] -> PASS * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: FAIL [fdo#107815] -> PASS +1 * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf: - shard-apl: FAIL [fdo#103166] -> PASS * igt@kms_setmode@basic: - shard-kbl: FAIL [fdo#99912] -> PASS * igt@perf@short-reads: - shard-skl: FAIL [fdo#103183] -> PASS * igt@pm_rpm@gem-mmap-gtt: - shard-skl: INCOMPLETE [fdo#107807] -> PASS +1 #### Warnings #### * igt@i915_suspend@shrink: - shard-kbl: INCOMPLETE [fdo#103665] / [fdo#106886] -> DMESG-WARN [fdo#108784] {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103183]: https://bugs.freedesktop.org/show_bug.cgi?id=103183 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105345]: https://bugs.freedesktop.org/show_bug.cgi?id=105345 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 [fdo#106023]: https://bugs.freedesktop.org/show_bug.cgi?id=106023 [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886 [fdo#106887]: https://bugs.freedesktop.org/show_bug.cgi?id=106887 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815 [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956 [fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784 [fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887 [fdo#108928]: https://bugs.freedesktop.org/show_bug.cgi?id=108928 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_5247 -> Patchwork_11002 CI_DRM_5247: ff3d336ae5b3ef75e12ed400fd4ccb55701c212a @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_11002: b7a8a1adc388f6c90053f40a3538b9c599a7480f @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11002/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-12-04 10:34 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-30 23:20 [PATCH v3 1/2] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza 2018-11-30 23:20 ` [PATCH v3 2/2] drm/i915: Move display device info capabilities to its own struct José Roberto de Souza 2018-11-30 23:32 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it Patchwork 2018-11-30 23:34 ` ✗ Fi.CI.SPARSE: " Patchwork 2018-11-30 23:52 ` ✓ Fi.CI.BAT: success " Patchwork 2018-12-01 18:32 ` ✗ Fi.CI.IGT: failure " Patchwork 2018-12-03 23:00 ` Souza, Jose 2018-12-03 18:21 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Add HAS_DISPLAY() and use it (rev2) Patchwork 2018-12-03 18:23 ` ✗ Fi.CI.SPARSE: " Patchwork 2018-12-04 8:38 ` ✓ Fi.CI.BAT: success " Patchwork 2018-12-04 10:34 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox