From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC
Date: Fri, 14 Dec 2018 11:49:26 +0200 [thread overview]
Message-ID: <20181214094926.GT2469@lahna.fi.intel.com> (raw)
In-Reply-To: <20181213153533.10949-2-hdegoede@redhat.com>
On Thu, Dec 13, 2018 at 04:35:32PM +0100, Hans de Goede wrote:
> Implement the exec_mipi_pmic_seq_element callback for the CHT Whiskey Cove
> PMIC.
>
> On some CHT devices this fixes the LCD panel not lighting up when it was
> not initialized by the GOP, because an external monitor was plugged in and
> the GOP initialized only the external monitor.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
One question see below, but regardless
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Changes in v4:
> -The decoding of the raw data of the PMIC MIPI sequence element is now done
> in our caller, so drop this and adjust the callback prototype to accept
> the decoded addresses, value and mask
>
> Changes in v3:
> -Use hex values for out of range checks
> -Make intel_cht_wc_exec_mipi_pmic_seq_element return errors
>
> Changes in v2:
> -Interpret data passed to the PMIC MIPI elements according to the docs
> instead of my own reverse engineered interpretation
> ---
> drivers/acpi/pmic/intel_pmic_chtwc.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
> index 078b0448f30a..c5037c5c5219 100644
> --- a/drivers/acpi/pmic/intel_pmic_chtwc.c
> +++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/intel_soc_pmic.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> +#include <asm/unaligned.h>
Why is this include needed?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-14 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:35 [PATCH v4 1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements Hans de Goede
2018-12-13 15:35 ` [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC Hans de Goede
2018-12-14 9:49 ` Mika Westerberg [this message]
2018-12-14 10:48 ` Hans de Goede
2018-12-14 11:04 ` Mika Westerberg
2018-12-14 11:52 ` Rafael J. Wysocki
2018-12-13 15:35 ` [PATCH v4 3/3] drm/i915/intel_dsi_vbt: Add support for PMIC MIPI sequences Hans de Goede
2018-12-13 16:05 ` ✗ Fi.CI.BAT: failure for series starting with [v4,1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements Patchwork
2018-12-13 16:26 ` Hans de Goede
2018-12-14 9:47 ` [PATCH v4 1/3] " Mika Westerberg
2018-12-20 11:26 ` ✓ Fi.CI.BAT: success for series starting with [v4,1/3] " Patchwork
2018-12-21 11:06 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214094926.GT2469@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox