From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC
Date: Fri, 14 Dec 2018 13:04:57 +0200 [thread overview]
Message-ID: <20181214110457.GU2469@lahna.fi.intel.com> (raw)
In-Reply-To: <78611327-6c8d-2fe5-e3f9-af0aec9d02f7@redhat.com>
On Fri, Dec 14, 2018 at 11:48:35AM +0100, Hans de Goede wrote:
> > > +#include <asm/unaligned.h>
> >
> > Why is this include needed?
>
> It is no longer needed in v4, since the parsing of the raw
> MIPI sequence data (which needed this include) has been moved
> to the i915 VBT code now.
>
> I've dropped this from my local version of the patch.
OK.
> Note sure if you (Mika) are the right person to ask, but in the
> coverletter of v1 I suggested merging all 3 patches through the i915 tree
> since the drivers/acpi/pmic/intel_pmic* files typically do
> not see all that churn. If I can get an Ack from you or
> Rafael for that then I can push the version with the include
> dropped to drm-next (through drm-intel-next-queued) myself
> once the 3th patch also has been acked.
I guess it is up to Rafael whether my ack is enough but here it is for
both patches,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-14 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:35 [PATCH v4 1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements Hans de Goede
2018-12-13 15:35 ` [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC Hans de Goede
2018-12-14 9:49 ` Mika Westerberg
2018-12-14 10:48 ` Hans de Goede
2018-12-14 11:04 ` Mika Westerberg [this message]
2018-12-14 11:52 ` Rafael J. Wysocki
2018-12-13 15:35 ` [PATCH v4 3/3] drm/i915/intel_dsi_vbt: Add support for PMIC MIPI sequences Hans de Goede
2018-12-13 16:05 ` ✗ Fi.CI.BAT: failure for series starting with [v4,1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements Patchwork
2018-12-13 16:26 ` Hans de Goede
2018-12-14 9:47 ` [PATCH v4 1/3] " Mika Westerberg
2018-12-20 11:26 ` ✓ Fi.CI.BAT: success for series starting with [v4,1/3] " Patchwork
2018-12-21 11:06 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214110457.GU2469@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox