Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Lyude Paul <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev2)
Date: Thu, 20 Dec 2018 00:39:10 -0000	[thread overview]
Message-ID: <20181220003910.8970.75157@emeril.freedesktop.org> (raw)
In-Reply-To: <20181220001959.12486-1-lyude@redhat.com>

== Series Details ==

Series: MST refcounting/atomic helpers cleanup (rev2)
URL   : https://patchwork.freedesktop.org/series/54030/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f950c3fa3447 drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends
-:84: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#84: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:990:
+			rmstb = drm_dp_mst_topology_get_mstb_validated_locked(

-:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#102: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1006:
+		rmstb = drm_dp_mst_topology_get_mstb_validated_locked(

-:150: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#150: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1373:
+			mstb_child = drm_dp_mst_topology_get_mstb_validated(

total: 0 errors, 0 warnings, 3 checks, 399 lines checked
5e53f025958a drm/dp_mst: Introduce new refcounting scheme for mstbs and ports
-:22: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 91a25e463130 ("drm/dp/mst: deallocate payload on port destruction")'
#22: 
91a25e463130 ("drm/dp/mst: deallocate payload on port destruction")

-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27: 
263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")

-:27: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")'
#27: 
263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")

-:46: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c54c7374ff44 ("drm/dp_mst: Skip validating ports during destruction, just ref")'
#46: 
c54c7374ff44 ("drm/dp_mst: Skip validating ports during destruction, just ref")

-:51: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")'
#51: 
9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")

-:129: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#129: 
new file mode 100644

-:511: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#511: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:988:
+	DRM_DEBUG("mstb %p (%d)\n", mstb, kref_read(&mstb->malloc_kref)-1);
 	                                                               ^

-:562: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#562: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1039:
+	DRM_DEBUG("port %p (%d)\n", port, kref_read(&port->malloc_kref)-1);
 	                                                               ^

-:679: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#679: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1149:
+	DRM_DEBUG("mstb %p (%d)\n", mstb, kref_read(&mstb->topology_kref)-1);
 	                                                                 ^

-:779: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#779: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1273:
+	DRM_DEBUG("port %p (%d)\n", port, kref_read(&port->topology_kref)-1);
 	                                                                 ^

-:832: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#832: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1327:
+			mport = drm_dp_mst_topology_get_port_validated_locked(

-:846: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#846: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1344:
+		rport = drm_dp_mst_topology_get_port_validated_locked(

-:1012: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1012: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2058:
+			if (drm_dp_mst_topology_try_get_mstb(rmstb)) {
[...]
+			} else {
[...]

total: 4 errors, 3 warnings, 6 checks, 974 lines checked
a4378c0bb6f7 drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails
3b35c50d8406 drm/dp_mst: Stop releasing VCPI when removing ports from topology
859904901106 drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs
-:97: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#97: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2274:
+				port = drm_dp_mst_topology_get_port_validated(

total: 0 errors, 0 warnings, 1 checks, 124 lines checked
514f014c71f3 drm/i915: Keep malloc references to MST ports
3c24606c381a drm/amdgpu/display: Keep malloc ref to MST port
6d9550106577 drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()
371889f7b60e drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
f0d136a0f492 drm/nouveau: Keep malloc references to MST ports
e4743c105b87 drm/nouveau: Stop unsetting mstc->port, use malloc refs
d242f9257a4b drm/nouveau: Grab payload lock in nv50_msto_payload()
260fc11b1f9a drm/dp_mst: Add some atomic state iterator macros
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:710:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:710:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:112: WARNING:LONG_LINE: line over 100 characters
#112: FILE: include/drm/drm_dp_mst_helper.h:712:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:727:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:727:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:129: WARNING:LONG_LINE: line over 100 characters
#129: FILE: include/drm/drm_dp_mst_helper.h:729:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:745:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:745:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:147: WARNING:LONG_LINE: line over 100 characters
#147: FILE: include/drm/drm_dp_mst_helper.h:747:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

total: 0 errors, 3 warnings, 6 checks, 120 lines checked
945779405902 drm/dp_mst: Start tracking per-port VCPI allocations
-:388: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#388: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:3672:
+
+	}

total: 0 errors, 0 warnings, 1 checks, 464 lines checked
4d20dde05c36 drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
b6b2a3fc3076 drm/nouveau: Use atomic VCPI helpers for MST

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-12-20  0:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20  0:19 [PATCH v2 00/16] MST refcounting/atomic helpers cleanup Lyude Paul
2018-12-20  0:19 ` [PATCH v2 01/16] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends Lyude Paul
     [not found]   ` <20181220001959.12486-2-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-20  9:09     ` Daniel Vetter
2018-12-20  0:19 ` [PATCH v2 02/16] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports Lyude Paul
2018-12-20  0:19 ` [PATCH v2 06/16] drm/i915: Keep malloc references to MST ports Lyude Paul
     [not found]   ` <20181220001959.12486-7-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-20  9:10     ` Daniel Vetter
2018-12-20  0:19 ` [PATCH v2 09/16] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup() Lyude Paul
2018-12-20  0:19 ` [PATCH v2 12/16] drm/nouveau: Grab payload lock in nv50_msto_payload() Lyude Paul
2018-12-20  0:19 ` [PATCH v2 13/16] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
     [not found] ` <20181220001959.12486-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-20  0:19   ` [PATCH v2 03/16] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails Lyude Paul
     [not found]     ` <20181220001959.12486-4-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-08 19:16       ` Wentland, Harry
2018-12-20  0:19   ` [PATCH v2 04/16] drm/dp_mst: Stop releasing VCPI when removing ports from topology Lyude Paul
2019-01-08 19:27     ` Wentland, Harry
2018-12-20  0:19   ` [PATCH v2 05/16] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs Lyude Paul
2019-01-08 19:27     ` Wentland, Harry
2018-12-20  0:19   ` [PATCH v2 07/16] drm/amdgpu/display: Keep malloc ref to MST port Lyude Paul
     [not found]     ` <20181220001959.12486-8-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-08 19:38       ` Wentland, Harry
2018-12-20  0:19   ` [PATCH v2 08/16] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector() Lyude Paul
2018-12-20  0:19   ` [PATCH v2 10/16] drm/nouveau: Keep malloc references to MST ports Lyude Paul
2018-12-20  0:19   ` [PATCH v2 11/16] drm/nouveau: Stop unsetting mstc->port, use malloc refs Lyude Paul
2018-12-20  0:19   ` [PATCH v2 14/16] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
2018-12-20  0:19   ` [PATCH v2 15/16] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
2018-12-20  0:20 ` [PATCH v2 16/16] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2018-12-20  0:39 ` Patchwork [this message]
2018-12-20  0:43 ` ✗ Fi.CI.SPARSE: warning for MST refcounting/atomic helpers cleanup (rev2) Patchwork
2018-12-20  0:57 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181220003910.8970.75157@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox