Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Wentland, Harry" <Harry.Wentland@amd.com>
To: Lyude Paul <lyude@redhat.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: David Airlie <airlied@redhat.com>, "Zuo, Jerry" <Jerry.Zuo@amd.com>
Subject: Re: [PATCH v2 04/16] drm/dp_mst: Stop releasing VCPI when removing ports from topology
Date: Tue, 8 Jan 2019 19:27:38 +0000	[thread overview]
Message-ID: <8f41a65a-2dcd-8264-4155-cc069068f677@amd.com> (raw)
In-Reply-To: <20181220001959.12486-5-lyude@redhat.com>

On 2018-12-19 7:19 p.m., Lyude Paul wrote:
> This has never actually worked, and isn't needed anyway: the driver's
> always going to try to deallocate VCPI when it tears down the display
> that the VCPI belongs to.
> 
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Reviewed-by: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@redhat.com>
> Cc: Jerry Zuo <Jerry.Zuo@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Juston Li <juston.li@intel.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 356a95aba2d8..ef8637f37564 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1175,8 +1175,6 @@ static void drm_dp_destroy_port(struct kref *kref)
>  	struct drm_dp_mst_topology_mgr *mgr = port->mgr;
>  
>  	if (!port->input) {
> -		port->vcpi.num_slots = 0;
> -
>  		kfree(port->cached_edid);
>  
>  		/*
> @@ -3491,12 +3489,6 @@ static void drm_dp_destroy_connector_work(struct work_struct *work)
>  		drm_dp_port_teardown_pdt(port, port->pdt);
>  		port->pdt = DP_PEER_DEVICE_NONE;
>  
> -		if (!port->input && port->vcpi.vcpi > 0) {
> -			drm_dp_mst_reset_vcpi_slots(mgr, port);
> -			drm_dp_update_payload_part1(mgr);
> -			drm_dp_mst_put_payload_id(mgr, port->vcpi.vcpi);
> -		}
> -
>  		drm_dp_mst_put_port_malloc(port);
>  		send_hotplug = true;
>  	}
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-01-08 19:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20  0:19 [PATCH v2 00/16] MST refcounting/atomic helpers cleanup Lyude Paul
2018-12-20  0:19 ` [PATCH v2 01/16] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends Lyude Paul
     [not found]   ` <20181220001959.12486-2-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-20  9:09     ` Daniel Vetter
2018-12-20  0:19 ` [PATCH v2 02/16] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports Lyude Paul
2018-12-20  0:19 ` [PATCH v2 06/16] drm/i915: Keep malloc references to MST ports Lyude Paul
     [not found]   ` <20181220001959.12486-7-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-20  9:10     ` Daniel Vetter
2018-12-20  0:19 ` [PATCH v2 09/16] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup() Lyude Paul
2018-12-20  0:19 ` [PATCH v2 12/16] drm/nouveau: Grab payload lock in nv50_msto_payload() Lyude Paul
2018-12-20  0:19 ` [PATCH v2 13/16] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
     [not found] ` <20181220001959.12486-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-20  0:19   ` [PATCH v2 03/16] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails Lyude Paul
     [not found]     ` <20181220001959.12486-4-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-08 19:16       ` Wentland, Harry
2018-12-20  0:19   ` [PATCH v2 04/16] drm/dp_mst: Stop releasing VCPI when removing ports from topology Lyude Paul
2019-01-08 19:27     ` Wentland, Harry [this message]
2018-12-20  0:19   ` [PATCH v2 05/16] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs Lyude Paul
2019-01-08 19:27     ` Wentland, Harry
2018-12-20  0:19   ` [PATCH v2 07/16] drm/amdgpu/display: Keep malloc ref to MST port Lyude Paul
     [not found]     ` <20181220001959.12486-8-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-08 19:38       ` Wentland, Harry
2018-12-20  0:19   ` [PATCH v2 08/16] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector() Lyude Paul
2018-12-20  0:19   ` [PATCH v2 10/16] drm/nouveau: Keep malloc references to MST ports Lyude Paul
2018-12-20  0:19   ` [PATCH v2 11/16] drm/nouveau: Stop unsetting mstc->port, use malloc refs Lyude Paul
2018-12-20  0:19   ` [PATCH v2 14/16] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
2018-12-20  0:19   ` [PATCH v2 15/16] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
2018-12-20  0:20 ` [PATCH v2 16/16] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2018-12-20  0:39 ` ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev2) Patchwork
2018-12-20  0:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-12-20  0:57 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f41a65a-2dcd-8264-4155-cc069068f677@amd.com \
    --to=harry.wentland@amd.com \
    --cc=Jerry.Zuo@amd.com \
    --cc=airlied@redhat.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox