public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Tvrtko Ursulin <tursulin@ursulin.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev10)
Date: Tue, 08 Jan 2019 13:33:39 -0000	[thread overview]
Message-ID: <20190108133339.28503.89476@emeril.freedesktop.org> (raw)
In-Reply-To: <20190108112252.29002-1-tvrtko.ursulin@linux.intel.com>

== Series Details ==

Series: Per context dynamic (sub)slice power-gating (rev10)
URL   : https://patchwork.freedesktop.org/series/48194/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a76b08127cd7 drm/i915/execlists: Move RPCS setup to context pin
db8cb3bf4b10 drm/i915: Record the sseu configuration per-context & engine
266745f8b96a drm/i915/perf: lock powergating configuration to default when active
6bd9facb9663 drm/i915: Add timeline barrier support
993439fa7f8f drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)
-:47: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#47: 
v2: Fix offset of CTX_R_PWR_CLK_STATE in intel_lr_context_set_sseu() (Lionel)

-:505: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->min_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#505: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

-:505: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->max_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#505: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

total: 0 errors, 1 warnings, 2 checks, 479 lines checked
c3be906d1b25 drm/i915/icl: Support co-existence between per-context SSEU and OA
ee9008e736df drm/i915/selftests: Context SSEU reconfiguration tests
-:226: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#226: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:784:
+int

-:408: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#408: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:966:
+			return -EINVAL;
+		} else {

-:415: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#415: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:973:
+
+}

total: 0 errors, 2 warnings, 1 checks, 555 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-01-08 13:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 11:22 [PATCH 0/7] Per context dynamic (sub)slice power-gating Tvrtko Ursulin
2019-01-08 11:22 ` [PATCH 1/7] drm/i915/execlists: Move RPCS setup to context pin Tvrtko Ursulin
2019-01-08 13:11   ` Joonas Lahtinen
2019-01-08 11:22 ` [PATCH 2/7] drm/i915: Record the sseu configuration per-context & engine Tvrtko Ursulin
2019-01-08 13:17   ` Joonas Lahtinen
2019-01-08 11:22 ` [PATCH 3/7] drm/i915/perf: lock powergating configuration to default when active Tvrtko Ursulin
2019-01-08 13:40   ` Joonas Lahtinen
2019-01-08 11:22 ` [PATCH 4/7] drm/i915: Add timeline barrier support Tvrtko Ursulin
2019-01-08 11:22 ` [PATCH 5/7] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only) Tvrtko Ursulin
2019-01-08 14:22   ` Joonas Lahtinen
2019-01-08 14:35     ` Tvrtko Ursulin
2019-01-08 14:57       ` Chris Wilson
2019-01-08 11:22 ` [PATCH 6/7] drm/i915/icl: Support co-existence between per-context SSEU and OA Tvrtko Ursulin
2019-01-08 13:59   ` Joonas Lahtinen
2019-01-08 11:22 ` [PATCH 7/7] drm/i915/selftests: Context SSEU reconfiguration tests Tvrtko Ursulin
2019-01-08 12:50   ` Chris Wilson
2019-01-08 13:58   ` Joonas Lahtinen
2019-01-08 14:38     ` Tvrtko Ursulin
2019-01-08 13:33 ` Patchwork [this message]
2019-01-08 13:36 ` ✗ Fi.CI.SPARSE: warning for Per context dynamic (sub)slice power-gating (rev10) Patchwork
2019-01-08 13:52 ` ✓ Fi.CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108133339.28503.89476@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox