* [PATCH] drm/i915/cfl: Adding another PCI Device ID.
@ 2019-02-01 5:38 Rodrigo Vivi
2019-02-01 6:15 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (6 more replies)
0 siblings, 7 replies; 11+ messages in thread
From: Rodrigo Vivi @ 2019-02-01 5:38 UTC (permalink / raw)
To: intel-gfx
While cross checking PCI IDs from Intel Media SDK
and kernel Dmitry noticed this gap. So we checked the
spec and this new ID had been recently added.
Reported-by: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com>
Cc: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
include/drm/i915_pciids.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index df72be7e8b88..d2fad7b0fcf6 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -394,6 +394,9 @@
INTEL_VGA_DEVICE(0x3E9A, info) /* SRV GT2 */
/* CFL H */
+#define INTEL_CFL_H_GT1_IDS(info) \
+ INTEL_VGA_DEVICE(0x3E9C, info)
+
#define INTEL_CFL_H_GT2_IDS(info) \
INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
@@ -426,6 +429,7 @@
#define INTEL_CFL_IDS(info) \
INTEL_CFL_S_GT1_IDS(info), \
INTEL_CFL_S_GT2_IDS(info), \
+ INTEL_CFL_H_GT1_IDS(info), \
INTEL_CFL_H_GT2_IDS(info), \
INTEL_CFL_U_GT2_IDS(info), \
INTEL_CFL_U_GT3_IDS(info), \
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/cfl: Adding another PCI Device ID. 2019-02-01 5:38 [PATCH] drm/i915/cfl: Adding another PCI Device ID Rodrigo Vivi @ 2019-02-01 6:15 ` Patchwork 2019-02-01 6:36 ` ✓ Fi.CI.BAT: success " Patchwork ` (5 subsequent siblings) 6 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-02-01 6:15 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: drm/i915/cfl: Adding another PCI Device ID. URL : https://patchwork.freedesktop.org/series/56075/ State : warning == Summary == $ dim checkpatch origin/drm-tip ab594f4fdd62 drm/i915/cfl: Adding another PCI Device ID. -:13: WARNING:BAD_SIGN_OFF: email address 'Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com>' might be better as 'Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>' #13: Reported-by: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> -:14: WARNING:BAD_SIGN_OFF: email address 'Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com>' might be better as 'Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>' #14: Cc: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> total: 0 errors, 2 warnings, 0 checks, 16 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/cfl: Adding another PCI Device ID. 2019-02-01 5:38 [PATCH] drm/i915/cfl: Adding another PCI Device ID Rodrigo Vivi 2019-02-01 6:15 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2019-02-01 6:36 ` Patchwork 2019-02-01 9:42 ` ✓ Fi.CI.IGT: " Patchwork ` (4 subsequent siblings) 6 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-02-01 6:36 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: drm/i915/cfl: Adding another PCI Device ID. URL : https://patchwork.freedesktop.org/series/56075/ State : success == Summary == CI Bug Log - changes from CI_DRM_5522 -> Patchwork_12116 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/56075/revisions/1/mbox/ Known issues ------------ Here are the changes found in Patchwork_12116 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@userptr: - fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965] * igt@gem_ctx_create@basic-files: - fi-kbl-7560u: PASS -> INCOMPLETE [fdo#103665] * igt@i915_selftest@live_execlists: - fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] * igt@i915_selftest@live_hangcheck: - fi-glk-j4005: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133] * igt@kms_busy@basic-flip-a: - fi-gdg-551: PASS -> FAIL [fdo#103182] * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence: - fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] #### Possible fixes #### * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: - fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: - fi-kbl-7567u: {SKIP} [fdo#109271] -> PASS +1 * igt@prime_vgem@basic-fence-flip: - fi-kbl-7500u: {SKIP} [fdo#109271] -> PASS +33 {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622 [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (49 -> 44) ------------------------------ Missing (5): fi-kbl-soraka fi-ilk-m540 fi-bsw-cyan fi-icl-u2 fi-ctg-p8600 Build changes ------------- * Linux: CI_DRM_5522 -> Patchwork_12116 CI_DRM_5522: 3f287cb6d4ae4689eb7c53e4c25f0fba3df16438 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4802: 4049adf01014af077df2174def4fadf7cecb066e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12116: ab594f4fdd62f7e043b94092a218ba1b52af293d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == ab594f4fdd62 drm/i915/cfl: Adding another PCI Device ID. == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12116/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/cfl: Adding another PCI Device ID. 2019-02-01 5:38 [PATCH] drm/i915/cfl: Adding another PCI Device ID Rodrigo Vivi 2019-02-01 6:15 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2019-02-01 6:36 ` ✓ Fi.CI.BAT: success " Patchwork @ 2019-02-01 9:42 ` Patchwork 2019-02-01 18:01 ` [PATCH] " Souza, Jose ` (3 subsequent siblings) 6 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-02-01 9:42 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: drm/i915/cfl: Adding another PCI Device ID. URL : https://patchwork.freedesktop.org/series/56075/ State : success == Summary == CI Bug Log - changes from CI_DRM_5522_full -> Patchwork_12116_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_12116_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@reset-stress: - shard-snb: PASS -> INCOMPLETE [fdo#105411] * igt@gem_userptr_blits@map-fixed-invalidate-busy: - shard-apl: PASS -> INCOMPLETE [fdo#103927] * igt@kms_cursor_crc@cursor-256x256-onscreen: - shard-apl: PASS -> FAIL [fdo#103232] * igt@kms_cursor_crc@cursor-256x256-sliding: - shard-glk: PASS -> FAIL [fdo#103232] * igt@kms_plane_multiple@atomic-pipe-b-tiling-y: - shard-glk: PASS -> FAIL [fdo#103166] +1 * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf: - shard-apl: PASS -> FAIL [fdo#103166] +1 #### Possible fixes #### * igt@gem_exec_blt@cold: - shard-glk: DMESG-WARN [fdo#105763] / [fdo#106538] -> PASS * igt@kms_cursor_crc@cursor-256x85-random: - shard-apl: FAIL [fdo#103232] -> PASS * igt@kms_plane@plane-position-covered-pipe-b-planes: - shard-glk: FAIL [fdo#103166] -> PASS +1 * igt@kms_plane_multiple@atomic-pipe-b-tiling-none: - shard-apl: FAIL [fdo#103166] -> PASS +2 * igt@kms_setmode@basic: - shard-hsw: FAIL [fdo#99912] -> PASS {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763 [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (6 -> 4) ------------------------------ Missing (2): shard-skl shard-iclb Build changes ------------- * Linux: CI_DRM_5522 -> Patchwork_12116 CI_DRM_5522: 3f287cb6d4ae4689eb7c53e4c25f0fba3df16438 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4802: 4049adf01014af077df2174def4fadf7cecb066e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12116: ab594f4fdd62f7e043b94092a218ba1b52af293d @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12116/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915/cfl: Adding another PCI Device ID. 2019-02-01 5:38 [PATCH] drm/i915/cfl: Adding another PCI Device ID Rodrigo Vivi ` (2 preceding siblings ...) 2019-02-01 9:42 ` ✓ Fi.CI.IGT: " Patchwork @ 2019-02-01 18:01 ` Souza, Jose 2019-02-01 23:50 ` Rodrigo Vivi 2019-02-02 0:02 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/cfl: Adding another PCI Device ID. (rev2) Patchwork ` (2 subsequent siblings) 6 siblings, 1 reply; 11+ messages in thread From: Souza, Jose @ 2019-02-01 18:01 UTC (permalink / raw) To: intel-gfx@lists.freedesktop.org, Vivi, Rodrigo [-- Attachment #1.1: Type: text/plain, Size: 1362 bytes --] On Thu, 2019-01-31 at 21:38 -0800, Rodrigo Vivi wrote: > While cross checking PCI IDs from Intel Media SDK > and kernel Dmitry noticed this gap. So we checked the > spec and this new ID had been recently added. > > Reported-by: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> > Cc: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> > Cc: José Roberto de Souza <jose.souza@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > include/drm/i915_pciids.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index df72be7e8b88..d2fad7b0fcf6 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -394,6 +394,9 @@ > INTEL_VGA_DEVICE(0x3E9A, info) /* SRV GT2 */ > > /* CFL H */ > +#define INTEL_CFL_H_GT1_IDS(info) \ > + INTEL_VGA_DEVICE(0x3E9C, info) > + > #define INTEL_CFL_H_GT2_IDS(info) \ > INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \ > INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ > @@ -426,6 +429,7 @@ > #define INTEL_CFL_IDS(info) \ > INTEL_CFL_S_GT1_IDS(info), \ > INTEL_CFL_S_GT2_IDS(info), \ > + INTEL_CFL_H_GT1_IDS(info), \ > INTEL_CFL_H_GT2_IDS(info), \ > INTEL_CFL_U_GT2_IDS(info), \ > INTEL_CFL_U_GT3_IDS(info), \ Missing add INTEL_CFL_H_GT1_IDS to pciidlist in i915_pci.c [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] drm/i915/cfl: Adding another PCI Device ID. 2019-02-01 18:01 ` [PATCH] " Souza, Jose @ 2019-02-01 23:50 ` Rodrigo Vivi 2019-02-02 0:09 ` Souza, Jose 0 siblings, 1 reply; 11+ messages in thread From: Rodrigo Vivi @ 2019-02-01 23:50 UTC (permalink / raw) To: intel-gfx While cross checking PCI IDs from Intel Media SDK and kernel Dmitry noticed this gap. So we checked the spec and this new ID had been recently added. v2: Adding new H_GT1 entry to i915_pci.c (Jose) Reported-by: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> Cc: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> Cc: José Roberto de Souza <jose.souza@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/i915_pci.c | 1 + include/drm/i915_pciids.h | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 17f5a605b0b3..5d05572c9ff4 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -713,6 +713,7 @@ static const struct pci_device_id pciidlist[] = { INTEL_AML_KBL_GT2_IDS(&intel_kabylake_gt2_info), INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info), INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info), + INTEL_CFL_H_GT1_IDS(&intel_coffeelake_gt1_info), INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info), INTEL_CFL_U_GT2_IDS(&intel_coffeelake_gt2_info), INTEL_CFL_U_GT3_IDS(&intel_coffeelake_gt3_info), diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index df72be7e8b88..d2fad7b0fcf6 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -394,6 +394,9 @@ INTEL_VGA_DEVICE(0x3E9A, info) /* SRV GT2 */ /* CFL H */ +#define INTEL_CFL_H_GT1_IDS(info) \ + INTEL_VGA_DEVICE(0x3E9C, info) + #define INTEL_CFL_H_GT2_IDS(info) \ INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \ INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ @@ -426,6 +429,7 @@ #define INTEL_CFL_IDS(info) \ INTEL_CFL_S_GT1_IDS(info), \ INTEL_CFL_S_GT2_IDS(info), \ + INTEL_CFL_H_GT1_IDS(info), \ INTEL_CFL_H_GT2_IDS(info), \ INTEL_CFL_U_GT2_IDS(info), \ INTEL_CFL_U_GT3_IDS(info), \ -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915/cfl: Adding another PCI Device ID. 2019-02-01 23:50 ` Rodrigo Vivi @ 2019-02-02 0:09 ` Souza, Jose 2019-02-02 8:23 ` Rodrigo Vivi 0 siblings, 1 reply; 11+ messages in thread From: Souza, Jose @ 2019-02-02 0:09 UTC (permalink / raw) To: intel-gfx@lists.freedesktop.org, Vivi, Rodrigo [-- Attachment #1.1: Type: text/plain, Size: 2129 bytes --] On Fri, 2019-02-01 at 15:50 -0800, Rodrigo Vivi wrote: > While cross checking PCI IDs from Intel Media SDK > and kernel Dmitry noticed this gap. So we checked the > spec and this new ID had been recently added. > > v2: Adding new H_GT1 entry to i915_pci.c (Jose) > Reviewed-by: José Roberto de Souza <jose.souza@intel.com> > Reported-by: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> > Cc: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> > Cc: José Roberto de Souza <jose.souza@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/i915_pci.c | 1 + > include/drm/i915_pciids.h | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c > b/drivers/gpu/drm/i915/i915_pci.c > index 17f5a605b0b3..5d05572c9ff4 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -713,6 +713,7 @@ static const struct pci_device_id pciidlist[] = { > INTEL_AML_KBL_GT2_IDS(&intel_kabylake_gt2_info), > INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info), > INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info), > + INTEL_CFL_H_GT1_IDS(&intel_coffeelake_gt1_info), > INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info), > INTEL_CFL_U_GT2_IDS(&intel_coffeelake_gt2_info), > INTEL_CFL_U_GT3_IDS(&intel_coffeelake_gt3_info), > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index df72be7e8b88..d2fad7b0fcf6 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -394,6 +394,9 @@ > INTEL_VGA_DEVICE(0x3E9A, info) /* SRV GT2 */ > > /* CFL H */ > +#define INTEL_CFL_H_GT1_IDS(info) \ > + INTEL_VGA_DEVICE(0x3E9C, info) > + > #define INTEL_CFL_H_GT2_IDS(info) \ > INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \ > INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ > @@ -426,6 +429,7 @@ > #define INTEL_CFL_IDS(info) \ > INTEL_CFL_S_GT1_IDS(info), \ > INTEL_CFL_S_GT2_IDS(info), \ > + INTEL_CFL_H_GT1_IDS(info), \ > INTEL_CFL_H_GT2_IDS(info), \ > INTEL_CFL_U_GT2_IDS(info), \ > INTEL_CFL_U_GT3_IDS(info), \ [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915/cfl: Adding another PCI Device ID. 2019-02-02 0:09 ` Souza, Jose @ 2019-02-02 8:23 ` Rodrigo Vivi 0 siblings, 0 replies; 11+ messages in thread From: Rodrigo Vivi @ 2019-02-02 8:23 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx@lists.freedesktop.org On Sat, Feb 02, 2019 at 12:09:47AM +0000, Souza, Jose wrote: > On Fri, 2019-02-01 at 15:50 -0800, Rodrigo Vivi wrote: > > While cross checking PCI IDs from Intel Media SDK > > and kernel Dmitry noticed this gap. So we checked the > > spec and this new ID had been recently added. > > > > v2: Adding new H_GT1 entry to i915_pci.c (Jose) > > > > Reviewed-by: José Roberto de Souza <jose.souza@intel.com> pushed, thanks. > > > Reported-by: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> > > Cc: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> > > Cc: José Roberto de Souza <jose.souza@intel.com> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > --- > > drivers/gpu/drm/i915/i915_pci.c | 1 + > > include/drm/i915_pciids.h | 4 ++++ > > 2 files changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c > > b/drivers/gpu/drm/i915/i915_pci.c > > index 17f5a605b0b3..5d05572c9ff4 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -713,6 +713,7 @@ static const struct pci_device_id pciidlist[] = { > > INTEL_AML_KBL_GT2_IDS(&intel_kabylake_gt2_info), > > INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info), > > INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info), > > + INTEL_CFL_H_GT1_IDS(&intel_coffeelake_gt1_info), > > INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info), > > INTEL_CFL_U_GT2_IDS(&intel_coffeelake_gt2_info), > > INTEL_CFL_U_GT3_IDS(&intel_coffeelake_gt3_info), > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > > index df72be7e8b88..d2fad7b0fcf6 100644 > > --- a/include/drm/i915_pciids.h > > +++ b/include/drm/i915_pciids.h > > @@ -394,6 +394,9 @@ > > INTEL_VGA_DEVICE(0x3E9A, info) /* SRV GT2 */ > > > > /* CFL H */ > > +#define INTEL_CFL_H_GT1_IDS(info) \ > > + INTEL_VGA_DEVICE(0x3E9C, info) > > + > > #define INTEL_CFL_H_GT2_IDS(info) \ > > INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \ > > INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ > > @@ -426,6 +429,7 @@ > > #define INTEL_CFL_IDS(info) \ > > INTEL_CFL_S_GT1_IDS(info), \ > > INTEL_CFL_S_GT2_IDS(info), \ > > + INTEL_CFL_H_GT1_IDS(info), \ > > INTEL_CFL_H_GT2_IDS(info), \ > > INTEL_CFL_U_GT2_IDS(info), \ > > INTEL_CFL_U_GT3_IDS(info), \ > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/cfl: Adding another PCI Device ID. (rev2) 2019-02-01 5:38 [PATCH] drm/i915/cfl: Adding another PCI Device ID Rodrigo Vivi ` (3 preceding siblings ...) 2019-02-01 18:01 ` [PATCH] " Souza, Jose @ 2019-02-02 0:02 ` Patchwork 2019-02-02 0:24 ` ✓ Fi.CI.BAT: success " Patchwork 2019-02-02 1:30 ` ✓ Fi.CI.IGT: " Patchwork 6 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-02-02 0:02 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: drm/i915/cfl: Adding another PCI Device ID. (rev2) URL : https://patchwork.freedesktop.org/series/56075/ State : warning == Summary == $ dim checkpatch origin/drm-tip d78761758c42 drm/i915/cfl: Adding another PCI Device ID. -:15: WARNING:BAD_SIGN_OFF: email address 'Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com>' might be better as 'Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>' #15: Reported-by: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> -:16: WARNING:BAD_SIGN_OFF: email address 'Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com>' might be better as 'Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>' #16: Cc: Dmitry Rogozhkin<dmitry.v.rogozhkin@intel.com> total: 0 errors, 2 warnings, 0 checks, 23 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/cfl: Adding another PCI Device ID. (rev2) 2019-02-01 5:38 [PATCH] drm/i915/cfl: Adding another PCI Device ID Rodrigo Vivi ` (4 preceding siblings ...) 2019-02-02 0:02 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/cfl: Adding another PCI Device ID. (rev2) Patchwork @ 2019-02-02 0:24 ` Patchwork 2019-02-02 1:30 ` ✓ Fi.CI.IGT: " Patchwork 6 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-02-02 0:24 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: drm/i915/cfl: Adding another PCI Device ID. (rev2) URL : https://patchwork.freedesktop.org/series/56075/ State : success == Summary == CI Bug Log - changes from CI_DRM_5526 -> Patchwork_12121 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/56075/revisions/2/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_12121: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@kms_frontbuffer_tracking@basic: - {fi-icl-y}: NOTRUN -> {SKIP} +1 Known issues ------------ Here are the changes found in Patchwork_12121 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_execlists: - fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] * igt@kms_busy@basic-flip-a: - fi-gdg-551: PASS -> FAIL [fdo#103182] +1 * igt@pm_rpm@basic-rte: - fi-bsw-kefka: PASS -> FAIL [fdo#108800] #### Possible fixes #### * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a: - fi-byt-clapper: FAIL [fdo#107362] -> PASS {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622 [fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527 [fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528 [fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530 Participating hosts (48 -> 45) ------------------------------ Additional (2): fi-icl-y fi-ivb-3520m Missing (5): fi-kbl-soraka fi-hsw-4770r fi-ilk-m540 fi-byt-squawks fi-bsw-cyan Build changes ------------- * Linux: CI_DRM_5526 -> Patchwork_12121 CI_DRM_5526: 482f9674140cbe8fddb18714bb95028cd9bfc1d1 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4803: 973367176b61e81b5ca811620adb0467f6570aec @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12121: d78761758c424a6340bdbf94eb12201623e4a8b4 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == d78761758c42 drm/i915/cfl: Adding another PCI Device ID. == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12121/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/cfl: Adding another PCI Device ID. (rev2) 2019-02-01 5:38 [PATCH] drm/i915/cfl: Adding another PCI Device ID Rodrigo Vivi ` (5 preceding siblings ...) 2019-02-02 0:24 ` ✓ Fi.CI.BAT: success " Patchwork @ 2019-02-02 1:30 ` Patchwork 6 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-02-02 1:30 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: drm/i915/cfl: Adding another PCI Device ID. (rev2) URL : https://patchwork.freedesktop.org/series/56075/ State : success == Summary == CI Bug Log - changes from CI_DRM_5526_full -> Patchwork_12121_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_12121_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_schedule@pi-ringfull-blt: - shard-apl: NOTRUN -> FAIL [fdo#103158] +1 * igt@kms_busy@extended-modeset-hang-newfb-render-a: - shard-apl: NOTRUN -> DMESG-WARN [fdo#107956] * igt@kms_ccs@pipe-a-crc-sprite-planes-basic: - shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145] - shard-glk: PASS -> FAIL [fdo#108145] * igt@kms_cursor_crc@cursor-128x42-onscreen: - shard-glk: PASS -> FAIL [fdo#103232] +3 - shard-apl: PASS -> FAIL [fdo#103232] +1 * igt@kms_flip@flip-vs-absolute-wf_vblank: - shard-hsw: PASS -> DMESG-FAIL [fdo#102614] * igt@kms_flip@flip-vs-expired-vblank: - shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363] * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render: - shard-apl: PASS -> FAIL [fdo#103167] +1 * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu: - shard-glk: PASS -> FAIL [fdo#103167] +4 * igt@kms_plane@pixel-format-pipe-b-planes: - shard-glk: PASS -> FAIL [fdo#103166] * igt@kms_plane@pixel-format-pipe-c-planes-source-clamping: - shard-apl: PASS -> FAIL [fdo#108948] * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max: - shard-apl: NOTRUN -> FAIL [fdo#108145] * igt@kms_plane_multiple@atomic-pipe-b-tiling-none: - shard-apl: PASS -> FAIL [fdo#103166] * igt@kms_plane_multiple@atomic-pipe-b-tiling-y: - shard-apl: NOTRUN -> FAIL [fdo#103166] +2 * igt@kms_sysfs_edid_timing: - shard-apl: NOTRUN -> FAIL [fdo#100047] #### Possible fixes #### * igt@kms_color@pipe-a-degamma: - shard-apl: FAIL [fdo#104782] / [fdo#108145] -> PASS * igt@kms_cursor_crc@cursor-256x85-sliding: - shard-apl: FAIL [fdo#103232] -> PASS +1 - shard-glk: FAIL [fdo#103232] -> PASS +1 * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt: - shard-apl: FAIL [fdo#103167] -> PASS * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move: - shard-glk: FAIL [fdo#103167] -> PASS +3 * igt@kms_plane_multiple@atomic-pipe-c-tiling-none: - shard-glk: FAIL [fdo#103166] -> PASS +3 * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf: - shard-apl: FAIL [fdo#103166] -> PASS +2 * igt@kms_setmode@basic: - shard-apl: FAIL [fdo#99912] -> PASS * igt@pm_rc6_residency@rc6-accuracy: - shard-snb: {SKIP} [fdo#109271] -> PASS #### Warnings #### * igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb: - shard-apl: DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145] -> FAIL [fdo#108145] {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047 [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558 [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510 [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (7 -> 5) ------------------------------ Missing (2): shard-skl shard-iclb Build changes ------------- * Linux: CI_DRM_5526 -> Patchwork_12121 CI_DRM_5526: 482f9674140cbe8fddb18714bb95028cd9bfc1d1 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4803: 973367176b61e81b5ca811620adb0467f6570aec @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12121: d78761758c424a6340bdbf94eb12201623e4a8b4 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12121/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-02-02 8:23 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-02-01 5:38 [PATCH] drm/i915/cfl: Adding another PCI Device ID Rodrigo Vivi 2019-02-01 6:15 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2019-02-01 6:36 ` ✓ Fi.CI.BAT: success " Patchwork 2019-02-01 9:42 ` ✓ Fi.CI.IGT: " Patchwork 2019-02-01 18:01 ` [PATCH] " Souza, Jose 2019-02-01 23:50 ` Rodrigo Vivi 2019-02-02 0:09 ` Souza, Jose 2019-02-02 8:23 ` Rodrigo Vivi 2019-02-02 0:02 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/cfl: Adding another PCI Device ID. (rev2) Patchwork 2019-02-02 0:24 ` ✓ Fi.CI.BAT: success " Patchwork 2019-02-02 1:30 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox