Re: [PATCH 5/5] drm/i915/gtt: Refactor common ppgtt initialisation

From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915/gtt: Refactor common ppgtt initialisation
Date: Fri, 15 Mar 2019 10:59:19 -0700	[thread overview]
Message-ID: <20190315175919.GC6328@intel.com> (raw)
In-Reply-To: <20190315102604.170ad71e@bpaauwe-desk.fm.intel.com>

On Fri, Mar 15, 2019 at 10:26:04AM -0700, Bob Paauwe wrote:
> On Fri, 15 Mar 2019 10:01:51 -0700
> Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> 
> > On Fri, Mar 15, 2019 at 09:55:47AM -0700, Bob Paauwe wrote:
> > > On Fri, 15 Mar 2019 09:09:11 +0000
> > > Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >   
> > > > Quoting Rodrigo Vivi (2019-03-14 22:53:44)  
> > > > > On Thu, Mar 14, 2019 at 10:38:39PM +0000, Chris Wilson wrote:    
> > > > > > The basic setup of the i915_hw_ppgtt is the same between gen6 and gen8,
> > > > > > so refactor that into a common routine.
> > > > > > 
> > > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > > Cc: Bob Paauwe <bob.j.paauwe@intel.com>
> > > > > > Cc: Matthew Auld <matthew.william.auld@gmail.com>
> > > > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>    
> > > > > 
> > > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>    
> > > > 
> > > > I've pushed this series so that 36 bits should be a nice and simple drop
> > > > in.
> > > > 
> > > > Thank you Bob for preparing these, sorry for not being clear enough on
> > > > the direction I felt the patches should take.
> > > > -Chris  
> > > 
> > > Thanks Chris,  
> > 
> > Thanks a lot Chris.
> > 
> > > 
> > > It was helpful to see how you organized and re-wrote the series. This
> > > was not code I was familiar with when I started so you're guidance
> > > helped a lot.
> > > 
> > > Now I get to fix the EHL patches to take advantage of this.  
> > 
> > cool, so I will split the series into rv-b ones and probably
> > push soon just leaving the ppgt_size one for you to rebase
> > on top...
> > 
> > thoughts?
> 
> Would it make more sense to drop Patch 8, drm/i915/ehl: ehl has only
> 36bit extended ppgtt support and update patch 1 with the size added to the
> device_info?
> 
> Otherwise, patch 8 becomes just adding the size into the device_info.

of course!

Unfortunately I read the email after I sent the rv-b patches for CI...
But I will change it there and send a v2 on top.

> 
> Either way works for me.
> 
> > 
> > > 
> > > Bob  
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx  
> > > 
> > > 
> > > -- 
> > > --
> > > Bob Paauwe                  
> > > Bob.J.Paauwe@intel.com
> > > IOTG / PED Software Organization
> > > Intel Corp.  Folsom, CA
> > > (916) 356-6193    
> > > 
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx  
> 
> 
> 
> -- 
> --
> Bob Paauwe                  
> Bob.J.Paauwe@intel.com
> IOTG / PED Software Organization
> Intel Corp.  Folsom, CA
> (916) 356-6193    
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx