From: kbuild test robot <lkp@intel.com>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com,
kbuild-all@01.org, maarten.lankhorst@intel.com
Subject: Re: [v6 11/16] drm/i915/icl: Enable Plane Degamma
Date: Wed, 20 Mar 2019 03:31:13 +0800 [thread overview]
Message-ID: <201903200339.qZzlK3XT%lkp@intel.com> (raw)
In-Reply-To: <1552985064-11974-12-git-send-email-uma.shankar@intel.com>
Hi Uma,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20190319]
[cannot apply to v5.1-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Uma-Shankar/Add-Plane-Color-Properties/20190319-222429
base: git://anongit.freedesktop.org/drm-intel for-linux-next
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
sparse warnings: (new ones prefixed by >>)
include/uapi/linux/perf_event.h:147:56: sparse: cast truncates bits from constant value (8000000000000000 becomes 0)
>> drivers/gpu/drm/i915/intel_color.c:635:55: sparse: constant 0x7ffffffff is so big it is long
drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void)
drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void)
vim +635 drivers/gpu/drm/i915/intel_color.c
617
618 static void icl_load_plane_degamma_lut(const struct drm_plane_state *state,
619 u32 offset)
620 {
621 struct drm_i915_private *dev_priv = to_i915(state->plane->dev);
622 enum pipe pipe = to_intel_plane(state->plane)->pipe;
623 enum plane_id plane = to_intel_plane(state->plane)->id;
624 u32 i, lut_size;
625
626 if (icl_is_hdr_plane(dev_priv, plane)) {
627 lut_size = 128;
628 if (state->degamma_lut) {
629 struct drm_color_lut_ext *lut =
630 (struct drm_color_lut_ext *)state->gamma_lut->data;
631
632 for (i = 0; i < lut_size; i++) {
633 u64 word = drm_color_lut_extract_ext(lut[i].red,
634 24);
> 635 u32 lut_val = (word & 0x7ffffffff) >> 8;
636
637 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i),
638 lut_val);
639 }
640
641 /* Program the max register to clamp values > 1.0. */
642 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
643 drm_color_lut_extract_ext(lut[i].red, 24));
644 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 1),
645 drm_color_lut_extract_ext(lut[i].green, 24));
646 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 2),
647 drm_color_lut_extract_ext(lut[i].blue, 24));
648 } else {
649 for (i = 0; i < lut_size; i++) {
650 u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
651 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i), v);
652 }
653
654 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
655 (1 << 24) - 1);
656 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 1),
657 (1 << 24) - 1);
658 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 2),
659 (1 << 24) - 1);
660 }
661 } else {
662 lut_size = 32;
663 if (state->degamma_lut) {
664 struct drm_color_lut *lut =
665 (struct drm_color_lut *)state->gamma_lut->data;
666
667 for (i = 0; i < lut_size; i++)
668 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i),
669 lut[i].green);
670
671 /* Program the max register to clamp values > 1.0. */
672 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 0),
673 (1 << 16));
674 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 1),
675 (1 << 16));
676 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 2),
677 (1 << 16));
678 } else {
679 for (i = 0; i < lut_size; i++) {
680 u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
681
682 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i), v);
683 }
684
685 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 0),
686 (1 << 16));
687 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 1),
688 (1 << 16));
689 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 2),
690 (1 << 16));
691 }
692 }
693 }
694
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-19 19:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 8:44 [v6 00/16] Add Plane Color Properties Uma Shankar
2019-03-19 8:44 ` [v6 01/16] drm: Add Enhanced Gamma LUT precision structure Uma Shankar
2019-03-27 12:12 ` Lankhorst, Maarten
2019-03-28 13:49 ` Shankar, Uma
2019-03-19 8:44 ` [v6 02/16] drm: Add Plane Degamma properties Uma Shankar
2019-03-19 19:09 ` kbuild test robot
2019-03-19 8:44 ` [v6 03/16] drm: Add Plane CTM property Uma Shankar
2019-03-19 22:45 ` kbuild test robot
2019-03-19 8:44 ` [v6 04/16] drm: Add Plane Gamma properties Uma Shankar
2019-03-20 2:36 ` kbuild test robot
2019-03-19 8:44 ` [v6 05/16] drm: Define helper function for plane color enabling Uma Shankar
2019-03-19 8:44 ` [v6 06/16] drm/i915: Enable plane color features Uma Shankar
2019-03-19 8:44 ` [v6 07/16] drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms Uma Shankar
2019-03-19 8:44 ` [v6 08/16] drm/i915: Load plane color luts from atomic flip Uma Shankar
2019-03-19 8:44 ` [v6 09/16] drm/i915: Add plane color capabilities Uma Shankar
2019-03-19 8:44 ` [v6 10/16] drm/i915/icl: Add ICL Plane Degamma Register definition Uma Shankar
2019-03-25 17:36 ` Matt Roper
2019-03-26 13:59 ` Shankar, Uma
2019-03-19 8:44 ` [v6 11/16] drm/i915/icl: Enable Plane Degamma Uma Shankar
2019-03-19 19:31 ` kbuild test robot [this message]
2019-03-19 8:44 ` [v6 12/16] drm/i915/icl: Add Plane Gamma Register Definitions Uma Shankar
2019-03-19 8:44 ` [v6 13/16] drm/i915/icl: Implement Plane Gamma Uma Shankar
2019-03-19 8:44 ` [v6 14/16] drm/i915: Enable Plane Gamma/Degamma Uma Shankar
2019-03-19 8:44 ` [v6 15/16] drm/i915: Define Plane CSC Registers Uma Shankar
2019-03-19 8:44 ` [v6 16/16] drm/i915: Enable Plane CSC Uma Shankar
2019-03-19 9:06 ` ✗ Fi.CI.CHECKPATCH: warning for Add Plane Color Properties (rev6) Patchwork
2019-03-19 9:16 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-03-19 9:25 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-19 17:12 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201903200339.qZzlK3XT%lkp@intel.com \
--to=lkp@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=maarten.lankhorst@intel.com \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox