From: Daniel Vetter <daniel@ffwll.ch>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock
Date: Tue, 26 Mar 2019 19:10:02 +0100 [thread overview]
Message-ID: <20190326181002.GK2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190326173401.7329-1-ville.syrjala@linux.intel.com>
On Tue, Mar 26, 2019 at 07:33:58PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drm_display_info.pixel_clock is unused. Let's get rid of it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> include/drm/drm_connector.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index bb3bd8e1633a..fcdca46e0c24 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -369,12 +369,6 @@ struct drm_display_info {
> */
> unsigned int height_mm;
>
> - /**
> - * @pixel_clock: Maximum pixel clock supported by the sink, in units of
> - * 100Hz. This mismatches the clock in &drm_display_mode (which is in
> - * kHZ), because that's what the EDID uses as base unit.
> - */
> - unsigned int pixel_clock;
I'm wondering how I've come up with this fantasy of a text, because afaict
it wasn't ever used. At least seems unused back when I wrote the
kerneldoc.
*shrug*
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> /**
> * @bpc: Maximum bits per color channel. Used by HDMI and DP outputs.
> */
> --
> 2.19.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-26 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 17:33 [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock Ville Syrjala
2019-03-26 17:33 ` [PATCH 2/4] drm: Fix tabs vs. spaces Ville Syrjala
2019-03-26 18:10 ` Daniel Vetter
2019-03-26 17:34 ` [PATCH 3/4] drm: Kill drm_display_info.name Ville Syrjala
2019-03-26 18:11 ` [Intel-gfx] " Daniel Vetter
2019-03-26 21:53 ` Sam Ravnborg
2019-03-26 17:34 ` [PATCH 4/4] drm/uapi: Remove unused DRM_DISPLAY_INFO_LEN Ville Syrjala
2019-03-26 18:15 ` Daniel Vetter
2019-03-26 18:10 ` Daniel Vetter [this message]
2019-03-26 20:45 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm: Nuke unused drm_display_info.pixel_clock Patchwork
2019-03-27 7:16 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326181002.GK2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox