public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/4] drm: Kill drm_display_info.name
Date: Tue, 26 Mar 2019 19:11:23 +0100	[thread overview]
Message-ID: <20190326181123.GM2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190326173401.7329-3-ville.syrjala@linux.intel.com>

On Tue, Mar 26, 2019 at 07:34:00PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> drm_display_info.name is only ever set by a few panel drveirs but
> never actually used anywhere except in i915 debugfs code. Trash it.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Huh, nice find.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c                | 1 -
>  drivers/gpu/drm/panel/panel-arm-versatile.c        | 2 --
>  drivers/gpu/drm/panel/panel-ilitek-ili9322.c       | 2 --
>  drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 1 -
>  drivers/gpu/drm/panel/panel-samsung-s6d16d0.c      | 3 ---
>  drivers/gpu/drm/panel/panel-tpo-tpg110.c           | 2 --
>  include/drm/drm_connector.h                        | 5 -----
>  7 files changed, 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 47bf07a59b5e..933228443b96 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2866,7 +2866,6 @@ static void intel_connector_info(struct seq_file *m,
>  	if (connector->status == connector_status_disconnected)
>  		return;
>  
> -	seq_printf(m, "\tname: %s\n", connector->display_info.name);
>  	seq_printf(m, "\tphysical dimensions: %dx%dmm\n",
>  		   connector->display_info.width_mm,
>  		   connector->display_info.height_mm);
> diff --git a/drivers/gpu/drm/panel/panel-arm-versatile.c b/drivers/gpu/drm/panel/panel-arm-versatile.c
> index 078fa2c0eef8..a79908dfa3c8 100644
> --- a/drivers/gpu/drm/panel/panel-arm-versatile.c
> +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c
> @@ -264,8 +264,6 @@ static int versatile_panel_get_modes(struct drm_panel *panel)
>  	struct versatile_panel *vpanel = to_versatile_panel(panel);
>  	struct drm_display_mode *mode;
>  
> -	strncpy(connector->display_info.name, vpanel->panel_type->name,
> -		DRM_DISPLAY_INFO_LEN);
>  	connector->display_info.width_mm = vpanel->panel_type->width_mm;
>  	connector->display_info.height_mm = vpanel->panel_type->height_mm;
>  	connector->display_info.bus_flags = vpanel->panel_type->bus_flags;
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
> index 35497ff08391..a1c4cd2940fb 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
> @@ -662,8 +662,6 @@ static int ili9322_get_modes(struct drm_panel *panel)
>  	struct ili9322 *ili = panel_to_ili9322(panel);
>  	struct drm_display_mode *mode;
>  
> -	strncpy(connector->display_info.name, "ILI9322 TFT LCD driver\0",
> -		DRM_DISPLAY_INFO_LEN);
>  	connector->display_info.width_mm = ili->conf->width_mm;
>  	connector->display_info.height_mm = ili->conf->height_mm;
>  
> diff --git a/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c b/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c
> index 5e8d4523e9ed..a1d8d92fac2b 100644
> --- a/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c
> +++ b/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c
> @@ -190,7 +190,6 @@ static int lcd_olinuxino_get_modes(struct drm_panel *panel)
>  		num++;
>  	}
>  
> -	memcpy(connector->display_info.name, lcd_info->name, 32);
>  	connector->display_info.width_mm = lcd_info->width_mm;
>  	connector->display_info.height_mm = lcd_info->height_mm;
>  	connector->display_info.bpc = lcd_info->bpc;
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> index 33c22ee036f8..f75bef24e050 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> @@ -148,9 +148,6 @@ static int s6d16d0_get_modes(struct drm_panel *panel)
>  	struct drm_connector *connector = panel->connector;
>  	struct drm_display_mode *mode;
>  
> -	strncpy(connector->display_info.name, "Samsung S6D16D0\0",
> -		DRM_DISPLAY_INFO_LEN);
> -
>  	mode = drm_mode_duplicate(panel->drm, &samsung_s6d16d0_mode);
>  	if (!mode) {
>  		DRM_ERROR("bad mode or failed to add mode\n");
> diff --git a/drivers/gpu/drm/panel/panel-tpo-tpg110.c b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> index 25f00cfc1af4..71591e5f5938 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> @@ -390,8 +390,6 @@ static int tpg110_get_modes(struct drm_panel *panel)
>  	struct tpg110 *tpg = to_tpg110(panel);
>  	struct drm_display_mode *mode;
>  
> -	strncpy(connector->display_info.name, tpg->panel_mode->name,
> -		DRM_DISPLAY_INFO_LEN);
>  	connector->display_info.width_mm = tpg->width;
>  	connector->display_info.height_mm = tpg->height;
>  	connector->display_info.bus_flags = tpg->panel_mode->bus_flags;
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index c5bff7518ec5..02a131202add 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -355,11 +355,6 @@ enum drm_bus_flags {
>   * drm_add_edid_modes().
>   */
>  struct drm_display_info {
> -	/**
> -	 * @name: Name of the display.
> -	 */
> -	char name[DRM_DISPLAY_INFO_LEN];
> -
>  	/**
>  	 * @width_mm: Physical width in mm.
>  	 */
> -- 
> 2.19.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-03-26 18:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 17:33 [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock Ville Syrjala
2019-03-26 17:33 ` [PATCH 2/4] drm: Fix tabs vs. spaces Ville Syrjala
2019-03-26 18:10   ` Daniel Vetter
2019-03-26 17:34 ` [PATCH 3/4] drm: Kill drm_display_info.name Ville Syrjala
2019-03-26 18:11   ` Daniel Vetter [this message]
2019-03-26 21:53   ` Sam Ravnborg
2019-03-26 17:34 ` [PATCH 4/4] drm/uapi: Remove unused DRM_DISPLAY_INFO_LEN Ville Syrjala
2019-03-26 18:15   ` Daniel Vetter
2019-03-26 18:10 ` [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock Daniel Vetter
2019-03-26 20:45 ` ✓ Fi.CI.BAT: success for series starting with [1/4] " Patchwork
2019-03-27  7:16 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190326181123.GM2665@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox