From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 09/10] drm/i915: Drop the pointless linear legacy LUT load on CHV
Date: Wed, 27 Mar 2019 17:50:44 +0200 [thread overview]
Message-ID: <20190327155045.28446-10-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20190327155045.28446-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We now bypass the legacy LUT when it's not needed, so
no point in filling it up with a linear LUT.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/intel_color.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
index 66e2b7d48410..8d8fca7b5d65 100644
--- a/drivers/gpu/drm/i915/intel_color.c
+++ b/drivers/gpu/drm/i915/intel_color.c
@@ -376,15 +376,6 @@ static void i9xx_load_luts_internal(const struct intel_crtc_state *crtc_state,
(drm_color_lut_extract(lut[i].green, 8) << 8) |
drm_color_lut_extract(lut[i].blue, 8);
- if (HAS_GMCH(dev_priv))
- I915_WRITE(PALETTE(pipe, i), word);
- else
- I915_WRITE(LGC_PALETTE(pipe, i), word);
- }
- } else {
- for (i = 0; i < 256; i++) {
- u32 word = (i << 16) | (i << 8) | i;
-
if (HAS_GMCH(dev_priv))
I915_WRITE(PALETTE(pipe, i), word);
else
@@ -643,7 +634,7 @@ static void cherryview_load_luts(const struct intel_crtc_state *crtc_state)
cherryview_load_csc_matrix(crtc_state);
if (crtc_state_is_legacy_gamma(crtc_state)) {
- i9xx_load_luts_internal(crtc_state, gamma_lut);
+ i9xx_load_luts(crtc_state);
return;
}
@@ -682,12 +673,6 @@ static void cherryview_load_luts(const struct intel_crtc_state *crtc_state)
I915_WRITE(CGM_PIPE_GAMMA(pipe, i, 1), word1);
}
}
-
- /*
- * Also program a linear LUT in the legacy block (behind the
- * CGM block).
- */
- i9xx_load_luts_internal(crtc_state, NULL);
}
void intel_color_load_luts(const struct intel_crtc_state *crtc_state)
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-27 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 15:50 [PATCH v2 00/10] drm/i915: Clean up intel_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 01/10] drm/i915: Extract check_luts() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 02/10] drm/i915: Turn intel_color_check() into a vfunc Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 03/10] drm/i915: Extract i9xx_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 04/10] drm/i915: Extract chv_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 05/10] drm/i915: Extract icl_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 06/10] drm/i915: Extract glk_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 07/10] drm/i915: Extract bdw_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 08/10] drm/i915: Extract ilk_color_check() Ville Syrjala
2019-03-27 15:50 ` Ville Syrjala [this message]
2019-03-27 15:50 ` [PATCH v2 10/10] drm/i915: Skip the linear degamma LUT load on ICL+ Ville Syrjala
2019-03-27 17:30 ` [PATCH v2 00/10] drm/i915: Clean up intel_color_check() Matt Roper
2019-03-28 19:33 ` Ville Syrjälä
2019-03-27 20:07 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Clean up intel_color_check() (rev2) Patchwork
2019-03-27 21:00 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-28 17:38 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327155045.28446-10-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox