From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 07/10] drm/i915: Extract bdw_color_check()
Date: Wed, 27 Mar 2019 17:50:42 +0200 [thread overview]
Message-ID: <20190327155045.28446-8-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20190327155045.28446-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Provide a separate .color_check() for BDW+ where we currently
provide the split gamma mode etc.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/intel_color.c | 39 ++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
index 90ebcf7bef82..d9be011ae49a 100644
--- a/drivers/gpu/drm/i915/intel_color.c
+++ b/drivers/gpu/drm/i915/intel_color.c
@@ -883,6 +883,43 @@ static int chv_color_check(struct intel_crtc_state *crtc_state)
return 0;
}
+static u32 bdw_gamma_mode(const struct intel_crtc_state *crtc_state)
+{
+ if (!crtc_state->gamma_enable ||
+ crtc_state_is_legacy_gamma(crtc_state))
+ return GAMMA_MODE_MODE_8BIT;
+ else
+ return GAMMA_MODE_MODE_SPLIT;
+}
+
+static int bdw_color_check(struct intel_crtc_state *crtc_state)
+{
+ int ret;
+
+ ret = check_luts(crtc_state);
+ if (ret)
+ return ret;
+
+ crtc_state->gamma_enable =
+ (crtc_state->base.gamma_lut ||
+ crtc_state->base.degamma_lut) &&
+ !crtc_state->c8_planes;
+
+ crtc_state->csc_enable =
+ crtc_state->output_format != INTEL_OUTPUT_FORMAT_RGB ||
+ crtc_state->base.ctm || crtc_state->limited_color_range;
+
+ crtc_state->gamma_mode = bdw_gamma_mode(crtc_state);
+
+ crtc_state->csc_mode = 0;
+
+ ret = intel_color_add_affected_planes(crtc_state);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
static u32 glk_gamma_mode(const struct intel_crtc_state *crtc_state)
{
if (!crtc_state->gamma_enable ||
@@ -1033,6 +1070,8 @@ void intel_color_init(struct intel_crtc *crtc)
dev_priv->display.color_check = icl_color_check;
else if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
dev_priv->display.color_check = glk_color_check;
+ else if (INTEL_GEN(dev_priv) >= 8)
+ dev_priv->display.color_check = bdw_color_check;
else
dev_priv->display.color_check = _intel_color_check;
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-27 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 15:50 [PATCH v2 00/10] drm/i915: Clean up intel_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 01/10] drm/i915: Extract check_luts() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 02/10] drm/i915: Turn intel_color_check() into a vfunc Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 03/10] drm/i915: Extract i9xx_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 04/10] drm/i915: Extract chv_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 05/10] drm/i915: Extract icl_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 06/10] drm/i915: Extract glk_color_check() Ville Syrjala
2019-03-27 15:50 ` Ville Syrjala [this message]
2019-03-27 15:50 ` [PATCH v2 08/10] drm/i915: Extract ilk_color_check() Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 09/10] drm/i915: Drop the pointless linear legacy LUT load on CHV Ville Syrjala
2019-03-27 15:50 ` [PATCH v2 10/10] drm/i915: Skip the linear degamma LUT load on ICL+ Ville Syrjala
2019-03-27 17:30 ` [PATCH v2 00/10] drm/i915: Clean up intel_color_check() Matt Roper
2019-03-28 19:33 ` Ville Syrjälä
2019-03-27 20:07 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Clean up intel_color_check() (rev2) Patchwork
2019-03-27 21:00 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-28 17:38 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327155045.28446-8-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox