From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: reorder if chain to have last gen first
Date: Mon, 8 Apr 2019 15:36:34 -0700 [thread overview]
Message-ID: <20190408223634.GC28546@intel.com> (raw)
In-Reply-To: <20190404230426.15837-3-lucas.demarchi@intel.com>
On Thu, Apr 04, 2019 at 04:04:25PM -0700, Lucas De Marchi wrote:
> Reorder if/else so we check for gen >= 11 first, similar to most of
> other checks in the driver.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 0e05ee1f3ea0..25eff3728fcd 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4367,15 +4367,16 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *cstate,
> return 0;
> }
>
> - if (INTEL_GEN(dev_priv) < 11)
> + if (INTEL_GEN(dev_priv) >= 11)
> + total_data_rate =
> + icl_get_total_relative_data_rate(cstate,
> + plane_data_rate);
> + else
> total_data_rate =
> skl_get_total_relative_data_rate(cstate,
> plane_data_rate,
> uv_plane_data_rate);
> - else
> - total_data_rate =
> - icl_get_total_relative_data_rate(cstate,
> - plane_data_rate);
> +
>
> skl_ddb_get_pipe_allocation_limits(dev_priv, cstate, total_data_rate,
> ddb, alloc, &num_active);
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-08 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 23:04 [PATCH 0/3] Trivial comments and small changes Lucas De Marchi
2019-04-04 23:04 ` [PATCH 1/3] drm/i915/icl: fix step numbers in icl_display_core_init() Lucas De Marchi
2019-04-08 22:36 ` Rodrigo Vivi
2019-04-04 23:04 ` [PATCH 2/3] drm/i915: reorder if chain to have last gen first Lucas De Marchi
2019-04-08 22:36 ` Rodrigo Vivi [this message]
2019-04-04 23:04 ` [PATCH 3/3] drm/i915: do not mix workaround with normal flow Lucas De Marchi
2019-04-08 22:37 ` Rodrigo Vivi
2019-04-05 0:05 ` ✓ Fi.CI.BAT: success for Trivial comments and small changes Patchwork
2019-04-05 19:53 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408223634.GC28546@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox